Code review comment for lp:~bac/launchpad/bug-436986-team-map

Revision history for this message
Abel Deuring (adeuring) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 16.10.2009 16:24, Brad Crittenden wrote:
>> thanks for your explanations on IRC for my quite stupid questions...
>> r=me
>
> Good questions and good ideas on making the tests clearer and reducing the propagation of magic numbers.
>
> An incremental diff is at http://pastebin.ubuntu.com/294744/

looks good

Abel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFK2KtRekBPhm8NrtARAqVuAJ9pGKQDc8VIzsBrrFRto7W5ukdFcgCfXaMz
ppWQrb3knAx6QJtc9ESFSDk=
=tDYn
-----END PGP SIGNATURE-----

« Back to merge proposal