Please take a look.
https://codereview.appspot.com/57900043/diff/1/quickstart/manage.py File quickstart/manage.py (right):
https://codereview.appspot.com/57900043/diff/1/quickstart/manage.py#newcode294 quickstart/manage.py:294: At bootstrap, juju (v1.17 and later) writes the admin-secret to a On 2014/01/29 11:48:40, frankban wrote: > IIRC Jenv files are generated starting form v1.16.
Done.
https://codereview.appspot.com/57900043/diff/1/quickstart/manage.py#newcode309 quickstart/manage.py:309: raise ValueError('admin-secret not found in {}.'.format(filename)) On 2014/01/29 11:48:40, frankban wrote: > Please encode('utf-8') the ValueError message.
https://codereview.appspot.com/57900043/diff/1/quickstart/manage.py#newcode316 quickstart/manage.py:316: - admin_secret: the password to use to access the Juju API; On 2014/01/29 11:48:40, frankban wrote: > ... or None if the admin-secret field is not found in the environments YAML > file... or similar?
https://codereview.appspot.com/57900043/diff/1/quickstart/manage.py#newcode419 quickstart/manage.py:419: options.admin_secret = _get_admin_secret( Good idea. I've moved the definition of get_admin_secret to app.
https://codereview.appspot.com/57900043/
« Back to merge proposal
Please take a look.
https:/ /codereview. appspot. com/57900043/ diff/1/ quickstart/ manage. py manage. py (right):
File quickstart/
https:/ /codereview. appspot. com/57900043/ diff/1/ quickstart/ manage. py#newcode294 manage. py:294: At bootstrap, juju (v1.17 and later) writes
quickstart/
the admin-secret to a
On 2014/01/29 11:48:40, frankban wrote:
> IIRC Jenv files are generated starting form v1.16.
Done.
https:/ /codereview. appspot. com/57900043/ diff/1/ quickstart/ manage. py#newcode309 manage. py:309: raise ValueError( 'admin- secret not found in filename) )
quickstart/
{}.'.format(
On 2014/01/29 11:48:40, frankban wrote:
> Please encode('utf-8') the ValueError message.
Done.
https:/ /codereview. appspot. com/57900043/ diff/1/ quickstart/ manage. py#newcode316 manage. py:316: - admin_secret: the password to use to access
quickstart/
the Juju API;
On 2014/01/29 11:48:40, frankban wrote:
> ... or None if the admin-secret field is not found in the environments
YAML
> file... or similar?
Done.
https:/ /codereview. appspot. com/57900043/ diff/1/ quickstart/ manage. py#newcode419 manage. py:419: options. admin_secret = _get_admin_secret(
quickstart/
Good idea. I've moved the definition of get_admin_secret to app.
https:/ /codereview. appspot. com/57900043/