lp:~bac/juju-quickstart/auth

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-quickstart at revision 50

Juju GUI Hackers: Pending requested 2014-01-28

Diff: 501 lines (+224/-35)

7 files modified

quickstart/app.py (+23/-0)
quickstart/manage.py (+20/-5)
quickstart/models/envs.py (+39/-17)
quickstart/tests/cli/test_views.py (+2/-2)
quickstart/tests/models/test_envs.py (+68/-9)
quickstart/tests/test_app.py (+20/-0)
quickstart/tests/test_manage.py (+52/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1271341: user-admin password no longer found in environments.yaml

High

Fix Released

Link a bug report

Related blueprints

52. By Brad Crittenden on 2014-01-29

lint

51. By Brad Crittenden on 2014-01-29

Code reorg from review. Handle exceptions more appropriately.

50. By Brad Crittenden on 2014-01-28

lint

49. By Brad Crittenden on 2014-01-28

Get admin_secret from jenv files if not otherwise set.

48. By Francesco Banconi on 2014-01-20

Support the new juju switch behavior.

Quickstart is now able to retrieve the
default environment name in newer
versions of juju-core.

Tests: `make check`.
No QA required.

R=gary.poster
CC=
https://codereview.appspot.com/54560043

47. By Francesco Banconi on 2014-01-17

Improve machine errors handling.

Quickstart no longer hangs when the GUI
machine goes in an "error" state and, as
a consequence, the unit is forever in
a "pending" state.

Also fixed the message printed at the
end of the process suggesting how to
destroy the environment
(sudo is used where required).

Tests: `make check`.

QA: I already asked Rick to reproduce the trusty/LXC
errors he encountered QAing my previous branch.
The GUI no longer hangs.
I'd also appreciate any other suggestion and additional
QA, given that this branch is a good candidate for 1.0.

R=bac, rharding
CC=
https://codereview.appspot.com/51350044

46. By Francesco Banconi on 2014-01-16

Add support for OpenStack and Azure.

Tests: `make check`

QA: `.venv/bin/python juju-quickstart -i`
Ensure you can successfully create an openstack/HP cloud
and an azure environment.
If you already subscribed to any of those, please
check everything works ok. If not, no problem,
I already bootstrapped HP Cloud and azure.
Since this is the 1.0 version, please ensure
the environment management works well, and in general
quickstart bootstraps the environments and
deploys the GUI as expected.
Thank you!

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/52080044

45. By Francesco Banconi on 2014-01-14

Create a backup copy of the envs file.

In a pre-imp call with Gary, we decided the
following strategy: a backup copy of the
environments.yaml file is created once per
quickstart session the first time environments
are changed by the user. This way we prevent the
original backup to be overwritten if the user
makes two subsequent changes to the envs.

Tests: `make check`.

QA:

- Create a backup copy of your environments file:
  `cp ~/.juju/environments.yaml ~/environments.yaml.bak`.

- Run `.venv/bin/python juju-quickstart -i`, select one
  of your environments, exit with ^X without changing anything.
  Check your original file has not been changed.

- Run `.venv/bin/python juju-quickstart -i`, change something
  (e.g. create, remove or change an environment, or just change
  the default one). Change at least two environments.
  Exit with ^X. The envs.yaml file now should be the one
  generated by quickstart and should reflect your changes.
  It also includes the path to the backup copy, which
  should be your original file.

- Restore your original environments file:
  `mv ~/environments.yaml.bak ~/.juju/environments.yaml`.

Done, thank you!

R=
CC=
https://codereview.appspot.com/51520043

44. By Francesco Banconi on 2014-01-13

Integrate the env management functionality.

This branch enables the environment management
Urwid interactive session feature in quickstart,
but also includes some other improvements, described
below.

Exposed a way to let the user quickly
create and bootstrap a local env if no environments
are already configured. This is implemented
adding a closure (create_and_start_local_env) to the
env_index view: this could have been implemented
as a separate function as well (more easily testable,
less surprising), but I decided to stick with the
pattern used by the other views for now.

Changed the env_edit view so that the first created
environment is automatically set as default.

Renamed manage._validate_env to manage._setup_env:
the function now does a lot more than validation, e.g.
it lunches the interactive session, handles the
case when the Juju home is not yet configured, etc.
This function also sets up a save_callable to be used
by views. I could have used partial to create such a
function, but I decided to implement a HO
_create_save_callable that can be easily be extended
later in order to enable the backup functionality.

Bumped version up.

The diff is very long, my apologies, but you can safely
ignore deleted code:
- the demo application, no longer required;
- the ensure_environments function + its tests;
- envs.parse_env_file + its tests (
  replaced by envs.load + envs.validate).
Moreover, the env_type_db definition in
quickstart.models.envs is just a copy/paste replacement
of the original one: the only difference is that
an ordered dict is used in place of the usual dict.
This change has been introduced so that views
can list the supported environment types in the order
they are defined.

Tests: `make check`.

QA: if you have time, given the amount of code
enabled by this branch, and given the differences
in each one Juju configuration, I'd appreciate both
reviewers to QA the interactive session.
The instructions follow, thank you very much!

- Run `make`.

- Backup your Juju home:
  `mv ~/.juju ~/juju-home-backup`
  This way we can simulate Juju is not configured at all.

- Run `.venv/bin/python juju-quickstart`.
  Quickstart should welcome you and propose, among
  other things, to automatically create and bootstrap
  a local environment. Do that, provide your sudo
  password if requested, wait until the process completes
  and the GUI opens in your default browser as usual.
  This can take several minutes based on the sanity of your
  LXC configuration. Before opening the browser, you should
  see instructions on re-running quickstart to reopen
  and log in to the GUI later or restarting the interactive
  session. Also note that an admin password has been
  automatically generated and printed to stdout.

- Run `.venv/bin/python juju-quickstart`.
  This time no interactive session is started, the application
  recognizes the environment is already bootstrapped and
  quickly reopens the browser and logs in to the GUI.

- Run `cat ~/.juju/environments.yaml`.
  Check the generated environment file looks sane.

- Destroy the local environment:
  `sudo juju destroy-environment -e local -y`

- Run `.venv/bin/python juju-quickstart -i`.
  The interactive session should start and this time
  it should list your existing environment.
  Let's customize the local one: click on it, then
  on the "edit" button, and then use the form
  to change its name (e.g. replace "local" with "lxc").
  Hit page-down and click "save" an then "back" to
  return to the index view.
  Now let's create an ec2 environment by selecting
  "new ec2 environment". Call it "aws", auto-generate
  the admin-secret and the control-bucket, fill in your
  ec2 credentials and save the new environment.
  Also make it the default one, either by using the
  checkbox in the form or by clicking "set default"
  from the env details view. From the envs detail view,
  let's go ahead and bootstrap the "aws" env by clicking "use".
  As above, wait for the ec2 environment to be bootstrapped
  and the GUI opened. In the meanwhile, you can run
  `cat ~/.juju/environments.yaml` in another terminal to
  ensure the env file looks good. Note that at this time
  no backup files are created: this is the goal of my next card.

- Run `juju switch` to check that the default environment
  is now "aws".

- Check that command line options validation still work: all the
  following command should exit with pertinent errors:

  .venv/bin/python juju-quickstart --gui-charm-url invalid

  .venv/bin/python juju-quickstart --gui-charm-url http:~juju-gui/precise/juju-gui-80

  .venv/bin/python juju-quickstart --gui-charm-url cs:precise/juju-gui-1 bundle:~jorge/mediawiki-simple/4/mediawiki-simple

  .venv/bin/python juju-quickstart --gui-charm-url cs:saucy/juju-gui-80

  .venv/bin/python juju-quickstart -e no-such

  .venv/bin/python juju-quickstart /no-such-bundle

  .venv/bin/python juju-quickstart bundle:~jorge/mediawiki-simple/4/no-such

- Let's also try to deploy a bundle:
  run `juju unexpose juju-gui` and then
  `.venv/bin/python juju-quickstart bundle:~jorge/mediawiki-simple/4/mediawiki-simple`.
  The service should be re-exposed by quickstart and the bundle
  deployment should start as usual.

- Destroy the ec2 environment: `juju destroy-environment -e aws -y`.

- Restore your existing juju home:
  `rm -rf ~/.juju && mv ~/juju-home-backup .juju`.

- Create a backup copy of your environments file:
  `cp ~/.juju/environments.yaml ~/environments.yaml.bak`.

- Not it's time to be creative. Run quickstart in interactive
  mode (`.venv/bin/python juju-quickstart -i`): you should
  see your environments listed.
  Start changing/removing/creating/bootstrapping your
  environments. Remove required fields, exit without editing
  to check your environments file is not saved by quickstart
  if not necessary, try to create two envs with the same name.
  In a sentence: try hard to break the application in any
  way you can imagine.

- Once done, restore your original environments file:
  `mv ~/environments.yaml.bak ~/.juju/environments.yaml`.

- Remember to destroy all the environments you
  bootstrapped.

Done! Many thanks for going through all these QA steps.

R=benji1, rharding
CC=
https://codereview.appspot.com/50430043

43. By Francesco Banconi on 2014-01-08

Improve field choices handling.

Implement clickable choices: the user can update
the corresponding edit widget by clicking choices.

Also changed the default series field behavior so
that unset values default to "precise".

Tests: `make check`.

QA: start the demo app
(`make` and `./cli-app-demo.py).
Use it to edit existing environments and
to create new ones (ec2 and local).
Check that choice fields
(e.g. ec2's regions or default series)
can be updated by clicking the choices.
Also check that, if the default series
is not set, it defaults to "precise".

R=gary.poster
CC=
https://codereview.appspot.com/34630044