update notifier

Code review comment for lp:~azzar1/update-notifier/livepatch-notification-button

  1. livepatch-notification-button
  2. Merge into ubuntu
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, that looks mostly fine, I'm unsure why you add the action twice though?

+ if (info) {
+ notify_notification_add_action (n, "settings", _("Show Settings…"),
+ notify_action_cb, NULL, NULL);
+ notify_notification_add_action (n, "default", _("Show Settings…"),
+ notify_action_cb, NULL, NULL);

Wouldn't one be enough?

review: Needs Information

« Back to merge proposal