Merge lp:~azzar1/update-notifier/livepatch-notification-button into lp:update-notifier/ubuntu
Proposed by
Andrea Azzarone
Status: | Merged |
---|---|
Approved by: | Sebastien Bacher |
Approved revision: | 951 |
Merged at revision: | 953 |
Proposed branch: | lp:~azzar1/update-notifier/livepatch-notification-button |
Merge into: | lp:update-notifier/ubuntu |
Diff against target: |
146 lines (+64/-8) 2 files modified
debian/changelog (+6/-0) src/livepatch.c (+58/-8) |
To merge this branch: | bzr merge lp:~azzar1/update-notifier/livepatch-notification-button |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher | Approve | ||
Review via email: mp+362478@code.launchpad.net |
Commit message
src/livepatch.c: Add a "Settings..." button to the notification.
To post a comment you must log in.
Thank you for your work, that looks mostly fine, I'm unsure why you add the action twice though?
+ if (info) { notification_ add_action (n, "settings", _("Show Settings…"), notification_ add_action (n, "default", _("Show Settings…"),
+ notify_
+ notify_action_cb, NULL, NULL);
+ notify_
+ notify_action_cb, NULL, NULL);
Wouldn't one be enough?