Code review comment for lp:~azzar1/unity/properly-handle-copy-dialog

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Sorry for being late, but... Yeah, although I'd like to get rid of that WindowManager::Default().IsWindowMapped(app_win->window_id()) check, I know that there are multiple races involved there, so we can't probably avoid it.

Just wondering if it could happen that the mapping would happen afterwards and we'd miss a window because there's no other signal catching that (and compiz might not signal us anything)...

But things work ok with this, so let's put it in production.

review: Approve

« Back to merge proposal