Code review comment for lp:~azzar1/unity/fix-815032

Revision history for this message
Marco Biscaro (marcobiscaro2112) wrote :

Everything looks good.

Just one comment: an option in cssm with default value 0.6667 looks strange for me.

I think it would be better if the value was between 0 and 255 (with default value = 170). Then, the code in UnityScreen::optionChanged would be something like:

case UnityshellOptions::LauncherOpacity:
  launcher->SetBackgroundAlpha(optionGetLauncherOpacity() / 255.0);
  break;

review: Approve

« Back to merge proposal