Merge lp:~azzar1/unity/fix-815032 into lp:unity
Proposed by
Andrea Azzarone
Status: | Merged |
---|---|
Approved by: | Neil J. Patel |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1327 |
Proposed branch: | lp:~azzar1/unity/fix-815032 |
Merge into: | lp:unity |
Diff against target: |
97 lines (+25/-1) 4 files modified
plugins/unityshell/src/Launcher.cpp (+11/-1) plugins/unityshell/src/Launcher.h (+2/-0) plugins/unityshell/src/unityshell.cpp (+4/-0) plugins/unityshell/unityshell.xml.in (+8/-0) |
To merge this branch: | bzr merge lp:~azzar1/unity/fix-815032 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Neil J. Patel (community) | Approve | ||
Marco Trevisan (Treviño) | Approve | ||
Marco Biscaro (community) | Approve | ||
Review via email: mp+69855@code.launchpad.net |
Description of the change
Add a ccsm option to change launcher opacity. the default value is 0.6667, about 0xAA (current default value).
To post a comment you must log in.
Everything looks good.
Just one comment: an option in cssm with default value 0.6667 looks strange for me.
I think it would be better if the value was between 0 and 255 (with default value = 170). Then, the code in UnityScreen: :optionChanged would be something like:
case UnityshellOptio ns::LauncherOpa city: >SetBackgroundA lpha(optionGetL auncherOpacity( ) / 255.0);
launcher-
break;