Merge lp:~azzar1/unity/dash-hud-fullscreen into lp:unity

[Andrea Azzarone]

Enable dash and hud if there is a fullscreen window.

Enable dash/hud if there is a fullscreen window. I don't remember why we disabled it, seems to work fine here.
I did not test it on a multi monitor setup. Would be nice if someone can do that for me.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:3894
http://jenkins.qa.ubuntu.com/job/unity-ci/1127/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-vivid-amd64-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-vivid-armhf-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-vivid-i386-ci/14/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1127/rebuild

review: Needs Fixing (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

Oh, finally... I always wanted to do that.

However, I'm a little concerned about the IsTopWindowFullscreenOnMonitorWithMouse removal, because it might cause a regression for lp:741869.

By the way, this won't affect virtualbox, or vmware because they're using grabs (and part of the fix for the bug above, was considering them), but not fully sure about citrix (it should do the same, though but last version crashes to me).

Also it works perfectly even in multi-monitor, but I've not tested games.

So, I'm going to approve this, but we need to test it further in vivid before backporting to trusty.

review: Approve

=== modified file 'plugins/unityshell/src/unityshell.cpp'
--- plugins/unityshell/src/unityshell.cpp	2014-11-28 12:55:36 +0000
+++ plugins/unityshell/src/unityshell.cpp	2014-12-19 02:52:10 +0000
@@ -961,6 +961,8 @@
 {
   return !allowWindowPaint ||
          lockscreen_controller_->IsLocked() ||
+         dash_controller_->IsVisible() ||
+         hud_controller_->IsVisible() ||
           ((switcher_controller_->Visible() ||
             WindowManager::Default().IsExpoActive())
            && !fullscreen_windows_.empty () && (!(screen->grabbed () && !screen->otherGrabExist (NULL))));
@@ -2119,14 +2121,11 @@
 
     if (!dash_controller_->IsVisible())
     {
-      if (!adapter.IsTopWindowFullscreenOnMonitorWithMouse())
+      if (dash_controller_->ShowDash())
       {
-        if (dash_controller_->ShowDash())
-        {
-          tap_handled = true;
-          ubus_manager_.SendMessage(UBUS_PLACE_ENTRY_ACTIVATE_REQUEST,
-                                    g_variant_new("(sus)", "home.scope", dash::GOTO_DASH_URI, ""));
-        }
+        tap_handled = true;
+        ubus_manager_.SendMessage(UBUS_PLACE_ENTRY_ACTIVATE_REQUEST,
+                                  g_variant_new("(sus)", "home.scope", dash::GOTO_DASH_URI, ""));
       }
     }
     else
@@ -2537,9 +2536,6 @@
 
     auto& wm = WindowManager::Default();
 
-    if (wm.IsTopWindowFullscreenOnMonitorWithMouse())
-      return false;
-
     if (wm.IsScreenGrabbed())
     {
       hud_ungrab_slot_ = wm.screen_ungrabbed.connect([this] { ShowHud(); });