Code review comment for lp:~azzar1/unity/dash-hud-fullscreen

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Oh, finally... I always wanted to do that.

However, I'm a little concerned about the IsTopWindowFullscreenOnMonitorWithMouse removal, because it might cause a regression for lp:741869.

By the way, this won't affect virtualbox, or vmware because they're using grabs (and part of the fix for the bug above, was considering them), but not fully sure about citrix (it should do the same, though but last version crashes to me).

Also it works perfectly even in multi-monitor, but I've not tested games.

So, I'm going to approve this, but we need to test it further in vivid before backporting to trusty.

review: Approve

« Back to merge proposal