Fair enough.
On Mon, Mar 31, 2014 at 6:24 PM, <email address hidden> wrote: > On 2014/03/31 06:44:02, dfc wrote: >> >> https://codereview.appspot.com/82520043/diff/1/agent/agent_test.go >> File agent/agent_test.go (right): > > > > https://codereview.appspot.com/82520043/diff/1/agent/agent_test.go#newcode465 >> >> agent/agent_test.go:465: c.Assert(addrs, gc.DeepEquals, > > []string{"0.1.2.3:123", >> >> "0.1.2.5:125"}) >> Does conf.APIAddresses return a set or an ordered list ? > > > APIAddresses returns the same order as specified in the list in the > config file. > I'm told order is important for addresses, which is why I've done it > with DeepEquals. > > https://codereview.appspot.com/82520043/
« Back to merge proposal
Fair enough.
On Mon, Mar 31, 2014 at 6:24 PM, <email address hidden> wrote: /codereview. appspot. com/82520043/ diff/1/ agent/agent_ test.go /codereview. appspot. com/82520043/ diff/1/ agent/agent_ test.go# newcode465 test.go: 465: c.Assert(addrs, gc.DeepEquals, "0.1.2. 3:123", /codereview. appspot. com/82520043/
> On 2014/03/31 06:44:02, dfc wrote:
>>
>> https:/
>> File agent/agent_test.go (right):
>
>
>
> https:/
>>
>> agent/agent_
>
> []string{
>>
>> "0.1.2.5:125"})
>> Does conf.APIAddresses return a set or an ordered list ?
>
>
> APIAddresses returns the same order as specified in the list in the
> config file.
> I'm told order is important for addresses, which is why I've done it
> with DeepEquals.
>
> https:/