Merge lp:~axwalk/juju-core/agent-setapihostports into lp:~go-bot/juju-core/trunk
Proposed by
Andrew Wilkins
Status: | Merged |
---|---|
Approved by: | Andrew Wilkins |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2518 |
Proposed branch: | lp:~axwalk/juju-core/agent-setapihostports |
Merge into: | lp:~go-bot/juju-core/trunk |
Diff against target: |
91 lines (+52/-0) 2 files modified
agent/agent.go (+18/-0) agent/agent_test.go (+34/-0) |
To merge this branch: | bzr merge lp:~axwalk/juju-core/agent-setapihostports |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Juju Engineering | Pending | ||
Review via email: mp+213409@code.launchpad.net |
Commit message
agent: add ConfigSetterOnl
We still only store addresses in the config,
so we lose some metadata. We make use of the
scope metadata before storing, though, to
prune the addresses to the internal ones.
Description of the change
agent: add ConfigSetterOnl
We still only store addresses in the config,
so we lose some metadata. We make use of the
scope metadata before storing, though, to
prune the addresses to the internal ones.
To post a comment you must log in.
+ conf.SetAPIHost Ports([ ][]instance. HostPort{ AddressesWithPo rt(server1, 123), AddressesWithPo rt(server2, 124), AddressesWithPo rt(server3, 125), "0.1.2. 3:123", "0.1.2.5:125"})
+ instance.
+ instance.
+ instance.
+ })
+ addrs, err = conf.APIAddresses()
+ c.Assert(err, gc.IsNil)
+ c.Assert(addrs, gc.DeepEquals, []string{
Does conf.APIAddresses return a set or an ordered list ?