Code review comment for lp:~axwalk/goose/nova-availability-zones

Revision history for this message
Dave Cheney (dave-cheney) wrote :

https://codereview.appspot.com/103900045/diff/1/nova/local_test.go
File nova/local_test.go (right):

https://codereview.appspot.com/103900045/diff/1/nova/local_test.go#newcode251
nova/local_test.go:251: c.Assert(err, IsNil)
Are these zones guaranteed to be returned in order? Should this be
jc.SameContents

https://codereview.appspot.com/103900045/diff/1/testservices/novaservice/service.go
File testservices/novaservice/service.go (right):

https://codereview.appspot.com/103900045/diff/1/testservices/novaservice/service.go#newcode826
testservices/novaservice/service.go:826: sort.Sort(azByName(zones))
Please document the order of az's is stored.

https://codereview.appspot.com/103900045/diff/1/testservices/novaservice/service_http_test.go
File testservices/novaservice/service_http_test.go (right):

https://codereview.appspot.com/103900045/diff/1/testservices/novaservice/service_http_test.go#newcode1196
testservices/novaservice/service_http_test.go:1196:
c.Assert(expected.Zones, DeepEquals, zones)
jc.SameContents

https://codereview.appspot.com/103900045/

« Back to merge proposal