lp:~axwalk/goose/nova-availability-zones

Created by Andrew Wilkins on 2014-06-06 and last modified on 2014-06-09
Get this branch:
bzr branch lp:~axwalk/goose/nova-availability-zones
Only Andrew Wilkins can upload to this branch. If you are Andrew Wilkins please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Andrew Wilkins
Project:
Go OpenStack Exchange
Status:
Merged

Recent revisions

127. By Andrew Wilkins on 2014-06-09

Address review comments

- Return an error if AZ extension is not supported
- Use new testservices/errors

126. By Andrew Wilkins on 2014-06-06

Add comment on ordering of zones

125. By Andrew Wilkins on 2014-06-06

Add Availability Zone support

- ListAvailabilityZones
- AvailabilityZone parameter in RunServer
- AvailabilityZone field in ServerDetail

124. By Dave Cheney on 2014-05-16

[r=dave-cheney] goose: fix vet errors

* fix several printf errors
* address unreachable code warnings. Rewrote branches to avoid unreachable code while being compatible with Go 1.0

123. By Kevin McDermott on 2014-05-13

[r=jameinel],[bug=1314366] This is a fix for this, basically, this code...

http/client.go

 func (c *Client) sendRequest(method, URL string, reqReader io.Reader, length int, headers http.Header, expectedStatus []int, logger *log.Logger) (*http.Response, error) {

originally, only returned the body of the response, which meant there was no scope for getting the headers.

Coupled with this code from swift/swift.go

-func (c *Client) HeadObject(containerName, objectName string) (headers http.Header, err error)

the fact that it's creating headers here, masks the fact that they're not originating in the request.

I implemented HEAD in the fake server, mainly because it's the quickest way to test the fix, we don't necessarily need HEAD, but we wanted to proxy the headers returned by the Swift request to downstream clients (specifically ETag / cache-control headers).

122. By Horacio Durán on 2014-05-02

[r=hduran-8] Added json encoded for ServerErrors

added jsonEncode function to novaservice that
tries to convert the given error into a
ServerError and call its AsJSON method or
wrap the given error into a 500 ServerError
which will contain the original error message.

https://codereview.appspot.com/97870044/

R=gz

121. By Horacio Durán on 2014-05-01

[r=gz] Added proper errortype in testservices.

Added an error type for testservers that
contains a message and an error code.
Switched novaservice to use new error type.

https://codereview.appspot.com/99960043/

R=axwalk

120. By Martin Packman on 2014-05-01

[r=gz] tools/secgroup-delete-all: Change test package

Change tests to be in package main rather than main_test,
which may work around an odd issue on the landing bot.

https://codereview.appspot.com/91010044/

R=axwalk, hduran-8

119. By Andrew Wilkins on 2014-04-23

[r=axwalk] http: close response body if unused

BinaryRequest calls may discard the response
without closing it. This was causing sockets
to be left open in juju-core/provider/openstack
tests, leading to test failures.

https://codereview.appspot.com/90540043/

118. By John A Meinel on 2014-03-07

[r=jameinel],[bug=1226996] panic if we get bad requests

It turns out that if you don't supply CIDR or GroupId Openstack just
sets CIDR to 0.0.0.0/0. We don't want to rely on that behavior, so
this just changes the goose test double to panic if it got that
situation.

This can't land until we land my updated Juju branch (or the test
suite will appropriately fail with panic().)

https://codereview.appspot.com/13781043/

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:goose
This branch contains Public information 
Everyone can see this information.

Subscribers