Merge ~athos-ribeiro/ubuntu/+source/nut:skip-flaky-tests into ubuntu/+source/nut:ubuntu/devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | git-ubuntu bot | ||||
Approved revision: | not available | ||||
Merged at revision: | 5b71cd401c4afd81606862ed60479235e2edce46 | ||||
Proposed branch: | ~athos-ribeiro/ubuntu/+source/nut:skip-flaky-tests | ||||
Merge into: | ubuntu/+source/nut:ubuntu/devel | ||||
Diff against target: |
48 lines (+10/-1) 3 files modified
debian/changelog (+6/-0) debian/control (+2/-1) debian/tests/test-nut.py (+2/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
git-ubuntu bot | Approve | ||
Bryce Harrington (community) | Approve | ||
Canonical Server Reporter | Pending | ||
Review via email: mp+435205@code.launchpad.net |
Description of the change
This is a temporary fix for LP: #1998481. The mentioned bug points to an upstream bug where sd_notify support is being implemented. When that is complete, we can apply the patch attached to that bug to the nut package. Until then, Let's skip these flaky tests to avoid blocking other package migrations.
PPA: https:/
Local test run result summary:
autopkgtest [11:22:15]: test nut: [------
test_CVE_2012_2944 (__main_
Test CVE-2012-2944 ... ok
test_daemons_pid (__main_
Test daemons using PID files ... ok
test_daemons_
Test daemons using "service status" ... ok
test_upsc_
Test NUT client interface (upsc): device(s) listing ... ok
test_upsd_IPv4 (__main_
Test upsd IPv4 reachability ... ok
test_upsd_IPv6 (__main_
Test upsd IPv6 reachability ... ok
test_upsmon_notif (__main_
Test upsmon notifications ... skipped 'Skip flaky test. See LP: #1998481 for further reference.'
test_upsrw (__main_
Test upsrw ... skipped 'Skip flaky test. See LP: #1998481 for further reference.'
-------
Ran 8 tests in 118.815s
OK (skipped=2)
Skipping private tests
autopkgtest [11:24:15]: test nut: -------
autopkgtest [11:24:15]: test nut: - - - - - - - - - - results - - - - - - - - - -
nut PASS
autopkgtest [11:24:16]: @@@@@@@
nut PASS
LGTM, thanks for including the LP#'s for the skips.
I triggered autopkgtests against the PPA:
$ ppa tests ppa:athos- ribeiro/ nut-flaky- tests 0-6ubuntu1~ ppa1: Published
* Triggers:
- Source nut/2.8.
+ Trigger basic @amd64♻️ Trigger all-proposed @amd64💍
+ Trigger basic @arm64♻️ Trigger all-proposed @arm64💍
+ Trigger basic @armhf♻️ Trigger all-proposed @armhf💍
+ Trigger basic @i386♻️ Trigger all-proposed @i386💍
+ Trigger basic @ppc64el♻️ Trigger all-proposed @ppc64el💍
+ Trigger basic @s390x♻️ Trigger all-proposed @s390x💍
* Results: nut-flaky- tests nut/2.8. 0-6ubuntu1~ ppa1 nut-flaky- tests nut/2.8. 0-6ubuntu1~ ppa1 nut-flaky- tests nut/2.8. 0-6ubuntu1~ ppa1 nut-flaky- tests nut/2.8. 0-6ubuntu1~ ppa1 nut-flaky- tests nut/2.8. 0-6ubuntu1~ ppa1
* Running:
# time pkg release arch ppa trigger
- 20 nut lunar ppc64el athos-ribeiro/
- 20 nut lunar armhf athos-ribeiro/
- 20 nut lunar arm64 athos-ribeiro/
* Waiting:
# Q-num pkg release arch ppa trigger
- 1 nut lunar s390x athos-ribeiro/
- 1 nut lunar amd64 athos-ribeiro/