Merge ~arturo-seijas/postgresql-charm:jammy-support-2 into postgresql-charm:master

Proposed by Arturo Enrique Seijas Fernández
Status: Merged
Approved by: Tom Haddon
Approved revision: 88f744e20ab24243f89545dc73bb43b17b303aea
Merged at revision: 6772fdb308d0a83ba57b035dc2baa75a7321c977
Proposed branch: ~arturo-seijas/postgresql-charm:jammy-support-2
Merge into: postgresql-charm:master
Diff against target: 25 lines (+4/-4)
1 file modified
reactive/postgresql/postgresql.py (+4/-4)
Reviewer Review Type Date Requested Status
Canonical IS Reviewers Pending
PostgreSQL Charm Maintainers Pending
Review via email: mp+437998@code.launchpad.net
To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 6772fdb308d0a83ba57b035dc2baa75a7321c977

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/reactive/postgresql/postgresql.py b/reactive/postgresql/postgresql.py
index 518eda3..3101c7e 100644
--- a/reactive/postgresql/postgresql.py
+++ b/reactive/postgresql/postgresql.py
@@ -124,16 +124,16 @@ def point_version():
124 return output.split()[-1]124 return output.split()[-1]
125125
126126
127def has_version(version):127def has_version(ver):
128 """128 """
129 PostgreSQL version greater or equal then the one provided129 PostgreSQL version greater or equal then the one provided.
130 130
131 Args:131 Args:
132 version: Version number to compare against132 ver: Version number to compare against
133 Returns:133 Returns:
134 true if the version is greater or equal than the one provided134 true if the version is greater or equal than the one provided
135 """135 """
136 return LooseVersion(version()) >= LooseVersion(version)136 return LooseVersion(version()) >= LooseVersion(ver)
137137
138138
139class InvalidConnection(Exception):139class InvalidConnection(Exception):

Subscribers

People subscribed via source and target branches