Merge ~artivis/lpci:feature/yaml-alias into lpci:main
Proposed by
jeremie
Status: | Needs review |
---|---|
Proposed branch: | ~artivis/lpci:feature/yaml-alias |
Merge into: | lpci:main |
Diff against target: |
105 lines (+85/-1) 2 files modified
lpcraft/config.py (+1/-1) lpcraft/tests/test_config.py (+84/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Launchpad code reviewers | Pending | ||
Review via email: mp+435370@code.launchpad.net |
Description of the change
Changes pydantic configuration for extra fields from 'forbid' to 'ignore'. This allows defining extra fields which can be used to e.g. define yaml anchors. Aliases are resolved to anchors by pyyaml before being ignored (filtered out) by pydantic.
To post a comment you must log in.
Unmerged commits
- 9e4b6f6... by jeremie
-
test:0 (build) build:0 (build) 1 → 2 of 2 results First • Previous • Next • Last - e31b622... by jeremie
I'm concerned about this approach, because it would mean that people's configuration files might break when we add new official fields.
Is there some way that we could at least confine field names used for anchors to some kind of namespace?