Code review comment for ~artivis/lpci:feature/yaml-alias

Revision history for this message
jeremie (artivis) wrote :

> Is there some way that we could at least confine field names used for anchors
> to some kind of namespace?

Thanks for the prompt review.
Another option would be to implement a pydantic root_validator that simply filters out entries at the root level based on a prefix - see here (https://git.launchpad.net/~artivis/lpcraft/tree/lpcraft/config.py?h=feature/yaml-alias-filter#n269). Note that the prefix I used is a simple dot but it could be more elaborated. For instance Docker Compose as a similar mechanism called extension fields using the prefix 'x-' (https://docs.docker.com/compose/compose-file/compose-file-v3/#extension-fields).

« Back to merge proposal