Merge lp:~ari-tczew/ubuntu/lucid/gnome-settings-daemon/lp-626379 into lp:ubuntu/lucid-proposed/gnome-settings-daemon

Proposed by Artur Rona
Status: Merged
Merge reported by: Martin Pitt
Merged at revision: not available
Proposed branch: lp:~ari-tczew/ubuntu/lucid/gnome-settings-daemon/lp-626379
Merge into: lp:ubuntu/lucid-proposed/gnome-settings-daemon
Diff against target: 54 lines (+33/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/92_return_if_nitems_is_0.patch (+24/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~ari-tczew/ubuntu/lucid/gnome-settings-daemon/lp-626379
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+41410@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

This was uploaded to lucid-proposed, but without using bzr branch merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-04-28 10:46:53 +0000
+++ debian/changelog 2010-11-21 13:47:55 +0000
@@ -1,3 +1,11 @@
1gnome-settings-daemon (2.30.1-0ubuntu1.1) lucid-proposed; urgency=low
2
3 [ Krzysztof Klimonda ]
4 * debian/patches/92_return_if_nitems_is_0.patch: (LP: #626379)
5 - Fix handle clipboard with KDE apps on Gnome, e.g. kolourpaint4.
6
7 -- Artur Rona <ari-tczew@ubuntu.com> Sun, 21 Nov 2010 14:21:45 +0100
8
1gnome-settings-daemon (2.30.1-0ubuntu1) lucid-proposed; urgency=low9gnome-settings-daemon (2.30.1-0ubuntu1) lucid-proposed; urgency=low
210
3 * New upstream version (LP: #571250):11 * New upstream version (LP: #571250):
412
=== added file 'debian/patches/92_return_if_nitems_is_0.patch'
--- debian/patches/92_return_if_nitems_is_0.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/92_return_if_nitems_is_0.patch 2010-11-21 13:47:55 +0000
@@ -0,0 +1,24 @@
1From: Artur Rona <ari-tczew@ubuntu.com>
2Description: Fix handle clipboard with KDE apps on Gnome, e.g. kolourpaint4.
3Bug: https://bugzilla.gnome.org/628526
4Bug-Ubuntu: https://launchpad.net/bugs/626379
5Forwarded: yes
6Author: Krzysztof Klimonda <kklimonda@ubuntu.com>
7
8Index: gnome-settings-daemon/plugins/clipboard/gsd-clipboard-manager.c
9===================================================================
10--- gnome-settings-daemon.orig/plugins/clipboard/gsd-clipboard-manager.c 2010-09-14 17:26:18.077966003 +0200
11+++ gnome-settings-daemon/plugins/clipboard/gsd-clipboard-manager.c 2010-09-14 17:35:07.117966003 +0200
12@@ -599,8 +599,11 @@
13 &type, &format, &nitems, &remaining,
14 (unsigned char **) &multiple);
15
16- if (type != XA_ATOM_PAIR)
17+ if (type != XA_ATOM_PAIR || nitems == 0) {
18+ if (multiple)
19+ free (multiple);
20 return;
21+ }
22
23 for (i = 0; i < nitems; i += 2) {
24 rdata = (IncrConversion *) malloc (sizeof (IncrConversion));
025
=== modified file 'debian/patches/series'
--- debian/patches/series 2010-04-28 10:46:53 +0000
+++ debian/patches/series 2010-11-21 13:47:55 +0000
@@ -15,4 +15,5 @@
1590_autoreconf.patch1590_autoreconf.patch
1691_bugzilla_update_touchpad_icons.patch1691_bugzilla_update_touchpad_icons.patch
1791_update_gvc_source.patch1791_update_gvc_source.patch
1892_return_if_nitems_is_0.patch
1899_ltmain_as-needed.patch1999_ltmain_as-needed.patch

Subscribers

People subscribed via source and target branches

to all changes: