Merge lp:~arashbm/cliffhanger/searchbox into lp:~flashback-dev/cliffhanger/trunk
Proposed by
Arash Badie Modiri
Status: | Merged |
---|---|
Merged at revision: | 7 |
Proposed branch: | lp:~arashbm/cliffhanger/searchbox |
Merge into: | lp:~flashback-dev/cliffhanger/trunk |
Diff against target: |
222 lines (+174/-15) 3 files modified
components/SearchBox.qml (+20/-14) components/SearchPage.qml (+1/-1) graphics/search_icon@8.svg (+153/-0) |
To merge this branch: | bzr merge lp:~arashbm/cliffhanger/searchbox |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nekhelesh Ramananthan | Approve | ||
Review via email: mp+195211@code.launchpad.net |
Description of the change
Removing search button from SearchBox component. Works with a timer like ubuntu-clock-app's SearchBox component.
To post a comment you must log in.
Thanks for your contribution. This is a nice improvement. There are just some small things that need fixing.
1. The image search_icon.svg is not present in your branch. Hence when I run it, it complains that image is missing.
2. Can you replace the line 34 + width: parent.width with anchors { right: parent.right } since we are already using achors for the left and top position.