Code review comment for lp:~arashbm/cliffhanger/searchbox

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Thanks for your contribution. This is a nice improvement. There are just some small things that need fixing.

1. The image search_icon.svg is not present in your branch. Hence when I run it, it complains that image is missing.

2. Can you replace the line 34 + width: parent.width with anchors { right: parent.right } since we are already using achors for the left and top position.

review: Needs Fixing

« Back to merge proposal