Merge lp:~apachelogger/packagekit/kubuntu-upgrade-support into lp:~packagekit/packagekit/ubuntu-lucid

Proposed by Anthony Mercatante
Status: Merged
Merged at revision: not available
Proposed branch: lp:~apachelogger/packagekit/kubuntu-upgrade-support
Merge into: lp:~packagekit/packagekit/ubuntu-lucid
Diff against target: 185 lines (+108/-7)
6 files modified
debian/README.source (+6/-0)
debian/changelog (+26/-0)
debian/control (+10/-7)
debian/patches/add_kubuntu_upgrade_support.patch (+51/-0)
debian/patches/fix_progress_crash.patch (+13/-0)
debian/patches/series (+2/-0)
To merge this branch: bzr merge lp:~apachelogger/packagekit/kubuntu-upgrade-support
Reviewer Review Type Date Requested Status
Roderick B. Greening Pending
Anthony Mercatante Pending
Jonathan Riddell Pending
Review via email: mp+19814@code.launchpad.net

This proposal supersedes a proposal from 2010-02-21.

To post a comment you must log in.
Revision history for this message
Anthony Mercatante (tonio) wrote : Posted in a previous version of this proposal

Tested the patch, seems fine with me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'debian/README.source'
--- debian/README.source 1970-01-01 00:00:00 +0000
+++ debian/README.source 2010-02-21 13:53:14 +0000
@@ -0,0 +1,6 @@
1This package uses quilt for upstream source code patch management. Please read
2/usr/share/doc/quilt/README.source for more information how to apply, unapply,
3add, modify or remove patches.
4
5Please note that /usr/share/doc/quilt/README.source is only available in quilt
6version 0.46-4.1 or later.
07
=== modified file 'debian/changelog'
--- debian/changelog 2010-01-27 20:26:51 +0000
+++ debian/changelog 2010-02-21 13:53:14 +0000
@@ -1,3 +1,29 @@
1packagekit (0.5.6-0ubuntu3) lucid; urgency=low
2
3 * Update VCS entries in debian/control for lucid
4 * Add add_kubuntu_upgrade_support.patch to enable distro upgrades on
5 Kubuntu (also sent upstream via dantii)
6
7 -- Harald Sitter <apachelogger@ubuntu.com> Sun, 21 Feb 2010 11:11:07 +0100
8
9packagekit (0.5.6-0ubuntu2) lucid; urgency=low
10
11 * Re-add fix_progress_crash.patch. Never was upstreamed and apparently
12 was dropped in 0.5.x (LP: #438279)
13
14 -- Jonathan Thomas <echidnaman@kubuntu.org> Mon, 15 Feb 2010 21:34:00 -0500
15
16packagekit (0.5.6-0ubuntu1) lucid; urgency=low
17
18 * Add build-depend on policykit-1 to prevent FTBFS
19 * Add build-depend on libxt-dev to prevent FTBFS
20 * Add build-depend on pm-utils for pm-utils support, prevents FTBFS
21 * Fix obsolete-relation-form-in-source warnings throughout the package
22 * Bump Standards-Version to 3.8.3:
23 - Add README.source for quilt patch system info
24
25 -- Jonathan Thomas <echidnaman@kubuntu.org> Wed, 27 Jan 2010 20:48:54 -0500
26
1packagekit (0.5.6) lucid; urgency=low27packagekit (0.5.6) lucid; urgency=low
228
3 * New upstream snapshot of the 0.5 series with the following highlights:29 * New upstream snapshot of the 0.5 series with the following highlights:
430
=== modified file 'debian/control'
--- debian/control 2009-11-06 06:42:03 +0000
+++ debian/control 2010-02-21 13:53:14 +0000
@@ -13,6 +13,7 @@
13 network-manager-dev,13 network-manager-dev,
14 libpolkit-gobject-1-dev,14 libpolkit-gobject-1-dev,
15 libpolkit-backend-1-dev,15 libpolkit-backend-1-dev,
16 policykit-1,
16 libapt-pkg-dev,17 libapt-pkg-dev,
17 autotools-dev,18 autotools-dev,
18 libtool,19 libtool,
@@ -31,12 +32,14 @@
31 libgstreamer-plugins-base0.10-dev,32 libgstreamer-plugins-base0.10-dev,
32 libarchive-dev,33 libarchive-dev,
33 libcppunit-dev,34 libcppunit-dev,
34 libqt4-dev35 libqt4-dev,
35Standards-Version: 3.8.136 libxt-dev,
37 pm-utils
38Standards-Version: 3.8.3
36XS-Python-Version: current39XS-Python-Version: current
37Homepage: http://www.packagekit.org40Homepage: http://www.packagekit.org
38Vcs-Bzr: https://code.launchpad.net/~packagekit/packagekit/packagekit-karmic41Vcs-Bzr: https://code.launchpad.net/~packagekit/packagekit/ubuntu-lucid
39Vcs-Browser: http://bazaar.launchpad.net/~packagekit/packagekit/packagekit-karmic/files42Vcs-Browser: http://bazaar.launchpad.net/~packagekit/packagekit/ubuntu-lucid/files
4043
41Package: packagekit44Package: packagekit
42Architecture: any45Architecture: any
@@ -69,7 +72,7 @@
69 python-gobject,72 python-gobject,
70 python-dbus73 python-dbus
71XB-Python-Version: ${python:Versions}74XB-Python-Version: ${python:Versions}
72Conflicts: packagekit (< 0.3.11)75Conflicts: packagekit (<< 0.3.11)
73Description: PackageKit Python bindings76Description: PackageKit Python bindings
74 PackageKit allows to perform simple software management tasks over a DBus 77 PackageKit allows to perform simple software management tasks over a DBus
75 interface e.g refreshing the cache, updating, installing and removing 78 interface e.g refreshing the cache, updating, installing and removing
@@ -80,7 +83,7 @@
80Package: gstreamer0.10-packagekit83Package: gstreamer0.10-packagekit
81Architecture: any84Architecture: any
82Section: libs85Section: libs
83Conflicts: gnome-app-install (< 0.5.12)86Conflicts: gnome-app-install (<< 0.5.12)
84Depends: ${shlibs:Depends}, 87Depends: ${shlibs:Depends},
85 ${misc:Depends},88 ${misc:Depends},
86 packagekit (= ${binary:Version})89 packagekit (= ${binary:Version})
@@ -210,7 +213,7 @@
210 update-manager-core, 213 update-manager-core,
211 python-software-properties214 python-software-properties
212XB-Python-Version: ${python:Versions}215XB-Python-Version: ${python:Versions}
213Conflicts: packagekit (<0.3)216Conflicts: packagekit (<< 0.3)
214Recommends: apt-xapian-index217Recommends: apt-xapian-index
215Description: APT backend for packagekit218Description: APT backend for packagekit
216 PackageKit allows to perform simple software management tasks over a DBus 219 PackageKit allows to perform simple software management tasks over a DBus
217220
=== added file 'debian/patches/add_kubuntu_upgrade_support.patch'
--- debian/patches/add_kubuntu_upgrade_support.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/add_kubuntu_upgrade_support.patch 2010-02-21 13:53:14 +0000
@@ -0,0 +1,51 @@
1From 324a8e4cc857e8df5376613f7fa54bbb2ac86ad2 Mon Sep 17 00:00:00 2001
2From: Harald Sitter <sitter.harald@gmail.com>
3Date: Wed, 9 Dec 2009 09:59:23 +0100
4Subject: [PATCH] Add Kubuntu and KDialog support to pkg-upgrade-distro
5
6* Add Kubuntu support for upgrade (using env var exported by KPackageKit)
7* Add KDialog support as alternative to zenity and xmessage for the "system not recognized" message (also using env var exported by KPackageKit)
8---
9 data/pk-upgrade-distro.sh | 17 ++++++++++++-----
10 1 files changed, 12 insertions(+), 5 deletions(-)
11
12diff --git a/data/pk-upgrade-distro.sh b/data/pk-upgrade-distro.sh
13index b173c43..7236e97 100755
14--- a/data/pk-upgrade-distro.sh
15+++ b/data/pk-upgrade-distro.sh
16@@ -25,7 +25,13 @@ if [ -e /etc/fedora-release ]; then
17 fi
18 elif [ "$DISTRO" = "Ubuntu" ]; then
19 if [ -e /usr/bin/do-release-upgrade ]; then
20- gksu "/usr/bin/do-release-upgrade -m desktop -f gtk -p"
21+ if [ "$DESKTOP" = "kde" ]; then
22+ PATH=`kde4-config --path exe` kdesu -- "/usr/bin/do-release-upgrade -d -m desktop -f kde -p"
23+ else
24+ gksu "/usr/bin/do-release-upgrade -m desktop -f gtk -p"
25+ fi
26+ elif [ "$DESKTOP" = "kde" ]; then
27+ xdg-open http://www.kubuntu.org/getkubuntu
28 else
29 xdg-open http://www.ubuntu.com/getubuntu
30 fi
31@@ -34,12 +40,13 @@ elif [ -e /etc/SuSE-release ] && [ -x /usr/sbin/wagon ]; then
32 else
33 TITLE="System is not recognised"
34 TEXT="Your distribution was not recognised by the upgrade script.\nPlease file a but in your distribution bug tracker under the component PackageKit."
35+ if [ "$DESKTOP" = "kde" ]; then
36+ PATH=`kde4-config --path exe` kdialog --title "$TITLE" --sorry "$TEXT"
37 # do not dep on zenity in build scripts
38- which zenity 2> /dev/null > /dev/null
39- if [ "$?" -eq 0 ]; then
40- zenity --warning --title $TITLE --text $TEXT
41+ elif [ "`which zenity 2> /dev/null > /dev/null; echo $?`" -eq 0 ]; then
42+ zenity --warning --title $TITLE --text $TEXT
43 else
44- xmessage $TEXT
45+ xmessage $TEXT
46 fi
47 fi
48
49--
501.6.3.3
51
052
=== added file 'debian/patches/fix_progress_crash.patch'
--- debian/patches/fix_progress_crash.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/fix_progress_crash.patch 2010-02-21 13:53:14 +0000
@@ -0,0 +1,13 @@
1Index: packagekit-0.5.6/backends/apt/aptBackend.py
2===================================================================
3--- packagekit-0.5.6.orig/backends/apt/aptBackend.py 2010-02-15 21:32:59.205764881 -0500
4+++ packagekit-0.5.6/backends/apt/aptBackend.py 2010-02-15 21:33:37.217762425 -0500
5@@ -408,6 +408,8 @@
6 if self.pprev < progress:
7 self._backend.percentage(int(progress))
8 self.pprev = progress
9+ if not self._backend._cache.has_key(pkg_name):
10+ return
11 # Emit a Package signal for the currently processed package
12 if pkg_name != self.last_pkg and self._backend._cache.has_key(pkg_name):
13 pkg = self._backend._cache[pkg_name]
014
=== modified file 'debian/patches/series'
--- debian/patches/series 2009-11-06 06:50:56 +0000
+++ debian/patches/series 2010-02-21 13:53:14 +0000
@@ -1,2 +1,4 @@
1vendor.patch1vendor.patch
2defaults.patch2defaults.patch
3fix_progress_crash.patch
4add_kubuntu_upgrade_support.patch

Subscribers

People subscribed via source and target branches