Merge lp:~apachelogger/packagekit/kubuntu-upgrade-support into lp:~packagekit/packagekit/ubuntu-lucid

Proposed by Harald Sitter
Status: Merged
Approved by: Anthony Mercatante
Approved revision: not available
Merge reported by: Harald Sitter
Merged at revision: not available
Proposed branch: lp:~apachelogger/packagekit/kubuntu-upgrade-support
Merge into: lp:~packagekit/packagekit/ubuntu-lucid
Diff against target: 185 lines (+108/-7)
6 files modified
debian/README.source (+6/-0)
debian/changelog (+26/-0)
debian/control (+10/-7)
debian/patches/add_kubuntu_upgrade_support.patch (+51/-0)
debian/patches/fix_progress_crash.patch (+13/-0)
debian/patches/series (+2/-0)
To merge this branch: bzr merge lp:~apachelogger/packagekit/kubuntu-upgrade-support
Reviewer Review Type Date Requested Status
Anthony Mercatante Approve
Roderick B. Greening Pending
Jonathan Riddell Pending
Review via email: mp+19807@code.launchpad.net

This proposal has been superseded by a proposal from 2010-02-21.

To post a comment you must log in.
Revision history for this message
Anthony Mercatante (tonio) wrote :

Tested the patch, seems fine with me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/README.source'
2--- debian/README.source 1970-01-01 00:00:00 +0000
3+++ debian/README.source 2010-02-21 10:17:12 +0000
4@@ -0,0 +1,6 @@
5+This package uses quilt for upstream source code patch management. Please read
6+/usr/share/doc/quilt/README.source for more information how to apply, unapply,
7+add, modify or remove patches.
8+
9+Please note that /usr/share/doc/quilt/README.source is only available in quilt
10+version 0.46-4.1 or later.
11
12=== modified file 'debian/changelog'
13--- debian/changelog 2010-01-27 20:26:51 +0000
14+++ debian/changelog 2010-02-21 10:17:12 +0000
15@@ -1,3 +1,29 @@
16+packagekit (0.5.6-0ubuntu3) lucid; urgency=low
17+
18+ * Update VCS entries in debian/control for lucid
19+ * Add add_kubuntu_upgrade_support.patch to enable distro upgrades on
20+ Kubuntu (also sent upstream via dantii)
21+
22+ -- Harald Sitter <apachelogger@ubuntu.com> Sun, 21 Feb 2010 11:11:07 +0100
23+
24+packagekit (0.5.6-0ubuntu2) lucid; urgency=low
25+
26+ * Re-add fix_progress_crash.patch. Never was upstreamed and apparently
27+ was dropped in 0.5.x (LP: #438279)
28+
29+ -- Jonathan Thomas <echidnaman@kubuntu.org> Mon, 15 Feb 2010 21:34:00 -0500
30+
31+packagekit (0.5.6-0ubuntu1) lucid; urgency=low
32+
33+ * Add build-depend on policykit-1 to prevent FTBFS
34+ * Add build-depend on libxt-dev to prevent FTBFS
35+ * Add build-depend on pm-utils for pm-utils support, prevents FTBFS
36+ * Fix obsolete-relation-form-in-source warnings throughout the package
37+ * Bump Standards-Version to 3.8.3:
38+ - Add README.source for quilt patch system info
39+
40+ -- Jonathan Thomas <echidnaman@kubuntu.org> Wed, 27 Jan 2010 20:48:54 -0500
41+
42 packagekit (0.5.6) lucid; urgency=low
43
44 * New upstream snapshot of the 0.5 series with the following highlights:
45
46=== modified file 'debian/control'
47--- debian/control 2009-11-06 06:42:03 +0000
48+++ debian/control 2010-02-21 10:17:12 +0000
49@@ -13,6 +13,7 @@
50 network-manager-dev,
51 libpolkit-gobject-1-dev,
52 libpolkit-backend-1-dev,
53+ policykit-1,
54 libapt-pkg-dev,
55 autotools-dev,
56 libtool,
57@@ -31,12 +32,14 @@
58 libgstreamer-plugins-base0.10-dev,
59 libarchive-dev,
60 libcppunit-dev,
61- libqt4-dev
62-Standards-Version: 3.8.1
63+ libqt4-dev,
64+ libxt-dev,
65+ pm-utils
66+Standards-Version: 3.8.3
67 XS-Python-Version: current
68 Homepage: http://www.packagekit.org
69-Vcs-Bzr: https://code.launchpad.net/~packagekit/packagekit/packagekit-karmic
70-Vcs-Browser: http://bazaar.launchpad.net/~packagekit/packagekit/packagekit-karmic/files
71+Vcs-Bzr: https://code.launchpad.net/~packagekit/packagekit/ubuntu-lucid
72+Vcs-Browser: http://bazaar.launchpad.net/~packagekit/packagekit/ubuntu-lucid/files
73
74 Package: packagekit
75 Architecture: any
76@@ -69,7 +72,7 @@
77 python-gobject,
78 python-dbus
79 XB-Python-Version: ${python:Versions}
80-Conflicts: packagekit (< 0.3.11)
81+Conflicts: packagekit (<< 0.3.11)
82 Description: PackageKit Python bindings
83 PackageKit allows to perform simple software management tasks over a DBus
84 interface e.g refreshing the cache, updating, installing and removing
85@@ -80,7 +83,7 @@
86 Package: gstreamer0.10-packagekit
87 Architecture: any
88 Section: libs
89-Conflicts: gnome-app-install (< 0.5.12)
90+Conflicts: gnome-app-install (<< 0.5.12)
91 Depends: ${shlibs:Depends},
92 ${misc:Depends},
93 packagekit (= ${binary:Version})
94@@ -210,7 +213,7 @@
95 update-manager-core,
96 python-software-properties
97 XB-Python-Version: ${python:Versions}
98-Conflicts: packagekit (<0.3)
99+Conflicts: packagekit (<< 0.3)
100 Recommends: apt-xapian-index
101 Description: APT backend for packagekit
102 PackageKit allows to perform simple software management tasks over a DBus
103
104=== added file 'debian/patches/add_kubuntu_upgrade_support.patch'
105--- debian/patches/add_kubuntu_upgrade_support.patch 1970-01-01 00:00:00 +0000
106+++ debian/patches/add_kubuntu_upgrade_support.patch 2010-02-21 10:17:12 +0000
107@@ -0,0 +1,51 @@
108+From 324a8e4cc857e8df5376613f7fa54bbb2ac86ad2 Mon Sep 17 00:00:00 2001
109+From: Harald Sitter <sitter.harald@gmail.com>
110+Date: Wed, 9 Dec 2009 09:59:23 +0100
111+Subject: [PATCH] Add Kubuntu and KDialog support to pkg-upgrade-distro
112+
113+* Add Kubuntu support for upgrade (using env var exported by KPackageKit)
114+* Add KDialog support as alternative to zenity and xmessage for the "system not recognized" message (also using env var exported by KPackageKit)
115+---
116+ data/pk-upgrade-distro.sh | 17 ++++++++++++-----
117+ 1 files changed, 12 insertions(+), 5 deletions(-)
118+
119+diff --git a/data/pk-upgrade-distro.sh b/data/pk-upgrade-distro.sh
120+index b173c43..7236e97 100755
121+--- a/data/pk-upgrade-distro.sh
122++++ b/data/pk-upgrade-distro.sh
123+@@ -25,7 +25,13 @@ if [ -e /etc/fedora-release ]; then
124+ fi
125+ elif [ "$DISTRO" = "Ubuntu" ]; then
126+ if [ -e /usr/bin/do-release-upgrade ]; then
127+- gksu "/usr/bin/do-release-upgrade -m desktop -f gtk -p"
128++ if [ "$DESKTOP" = "kde" ]; then
129++ PATH=`kde4-config --path exe` kdesu -- "/usr/bin/do-release-upgrade -d -m desktop -f kde -p"
130++ else
131++ gksu "/usr/bin/do-release-upgrade -m desktop -f gtk -p"
132++ fi
133++ elif [ "$DESKTOP" = "kde" ]; then
134++ xdg-open http://www.kubuntu.org/getkubuntu
135+ else
136+ xdg-open http://www.ubuntu.com/getubuntu
137+ fi
138+@@ -34,12 +40,13 @@ elif [ -e /etc/SuSE-release ] && [ -x /usr/sbin/wagon ]; then
139+ else
140+ TITLE="System is not recognised"
141+ TEXT="Your distribution was not recognised by the upgrade script.\nPlease file a but in your distribution bug tracker under the component PackageKit."
142++ if [ "$DESKTOP" = "kde" ]; then
143++ PATH=`kde4-config --path exe` kdialog --title "$TITLE" --sorry "$TEXT"
144+ # do not dep on zenity in build scripts
145+- which zenity 2> /dev/null > /dev/null
146+- if [ "$?" -eq 0 ]; then
147+- zenity --warning --title $TITLE --text $TEXT
148++ elif [ "`which zenity 2> /dev/null > /dev/null; echo $?`" -eq 0 ]; then
149++ zenity --warning --title $TITLE --text $TEXT
150+ else
151+- xmessage $TEXT
152++ xmessage $TEXT
153+ fi
154+ fi
155+
156+--
157+1.6.3.3
158+
159
160=== added file 'debian/patches/fix_progress_crash.patch'
161--- debian/patches/fix_progress_crash.patch 1970-01-01 00:00:00 +0000
162+++ debian/patches/fix_progress_crash.patch 2010-02-21 10:17:12 +0000
163@@ -0,0 +1,13 @@
164+Index: packagekit-0.5.6/backends/apt/aptBackend.py
165+===================================================================
166+--- packagekit-0.5.6.orig/backends/apt/aptBackend.py 2010-02-15 21:32:59.205764881 -0500
167++++ packagekit-0.5.6/backends/apt/aptBackend.py 2010-02-15 21:33:37.217762425 -0500
168+@@ -408,6 +408,8 @@
169+ if self.pprev < progress:
170+ self._backend.percentage(int(progress))
171+ self.pprev = progress
172++ if not self._backend._cache.has_key(pkg_name):
173++ return
174+ # Emit a Package signal for the currently processed package
175+ if pkg_name != self.last_pkg and self._backend._cache.has_key(pkg_name):
176+ pkg = self._backend._cache[pkg_name]
177
178=== modified file 'debian/patches/series'
179--- debian/patches/series 2009-11-06 06:50:56 +0000
180+++ debian/patches/series 2010-02-21 10:17:12 +0000
181@@ -1,2 +1,4 @@
182 vendor.patch
183 defaults.patch
184+fix_progress_crash.patch
185+add_kubuntu_upgrade_support.patch

Subscribers

People subscribed via source and target branches