Merge ~andreserl/maas:lp1711203_secure_boot_workaround into maas:master

Proposed by Andres Rodriguez
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 96c5bed322af6140321903ba9388a0d8484f0056
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~andreserl/maas:lp1711203_secure_boot_workaround
Merge into: maas:master
Diff against target: 27 lines (+3/-3)
2 files modified
src/provisioningserver/boot/tests/test_uefi_amd64.py (+1/-1)
src/provisioningserver/templates/uefi/config.local.amd64.template (+2/-2)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Lee Trager (community) Approve
Review via email: mp+338584@code.launchpad.net

Commit message

LP: #1711203 - Use grub instead of shim to workaround issues with Secure Boot deployment

To post a comment you must log in.
Revision history for this message
Lee Trager (ltrager) wrote :

LGTM!

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
MAAS Lander (maas-lander) wrote :
Revision history for this message
Andres Rodriguez (andreserl) :
review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/src/provisioningserver/boot/tests/test_uefi_amd64.py b/src/provisioningserver/boot/tests/test_uefi_amd64.py
index 5351b75..0a84266 100644
--- a/src/provisioningserver/boot/tests/test_uefi_amd64.py
+++ b/src/provisioningserver/boot/tests/test_uefi_amd64.py
@@ -132,7 +132,7 @@ class TestUEFIAMD64BootMethodRender(MAASTestCase):
132 purpose="local", arch="amd64"),132 purpose="local", arch="amd64"),
133 }133 }
134 output = method.get_reader(**options).read(10000).decode("utf-8")134 output = method.get_reader(**options).read(10000).decode("utf-8")
135 self.assertIn("chainloader /efi/ubuntu/shimx64.efi", output)135 self.assertIn("chainloader /efi/ubuntu/grubx64.efi", output)
136136
137 def test_get_reader_with_enlist_purpose(self):137 def test_get_reader_with_enlist_purpose(self):
138 # If purpose is "enlist", the config.enlist.template should be138 # If purpose is "enlist", the config.enlist.template should be
diff --git a/src/provisioningserver/templates/uefi/config.local.amd64.template b/src/provisioningserver/templates/uefi/config.local.amd64.template
index 6233352..42e39eb 100644
--- a/src/provisioningserver/templates/uefi/config.local.amd64.template
+++ b/src/provisioningserver/templates/uefi/config.local.amd64.template
@@ -7,7 +7,7 @@ menuentry 'Local' {
7 search --set=root --file /efi/Microsoft/Boot/bootmgfw.efi7 search --set=root --file /efi/Microsoft/Boot/bootmgfw.efi
8 chainloader /efi/Microsoft/Boot/bootmgfw.efi8 chainloader /efi/Microsoft/Boot/bootmgfw.efi
9 {{else}}9 {{else}}
10 search --set=root --file /efi/ubuntu/shimx64.efi10 search --set=root --file /efi/ubuntu/grubx64.efi
11 chainloader /efi/ubuntu/shimx64.efi11 chainloader /efi/ubuntu/grubx64.efi
12 {{endif}}12 {{endif}}
13}13}

Subscribers

People subscribed via source and target branches