Merge ~andreserl/maas:really_workaround_lp1711760 into maas:master

Proposed by Andres Rodriguez
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 0b9e6b934db7d57988b8ef70d3964ae052f49935
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~andreserl/maas:really_workaround_lp1711760
Merge into: maas:master
Diff against target: 25 lines (+2/-2)
2 files modified
src/maasserver/api/machines.py (+1/-1)
src/metadataserver/user_data/templates/base_user_data.sh (+1/-1)
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+332330@code.launchpad.net

Commit message

LP: #1711760 - Fix incorrect comparison that caused to always use the work around.

Drive-by fix to update the API documentation.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

selfie!

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNABLE TO START LANDING

STATUS: MISSING COMMIT MESSAGE

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/src/maasserver/api/machines.py b/src/maasserver/api/machines.py
index 12358af..c382c83 100644
--- a/src/maasserver/api/machines.py
+++ b/src/maasserver/api/machines.py
@@ -560,7 +560,7 @@ class MachineHandler(NodeHandler, OwnerDataMixin, PowerMixin):
560 Some drives implement secure erasure by overwriting themselves so560 Some drives implement secure erasure by overwriting themselves so
561 this could still be slow.561 this could still be slow.
562 :type secure_erase: boolean562 :type secure_erase: boolean
563 :param quick_erase: Wipe 1MiB at the start and at the end of the drive563 :param quick_erase: Wipe 2MiB at the start and at the end of the drive
564 to make data recovery inconvenient and unlikely to happen by564 to make data recovery inconvenient and unlikely to happen by
565 accident. This is not secure.565 accident. This is not secure.
566 :type quick_erase: boolean566 :type quick_erase: boolean
diff --git a/src/metadataserver/user_data/templates/base_user_data.sh b/src/metadataserver/user_data/templates/base_user_data.sh
index 2a8e911..e9aae3e 100644
--- a/src/metadataserver/user_data/templates/base_user_data.sh
+++ b/src/metadataserver/user_data/templates/base_user_data.sh
@@ -18,7 +18,7 @@ mkdir -p "$BIN_D"
18# Work around issue where resolv.conf is not set on the ephemeral environment18# Work around issue where resolv.conf is not set on the ephemeral environment
19#19#
20# First check if a nameserver is set in resolv.conf20# First check if a nameserver is set in resolv.conf
21if ! echo /etc/resolv.conf | grep -qs "nameserver"; then21if ! grep -qs nameserver /etc/resolv.conf; then
22 # If it is not, obtain the MAC address of the PXE boot interface22 # If it is not, obtain the MAC address of the PXE boot interface
23 mac_address=$(cat /proc/cmdline | grep -o -E '([[:xdigit:]]{1,2}:){5}[[:xdigit:]]{1,2}')23 mac_address=$(cat /proc/cmdline | grep -o -E '([[:xdigit:]]{1,2}:){5}[[:xdigit:]]{1,2}')
2424

Subscribers

People subscribed via source and target branches