Code review comment for lp:~andrea-crotti-0/mailman/py_interactive

Revision history for this message
Barry Warsaw (barry) wrote :

On Apr 7, 2012, at 2:44 AM, Andrea Crotti wrote:

> Ok good..
> The only way I could find to test this thing is to
> - mock the environment making IPython available or not
> - mock IPython and the python interpreter and check that they are called as expected

mock is now a dependency (I needed it for the NNTPRunner tests), so this would be doable.

> This would probably work, but I don't really think it would really add any value, what do you think?

Well, untested code is broken code. :)

« Back to merge proposal