Merge lp:~andrea-crotti-0/mailman/py_interactive into lp:mailman

[Andrea Crotti]

There is a tiny change from the version already merged, because now sys.ps1 is set correctly even if readline/rlcompleter fail..

Not sure what's the best way to proceed but I guess that reproposing to merge after the commit should be the right way.

[Barry Warsaw (barry)]

I'll remove the extra blank line and merge this branch. Thanks!

Do you have any other thoughts on how to test this?

review: Approve

[Andrea Crotti (andrea-crotti-0)]

Ok good..
The only way I could find to test this thing is to
- mock the environment making IPython available or not
- mock IPython and the python interpreter and check that they are called as expected

This would probably work, but I don't really think it would really add any value, what do you think?

[Barry Warsaw (barry)]

On Apr 7, 2012, at 2:44 AM, Andrea Crotti wrote:

> Ok good..
> The only way I could find to test this thing is to
> - mock the environment making IPython available or not
> - mock IPython and the python interpreter and check that they are called as expected

mock is now a dependency (I needed it for the NNTPRunner tests), so this would be doable.

> This would probably work, but I don't really think it would really add any value, what do you think?

Well, untested code is broken code. :)

=== modified file 'src/mailman/commands/cli_withlist.py'
--- src/mailman/commands/cli_withlist.py	2012-03-14 04:09:33 +0000
+++ src/mailman/commands/cli_withlist.py	2012-03-15 19:57:22 +0000
@@ -172,8 +172,8 @@
             readline.parse_and_bind('tab: complete')
         except ImportError:
             pass
-        else:
-            sys.ps1 = config.shell.prompt + ' '
+
+        sys.ps1 = config.shell.prompt + ' '
         interact(upframe=False, banner=banner, overrides=overrides)
 
     def _details(self):