charm-prometheus-blackbox-exporter-peer

Code review comment for ~aluria/charm-prometheus-blackbox-exporter-peer:rewrite-move-complexity

  1. Git
  2. lp:~aluria/charm-prometheus-blackbox-exporter-peer
  3. rewrite-move-complexity
  4. Merge into master
Revision history for this message
Alvaro Uria (aluria) wrote :

Hi! I've addressed the previously suggested fixes at [1].

OTOH, the reactive script has been rewritten so it only interacts with the "blackbox-exporter" relation. It's up to prometheus2-charm to create the icmp probes.

Although this charm exposes a "icmp_jumbo" module by default, prometheus2-charm won't configure probes using this module for now.

1. https://code.launchpad.net/~aluria/prometheus-blackbox-exporter-charm/+git/prometheus-blackbox-exporter-charm/+merge/374432

« Back to merge proposal