~aluria/charm-prometheus-blackbox-exporter-peer:rewrite-move-complexity

Branch merges

Propose for merging

Superseded for merging into charm-prometheus-blackbox-exporter-peer:master

Peter Sabaini (community): Approve on 2019-10-24

Canonical IS Reviewers: Pending requested 2019-10-25

Canonical IS Reviewers: Pending requested 2019-10-24

Diff: 1183 lines (+881/-117)

25 files modified

.gitignore (+22/-0)
Makefile (+56/-0)
config.yaml (+14/-13)
dev/null (+0/-94)
icon.svg (+12/-0)
interfaces/.empty (+1/-0)
layer.yaml (+12/-3)
layers/.empty (+1/-0)
lib/lib_bb_peer_exporter.py (+148/-0)
lib/lib_network.py (+55/-0)
metadata.yaml (+17/-7)
reactive/prometheus_blackbox_exporter_peer.py (+85/-0)
tests/functional/bundle.yaml.j2 (+13/-0)
tests/functional/conftest.py (+68/-0)
tests/functional/juju_tools.py (+71/-0)
tests/functional/requirements.txt (+7/-0)
tests/functional/test_deploy.py (+131/-0)
tests/unit/conftest.py (+60/-0)
tests/unit/requirements.txt (+5/-0)
tests/unit/samples/expected.multi (+1/-0)
tests/unit/samples/expected.single (+1/-0)
tests/unit/test_lib_bb_peer_exporter.py (+12/-0)
tests/unit/test_lib_network.py (+40/-0)
tox.ini (+48/-0)
wheelhouse.txt (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

bf9bd8b... by Alvaro Uria on 2019-10-24

Improve lib_network unit test

cce865f... by Alvaro Uria on 2019-10-24

Fixes per initial review

8633d54... by Alvaro Uria on 2019-10-24

Update unit tests

ca94a30... by Alvaro Uria on 2019-10-23

Rewrite the blackbox-exporter relation

 * Each unit exposes its available networks with the blackbox-exporter
 remote units (juju config updates the relation info)
 * lib_network uses psutil everywhere instead of a mix of psutil and
 netifaces (ipaddress module is still used for validation)
 * module for "icmp_jump" added to the default config

1901aed... by Alvaro Uria on 2019-10-22

Rename p-bb-peer-exporter to p-bb-exporter-peer

371fd4b... by Alvaro Uria on 2019-10-19

Rewrite charm using template-python-pytest

 * Cloned template-python-pytest
 * Moved the reactive script helpers to lib_bb_peer_exporter (generic)
 and lib_network (network related helpers)
 * Created minimum unit (for the libs) and functional tests
 * wheelhouse.txt installs psutil as well as netifaces and pyroute2.
 * Linting now runs flake8-docstrings, flake8-import-order and other
 extra checks. All scripts have been updated following parser
 recommendations.
 * Better use of the peer-discovery interface. Available (and transient)
 states when units join or leave a peer relation are used to trigger
 config changes.

a458c6a... by Andrea Ieri on 2019-09-26

Noop readability refactor

881b419... by Andrea Ieri on 2019-09-26

Lookup source ips for all probes and provide the address over the relation

64d1422... by Andrea Ieri on 2019-09-25

Filter out uninteresting IPs and interfaces

413057f... by Andrea Ieri on 2019-09-19

Publish the external IP in case we're running cross-model relations