Code review comment for lp:~allenap/maas/zone-sort-by-name--bug-1262160

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

That easy? What a relief! Django has its good sides, eh?

Instead of hard-coding zone names in the test, I'd just create a slightly longer list and let factory.make_zone() come up with names...

    zones = [factory.make_zone() for _ in range(5)]

The longer list will make it most likely that failures to sort will be exposed.

review: Approve

« Back to merge proposal