Merge lp:~allenap/maas/zone-sort-by-name--bug-1262160 into lp:~maas-committers/maas/trunk
Proposed by
Gavin Panella
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Gavin Panella | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 1801 | ||||
Proposed branch: | lp:~allenap/maas/zone-sort-by-name--bug-1262160 | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
30 lines (+2/-7) 2 files modified
src/maasserver/models/zone.py (+1/-0) src/maasserver/tests/test_views_nodes.py (+1/-7) |
||||
To merge this branch: | bzr merge lp:~allenap/maas/zone-sort-by-name--bug-1262160 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+199460@code.launchpad.net |
Commit message
Sort nodes by zone name instead of zone ID.
To post a comment you must log in.
That easy? What a relief! Django has its good sides, eh?
Instead of hard-coding zone names in the test, I'd just create a slightly longer list and let factory.make_zone() come up with names...
zones = [factory. make_zone( ) for _ in range(5)]
The longer list will make it most likely that failures to sort will be exposed.