Merge lp:~alisonken1/openlp/strings-plugins1 into lp:openlp
- strings-plugins1
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Raoul Snyman |
Approved revision: | 2667 |
Merged at revision: | 2667 |
Proposed branch: | lp:~alisonken1/openlp/strings-plugins1 |
Merge into: | lp:openlp |
Diff against target: |
1619 lines (+309/-201) 20 files modified
openlp/plugins/alerts/alertsplugin.py (+7/-3) openlp/plugins/alerts/lib/alertsmanager.py (+1/-1) openlp/plugins/alerts/lib/alertstab.py (+2/-1) openlp/plugins/bibles/forms/bibleimportform.py (+11/-4) openlp/plugins/bibles/forms/bibleupgradeform.py (+42/-28) openlp/plugins/bibles/forms/editbibledialog.py (+6/-3) openlp/plugins/bibles/forms/editbibleform.py (+8/-7) openlp/plugins/bibles/lib/csvbible.py (+7/-5) openlp/plugins/bibles/lib/db.py (+31/-29) openlp/plugins/bibles/lib/http.py (+51/-36) openlp/plugins/bibles/lib/manager.py (+21/-15) openlp/plugins/bibles/lib/mediaitem.py (+47/-31) openlp/plugins/bibles/lib/opensong.py (+7/-7) openlp/plugins/bibles/lib/osis.py (+5/-4) openlp/plugins/bibles/lib/sword.py (+3/-3) openlp/plugins/bibles/lib/upgrade.py (+5/-5) openlp/plugins/bibles/lib/versereferencelist.py (+14/-8) openlp/plugins/bibles/lib/zefania.py (+6/-5) tests/functional/openlp_core_lib/test_projectordb.py (+32/-3) tests/functional/openlp_plugins/bibles/test_http.py (+3/-3) |
To merge this branch: | bzr merge lp:~alisonken1/openlp/strings-plugins1 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raoul Snyman | Approve | ||
Tim Bentley | Approve | ||
Review via email:
|
Commit message
Update strings to python3 format in plugins part 1
Description of the change
Update strings to python3 format in plugins part 1
- Convert strings in alert plugin
- Convert strings in bible plugin
- Update bible plugin test
- Update projectordb test
-------
lp:~alisonken1/openlp/strings-plugins1 (revision 2667)
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Raoul Snyman (raoul-snyman) : | # |
Preview Diff
1 | === modified file 'openlp/plugins/alerts/alertsplugin.py' | |||
2 | --- openlp/plugins/alerts/alertsplugin.py 2016-03-31 16:34:22 +0000 | |||
3 | +++ openlp/plugins/alerts/alertsplugin.py 2016-05-21 08:42:57 +0000 | |||
4 | @@ -88,6 +88,7 @@ | |||
5 | 88 | } | 88 | } |
6 | 89 | } | 89 | } |
7 | 90 | """ | 90 | """ |
8 | 91 | # TODO: Verify format() with variable templates | ||
9 | 91 | CSS = """ | 92 | CSS = """ |
10 | 92 | #alert { | 93 | #alert { |
11 | 93 | position: absolute; | 94 | position: absolute; |
12 | @@ -244,6 +245,9 @@ | |||
13 | 244 | :param frame: The Web frame holding the page. | 245 | :param frame: The Web frame holding the page. |
14 | 245 | """ | 246 | """ |
15 | 246 | align = VerticalType.Names[self.settings_tab.location] | 247 | align = VerticalType.Names[self.settings_tab.location] |
19 | 247 | frame.evaluateJavaScript('update_css("%s", "%s", "%s", "%s", "%s")' % | 248 | frame.evaluateJavaScript('update_css("{align}", "{face}", "{size}", "{color}", ' |
20 | 248 | (align, self.settings_tab.font_face, self.settings_tab.font_size, | 249 | '"{background}")'.format(align=align, |
21 | 249 | self.settings_tab.font_color, self.settings_tab.background_color)) | 250 | face=self.settings_tab.font_face, |
22 | 251 | size=self.settings_tab.font_size, | ||
23 | 252 | color=self.settings_tab.font_color, | ||
24 | 253 | background=self.settings_tab.background_color)) | ||
25 | 250 | 254 | ||
26 | === modified file 'openlp/plugins/alerts/lib/alertsmanager.py' | |||
27 | --- openlp/plugins/alerts/lib/alertsmanager.py 2015-12-31 22:46:06 +0000 | |||
28 | +++ openlp/plugins/alerts/lib/alertsmanager.py 2016-05-21 08:42:57 +0000 | |||
29 | @@ -62,7 +62,7 @@ | |||
30 | 62 | 62 | ||
31 | 63 | :param text: The text to display | 63 | :param text: The text to display |
32 | 64 | """ | 64 | """ |
34 | 65 | self.log_debug('display alert called %s' % text) | 65 | self.log_debug('display alert called {text}'.format(text=text)) |
35 | 66 | if text: | 66 | if text: |
36 | 67 | self.alert_list.append(text) | 67 | self.alert_list.append(text) |
37 | 68 | if self.timer_id != 0: | 68 | if self.timer_id != 0: |
38 | 69 | 69 | ||
39 | === modified file 'openlp/plugins/alerts/lib/alertstab.py' | |||
40 | --- openlp/plugins/alerts/lib/alertstab.py 2016-04-17 19:06:17 +0000 | |||
41 | +++ openlp/plugins/alerts/lib/alertstab.py 2016-05-21 08:42:57 +0000 | |||
42 | @@ -197,5 +197,6 @@ | |||
43 | 197 | font.setBold(True) | 197 | font.setBold(True) |
44 | 198 | font.setPointSize(self.font_size) | 198 | font.setPointSize(self.font_size) |
45 | 199 | self.font_preview.setFont(font) | 199 | self.font_preview.setFont(font) |
47 | 200 | self.font_preview.setStyleSheet('background-color: %s; color: %s' % (self.background_color, self.font_color)) | 200 | self.font_preview.setStyleSheet('background-color: {back}; color: {front}'.format(back=self.background_color, |
48 | 201 | front=self.font_color)) | ||
49 | 201 | self.changed = True | 202 | self.changed = True |
50 | 202 | 203 | ||
51 | === modified file 'openlp/plugins/bibles/forms/bibleimportform.py' | |||
52 | --- openlp/plugins/bibles/forms/bibleimportform.py 2016-05-05 20:30:00 +0000 | |||
53 | +++ openlp/plugins/bibles/forms/bibleimportform.py 2016-05-21 08:42:57 +0000 | |||
54 | @@ -593,22 +593,27 @@ | |||
55 | 593 | """ | 593 | """ |
56 | 594 | Show the file open dialog for the books CSV file. | 594 | Show the file open dialog for the books CSV file. |
57 | 595 | """ | 595 | """ |
58 | 596 | # TODO: Verify format() with varible template | ||
59 | 596 | self.get_file_name( | 597 | self.get_file_name( |
62 | 597 | WizardStrings.OpenTypeFile % WizardStrings.CSV, self.csv_books_edit, 'last directory import', '%s (*.csv)' % | 598 | WizardStrings.OpenTypeFile % WizardStrings.CSV, |
63 | 598 | translate('BiblesPlugin.ImportWizardForm', 'CSV File')) | 599 | self.csv_books_edit, |
64 | 600 | 'last directory import', | ||
65 | 601 | '{name} (*.csv)'.format(name=translate('BiblesPlugin.ImportWizardForm', 'CSV File'))) | ||
66 | 599 | 602 | ||
67 | 600 | def on_csv_verses_browse_button_clicked(self): | 603 | def on_csv_verses_browse_button_clicked(self): |
68 | 601 | """ | 604 | """ |
69 | 602 | Show the file open dialog for the verses CSV file. | 605 | Show the file open dialog for the verses CSV file. |
70 | 603 | """ | 606 | """ |
71 | 607 | # TODO: Verify format() with variable template | ||
72 | 604 | self.get_file_name(WizardStrings.OpenTypeFile % WizardStrings.CSV, self.csv_verses_edit, | 608 | self.get_file_name(WizardStrings.OpenTypeFile % WizardStrings.CSV, self.csv_verses_edit, |
75 | 605 | 'last directory import', '%s (*.csv)' % | 609 | 'last directory import', |
76 | 606 | translate('BiblesPlugin.ImportWizardForm', 'CSV File')) | 610 | '{name} (*.csv)'.format(name=translate('BiblesPlugin.ImportWizardForm', 'CSV File'))) |
77 | 607 | 611 | ||
78 | 608 | def on_open_song_browse_button_clicked(self): | 612 | def on_open_song_browse_button_clicked(self): |
79 | 609 | """ | 613 | """ |
80 | 610 | Show the file open dialog for the OpenSong file. | 614 | Show the file open dialog for the OpenSong file. |
81 | 611 | """ | 615 | """ |
82 | 616 | # TODO: Verify format() with variable template | ||
83 | 612 | self.get_file_name(WizardStrings.OpenTypeFile % WizardStrings.OS, self.open_song_file_edit, | 617 | self.get_file_name(WizardStrings.OpenTypeFile % WizardStrings.OS, self.open_song_file_edit, |
84 | 613 | 'last directory import') | 618 | 'last directory import') |
85 | 614 | 619 | ||
86 | @@ -616,6 +621,7 @@ | |||
87 | 616 | """ | 621 | """ |
88 | 617 | Show the file open dialog for the Zefania file. | 622 | Show the file open dialog for the Zefania file. |
89 | 618 | """ | 623 | """ |
90 | 624 | # TODO: Verify format() with variable template | ||
91 | 619 | self.get_file_name(WizardStrings.OpenTypeFile % WizardStrings.ZEF, self.zefania_file_edit, | 625 | self.get_file_name(WizardStrings.OpenTypeFile % WizardStrings.ZEF, self.zefania_file_edit, |
92 | 620 | 'last directory import') | 626 | 'last directory import') |
93 | 621 | 627 | ||
94 | @@ -631,6 +637,7 @@ | |||
95 | 631 | self.web_progress_bar.setVisible(True) | 637 | self.web_progress_bar.setVisible(True) |
96 | 632 | self.web_progress_bar.setValue(0) | 638 | self.web_progress_bar.setValue(0) |
97 | 633 | proxy_server = self.field('proxy_server') | 639 | proxy_server = self.field('proxy_server') |
98 | 640 | # TODO: Where does critical_error_message_box get %s string from? | ||
99 | 634 | for (download_type, extractor) in ((WebDownload.Crosswalk, CWExtract(proxy_server)), | 641 | for (download_type, extractor) in ((WebDownload.Crosswalk, CWExtract(proxy_server)), |
100 | 635 | (WebDownload.BibleGateway, BGExtract(proxy_server)), | 642 | (WebDownload.BibleGateway, BGExtract(proxy_server)), |
101 | 636 | (WebDownload.Bibleserver, BSExtract(proxy_server))): | 643 | (WebDownload.Bibleserver, BSExtract(proxy_server))): |
102 | 637 | 644 | ||
103 | === modified file 'openlp/plugins/bibles/forms/bibleupgradeform.py' | |||
104 | --- openlp/plugins/bibles/forms/bibleupgradeform.py 2016-04-22 18:25:57 +0000 | |||
105 | +++ openlp/plugins/bibles/forms/bibleupgradeform.py 2016-05-21 08:42:57 +0000 | |||
106 | @@ -209,7 +209,7 @@ | |||
107 | 209 | for number, filename in enumerate(self.files): | 209 | for number, filename in enumerate(self.files): |
108 | 210 | bible = OldBibleDB(self.media_item, path=self.path, file=filename[0]) | 210 | bible = OldBibleDB(self.media_item, path=self.path, file=filename[0]) |
109 | 211 | self.checkBox[number] = QtWidgets.QCheckBox(self.scrollAreaContents) | 211 | self.checkBox[number] = QtWidgets.QCheckBox(self.scrollAreaContents) |
111 | 212 | self.checkBox[number].setObjectName('checkBox[%d]' % number) | 212 | self.checkBox[number].setObjectName('checkBox[{count:d}]'.format(count=number)) |
112 | 213 | self.checkBox[number].setText(bible.get_name()) | 213 | self.checkBox[number].setText(bible.get_name()) |
113 | 214 | self.checkBox[number].setCheckState(QtCore.Qt.Checked) | 214 | self.checkBox[number].setCheckState(QtCore.Qt.Checked) |
114 | 215 | self.formLayout.addWidget(self.checkBox[number]) | 215 | self.formLayout.addWidget(self.checkBox[number]) |
115 | @@ -364,7 +364,10 @@ | |||
116 | 364 | name = filename[1] | 364 | name = filename[1] |
117 | 365 | self.progress_label.setText( | 365 | self.progress_label.setText( |
118 | 366 | translate('BiblesPlugin.UpgradeWizardForm', | 366 | translate('BiblesPlugin.UpgradeWizardForm', |
120 | 367 | 'Upgrading Bible %s of %s: "%s"\nUpgrading ...') % (number + 1, max_bibles, name)) | 367 | 'Upgrading Bible {count} of {total}: "{name}"\n' |
121 | 368 | 'Upgrading ...').format(count=number + 1, | ||
122 | 369 | total=max_bibles, | ||
123 | 370 | name=name)) | ||
124 | 368 | self.new_bibles[number] = BibleDB(self.media_item, path=self.path, name=name, file=filename[0]) | 371 | self.new_bibles[number] = BibleDB(self.media_item, path=self.path, name=name, file=filename[0]) |
125 | 369 | self.new_bibles[number].register(self.plugin.upgrade_wizard) | 372 | self.new_bibles[number].register(self.plugin.upgrade_wizard) |
126 | 370 | metadata = old_bible.get_metadata() | 373 | metadata = old_bible.get_metadata() |
127 | @@ -394,17 +397,19 @@ | |||
128 | 394 | handler = BSExtract(proxy_server) | 397 | handler = BSExtract(proxy_server) |
129 | 395 | books = handler.get_books_from_http(meta_data['download_name']) | 398 | books = handler.get_books_from_http(meta_data['download_name']) |
130 | 396 | if not books: | 399 | if not books: |
133 | 397 | log.error('Upgrading books from %s - download name: "%s" failed' % ( | 400 | log.error('Upgrading books from {uri} - ' |
134 | 398 | meta_data['download_source'], meta_data['download_name'])) | 401 | 'download name: "{name}" failed'.format(uri=meta_data['download_source'], |
135 | 402 | name=meta_data['download_name'])) | ||
136 | 399 | self.new_bibles[number].session.close() | 403 | self.new_bibles[number].session.close() |
137 | 400 | del self.new_bibles[number] | 404 | del self.new_bibles[number] |
138 | 401 | critical_error_message_box( | 405 | critical_error_message_box( |
139 | 402 | translate('BiblesPlugin.UpgradeWizardForm', 'Download Error'), | 406 | translate('BiblesPlugin.UpgradeWizardForm', 'Download Error'), |
140 | 403 | translate('BiblesPlugin.UpgradeWizardForm', | 407 | translate('BiblesPlugin.UpgradeWizardForm', |
141 | 404 | 'To upgrade your Web Bibles an Internet connection is required.')) | 408 | 'To upgrade your Web Bibles an Internet connection is required.')) |
145 | 405 | self.increment_progress_bar(translate( | 409 | text = translate('BiblesPlugin.UpgradeWizardForm', |
146 | 406 | 'BiblesPlugin.UpgradeWizardForm', 'Upgrading Bible %s of %s: "%s"\nFailed') % | 410 | 'Upgrading Bible {count} of {total}: "{name}"\n' |
147 | 407 | (number + 1, max_bibles, name), self.progress_bar.maximum() - self.progress_bar.value()) | 411 | 'Failed').format(count=number + 1, total=max_bibles, name=name) |
148 | 412 | self.increment_progress_bar(text, self.progress_bar.maximum() - self.progress_bar.value()) | ||
149 | 408 | self.success[number] = False | 413 | self.success[number] = False |
150 | 409 | continue | 414 | continue |
151 | 410 | bible = BiblesResourcesDB.get_webbible( | 415 | bible = BiblesResourcesDB.get_webbible( |
152 | @@ -416,12 +421,13 @@ | |||
153 | 416 | else: | 421 | else: |
154 | 417 | language_id = self.new_bibles[number].get_language(name) | 422 | language_id = self.new_bibles[number].get_language(name) |
155 | 418 | if not language_id: | 423 | if not language_id: |
157 | 419 | log.warning('Upgrading from "%s" failed' % filename[0]) | 424 | log.warning('Upgrading from "{name}" failed'.format(name=filename[0])) |
158 | 420 | self.new_bibles[number].session.close() | 425 | self.new_bibles[number].session.close() |
159 | 421 | del self.new_bibles[number] | 426 | del self.new_bibles[number] |
160 | 422 | self.increment_progress_bar( | 427 | self.increment_progress_bar( |
161 | 423 | translate('BiblesPlugin.UpgradeWizardForm', | 428 | translate('BiblesPlugin.UpgradeWizardForm', |
163 | 424 | 'Upgrading Bible %s of %s: "%s"\nFailed') % (number + 1, max_bibles, name), | 429 | 'Upgrading Bible {count} of {total}: "{name}"\n' |
164 | 430 | 'Failed').format(count=number + 1, total=max_bibles, name=name), | ||
165 | 425 | self.progress_bar.maximum() - self.progress_bar.value()) | 431 | self.progress_bar.maximum() - self.progress_bar.value()) |
166 | 426 | self.success[number] = False | 432 | self.success[number] = False |
167 | 427 | continue | 433 | continue |
168 | @@ -432,13 +438,15 @@ | |||
169 | 432 | break | 438 | break |
170 | 433 | self.increment_progress_bar( | 439 | self.increment_progress_bar( |
171 | 434 | translate('BiblesPlugin.UpgradeWizardForm', | 440 | translate('BiblesPlugin.UpgradeWizardForm', |
174 | 435 | 'Upgrading Bible %s of %s: "%s"\nUpgrading %s ...') % | 441 | 'Upgrading Bible {count} of {total}: "{name}"\n' |
175 | 436 | (number + 1, max_bibles, name, book)) | 442 | 'Upgrading {book} ...').format(count=number + 1, total=max_bibles, |
176 | 443 | name=name, book=book)) | ||
177 | 437 | book_ref_id = self.new_bibles[number].\ | 444 | book_ref_id = self.new_bibles[number].\ |
178 | 438 | get_book_ref_id_by_name(book, len(books), language_id) | 445 | get_book_ref_id_by_name(book, len(books), language_id) |
179 | 439 | if not book_ref_id: | 446 | if not book_ref_id: |
182 | 440 | log.warning('Upgrading books from %s - download name: "%s" aborted by user' % ( | 447 | log.warning('Upgrading books from {source} - download name: "{name}" ' |
183 | 441 | meta_data['download_source'], meta_data['download_name'])) | 448 | 'aborted by user'.format(source=meta_data['download_source'], |
184 | 449 | name=meta_data['download_name'])) | ||
185 | 442 | self.new_bibles[number].session.close() | 450 | self.new_bibles[number].session.close() |
186 | 443 | del self.new_bibles[number] | 451 | del self.new_bibles[number] |
187 | 444 | self.success[number] = False | 452 | self.success[number] = False |
188 | @@ -450,7 +458,7 @@ | |||
189 | 450 | if oldbook: | 458 | if oldbook: |
190 | 451 | verses = old_bible.get_verses(oldbook['id']) | 459 | verses = old_bible.get_verses(oldbook['id']) |
191 | 452 | if not verses: | 460 | if not verses: |
193 | 453 | log.warning('No verses found to import for book "%s"', book) | 461 | log.warning('No verses found to import for book "{book}"'.format(book=book)) |
194 | 454 | continue | 462 | continue |
195 | 455 | for verse in verses: | 463 | for verse in verses: |
196 | 456 | if self.stop_import_flag: | 464 | if self.stop_import_flag: |
197 | @@ -465,12 +473,13 @@ | |||
198 | 465 | if not language_id: | 473 | if not language_id: |
199 | 466 | language_id = self.new_bibles[number].get_language(name) | 474 | language_id = self.new_bibles[number].get_language(name) |
200 | 467 | if not language_id: | 475 | if not language_id: |
202 | 468 | log.warning('Upgrading books from "%s" failed' % name) | 476 | log.warning('Upgrading books from "{name}" failed'.format(name=name)) |
203 | 469 | self.new_bibles[number].session.close() | 477 | self.new_bibles[number].session.close() |
204 | 470 | del self.new_bibles[number] | 478 | del self.new_bibles[number] |
205 | 471 | self.increment_progress_bar( | 479 | self.increment_progress_bar( |
206 | 472 | translate('BiblesPlugin.UpgradeWizardForm', | 480 | translate('BiblesPlugin.UpgradeWizardForm', |
208 | 473 | 'Upgrading Bible %s of %s: "%s"\nFailed') % (number + 1, max_bibles, name), | 481 | 'Upgrading Bible {count} of {total}: "{name}"\n' |
209 | 482 | 'Failed').format(count=number + 1, total=max_bibles, name=name), | ||
210 | 474 | self.progress_bar.maximum() - self.progress_bar.value()) | 483 | self.progress_bar.maximum() - self.progress_bar.value()) |
211 | 475 | self.success[number] = False | 484 | self.success[number] = False |
212 | 476 | continue | 485 | continue |
213 | @@ -482,11 +491,12 @@ | |||
214 | 482 | break | 491 | break |
215 | 483 | self.increment_progress_bar( | 492 | self.increment_progress_bar( |
216 | 484 | translate('BiblesPlugin.UpgradeWizardForm', | 493 | translate('BiblesPlugin.UpgradeWizardForm', |
219 | 485 | 'Upgrading Bible %s of %s: "%s"\nUpgrading %s ...') % | 494 | 'Upgrading Bible {count} of {total}: "{name}"\n' |
220 | 486 | (number + 1, max_bibles, name, book['name'])) | 495 | 'Upgrading {book} ...').format(count=number + 1, total=max_bibles, |
221 | 496 | name=name, book=book['name'])) | ||
222 | 487 | book_ref_id = self.new_bibles[number].get_book_ref_id_by_name(book['name'], len(books), language_id) | 497 | book_ref_id = self.new_bibles[number].get_book_ref_id_by_name(book['name'], len(books), language_id) |
223 | 488 | if not book_ref_id: | 498 | if not book_ref_id: |
225 | 489 | log.warning('Upgrading books from %s " failed - aborted by user' % name) | 499 | log.warning('Upgrading books from {name} " failed - aborted by user'.format(name=name)) |
226 | 490 | self.new_bibles[number].session.close() | 500 | self.new_bibles[number].session.close() |
227 | 491 | del self.new_bibles[number] | 501 | del self.new_bibles[number] |
228 | 492 | self.success[number] = False | 502 | self.success[number] = False |
229 | @@ -496,7 +506,7 @@ | |||
230 | 496 | book_details['testament_id']) | 506 | book_details['testament_id']) |
231 | 497 | verses = old_bible.get_verses(book['id']) | 507 | verses = old_bible.get_verses(book['id']) |
232 | 498 | if not verses: | 508 | if not verses: |
234 | 499 | log.warning('No verses found to import for book "%s"', book['name']) | 509 | log.warning('No verses found to import for book "{book}"'.format(book=book['name'])) |
235 | 500 | self.new_bibles[number].delete_book(db_book) | 510 | self.new_bibles[number].delete_book(db_book) |
236 | 501 | continue | 511 | continue |
237 | 502 | for verse in verses: | 512 | for verse in verses: |
238 | @@ -510,14 +520,16 @@ | |||
239 | 510 | if not self.success.get(number, True): | 520 | if not self.success.get(number, True): |
240 | 511 | self.increment_progress_bar( | 521 | self.increment_progress_bar( |
241 | 512 | translate('BiblesPlugin.UpgradeWizardForm', | 522 | translate('BiblesPlugin.UpgradeWizardForm', |
243 | 513 | 'Upgrading Bible %s of %s: "%s"\nFailed') % (number + 1, max_bibles, name), | 523 | 'Upgrading Bible {count} of {total}: "{name}"\n' |
244 | 524 | 'Failed').format(count=number + 1, total=max_bibles, name=name), | ||
245 | 514 | self.progress_bar.maximum() - self.progress_bar.value()) | 525 | self.progress_bar.maximum() - self.progress_bar.value()) |
246 | 515 | else: | 526 | else: |
247 | 516 | self.success[number] = True | 527 | self.success[number] = True |
248 | 517 | self.new_bibles[number].save_meta('name', name) | 528 | self.new_bibles[number].save_meta('name', name) |
249 | 518 | self.increment_progress_bar( | 529 | self.increment_progress_bar( |
250 | 519 | translate('BiblesPlugin.UpgradeWizardForm', | 530 | translate('BiblesPlugin.UpgradeWizardForm', |
252 | 520 | 'Upgrading Bible %s of %s: "%s"\nComplete') % (number + 1, max_bibles, name)) | 531 | 'Upgrading Bible {count} of {total}: "{name}"\n' |
253 | 532 | 'Complete').format(count=number + 1, total=max_bibles, name=name)) | ||
254 | 521 | if number in self.new_bibles: | 533 | if number in self.new_bibles: |
255 | 522 | self.new_bibles[number].session.close() | 534 | self.new_bibles[number].session.close() |
256 | 523 | # Close the last bible's connection if possible. | 535 | # Close the last bible's connection if possible. |
257 | @@ -540,20 +552,22 @@ | |||
258 | 540 | # Copy not upgraded bible back. | 552 | # Copy not upgraded bible back. |
259 | 541 | shutil.move(os.path.join(self.temp_dir, filename[0]), self.path) | 553 | shutil.move(os.path.join(self.temp_dir, filename[0]), self.path) |
260 | 542 | if failed_import > 0: | 554 | if failed_import > 0: |
262 | 543 | failed_import_text = translate('BiblesPlugin.UpgradeWizardForm', ', %s failed') % failed_import | 555 | failed_import_text = translate('BiblesPlugin.UpgradeWizardForm', |
263 | 556 | ', {name} failed').format(name=failed_import) | ||
264 | 544 | else: | 557 | else: |
265 | 545 | failed_import_text = '' | 558 | failed_import_text = '' |
266 | 546 | if successful_import > 0: | 559 | if successful_import > 0: |
267 | 547 | if self.includeWebBible: | 560 | if self.includeWebBible: |
268 | 548 | self.progress_label.setText( | 561 | self.progress_label.setText( |
269 | 549 | translate('BiblesPlugin.UpgradeWizardForm', | 562 | translate('BiblesPlugin.UpgradeWizardForm', |
273 | 550 | 'Upgrading Bible(s): %(success)d successful%(failed_text)s\nPlease note that verses ' | 563 | 'Upgrading Bible(s): {count:d} successful{failed}\nPlease note that verses ' |
274 | 551 | 'from Web Bibles will be downloaded on demand and so an Internet connection is required.') | 564 | 'from Web Bibles will be downloaded on demand and so an Internet connection is required.' |
275 | 552 | % {'success': successful_import, 'failed_text': failed_import_text}) | 565 | ).format(count=successful_import, failed=failed_import_text)) |
276 | 553 | else: | 566 | else: |
277 | 554 | self.progress_label.setText( | 567 | self.progress_label.setText( |
280 | 555 | translate('BiblesPlugin.UpgradeWizardForm', 'Upgrading Bible(s): %s successful%s') % ( | 568 | translate('BiblesPlugin.UpgradeWizardForm', |
281 | 556 | successful_import, failed_import_text)) | 569 | 'Upgrading Bible(s): {count:d} successful{failed}').format(count=successful_import, |
282 | 570 | failed=failed_import_text)) | ||
283 | 557 | else: | 571 | else: |
284 | 558 | self.progress_label.setText(translate('BiblesPlugin.UpgradeWizardForm', 'Upgrade failed.')) | 572 | self.progress_label.setText(translate('BiblesPlugin.UpgradeWizardForm', 'Upgrade failed.')) |
285 | 559 | # Remove temp directory. | 573 | # Remove temp directory. |
286 | 560 | 574 | ||
287 | === modified file 'openlp/plugins/bibles/forms/editbibledialog.py' | |||
288 | --- openlp/plugins/bibles/forms/editbibledialog.py 2015-12-31 22:46:06 +0000 | |||
289 | +++ openlp/plugins/bibles/forms/editbibledialog.py 2016-05-21 08:42:57 +0000 | |||
290 | @@ -103,9 +103,11 @@ | |||
291 | 103 | self.book_name_edit = {} | 103 | self.book_name_edit = {} |
292 | 104 | for book in BiblesResourcesDB.get_books(): | 104 | for book in BiblesResourcesDB.get_books(): |
293 | 105 | self.book_name_label[book['abbreviation']] = QtWidgets.QLabel(self.book_name_widget) | 105 | self.book_name_label[book['abbreviation']] = QtWidgets.QLabel(self.book_name_widget) |
295 | 106 | self.book_name_label[book['abbreviation']].setObjectName('book_name_label[%s]' % book['abbreviation']) | 106 | self.book_name_label[book['abbreviation']].setObjectName( |
296 | 107 | 'book_name_label[{name}]'.format(book=book['abbreviation'])) | ||
297 | 107 | self.book_name_edit[book['abbreviation']] = QtWidgets.QLineEdit(self.book_name_widget) | 108 | self.book_name_edit[book['abbreviation']] = QtWidgets.QLineEdit(self.book_name_widget) |
299 | 108 | self.book_name_edit[book['abbreviation']].setObjectName('book_name_edit[%s]' % book['abbreviation']) | 109 | self.book_name_edit[book['abbreviation']].setObjectName( |
300 | 110 | 'book_name_edit[{name}]'.format(name=book['abbreviation'])) | ||
301 | 109 | self.book_name_widget_layout.addRow( | 111 | self.book_name_widget_layout.addRow( |
302 | 110 | self.book_name_label[book['abbreviation']], | 112 | self.book_name_label[book['abbreviation']], |
303 | 111 | self.book_name_edit[book['abbreviation']]) | 113 | self.book_name_edit[book['abbreviation']]) |
304 | @@ -148,4 +150,5 @@ | |||
305 | 148 | self.bible_tab_widget.indexOf(self.book_name_tab), | 150 | self.bible_tab_widget.indexOf(self.book_name_tab), |
306 | 149 | translate('SongsPlugin.EditBibleForm', 'Custom Book Names')) | 151 | translate('SongsPlugin.EditBibleForm', 'Custom Book Names')) |
307 | 150 | for book in BiblesResourcesDB.get_books(): | 152 | for book in BiblesResourcesDB.get_books(): |
309 | 151 | self.book_name_label[book['abbreviation']].setText('%s:' % str(self.book_names[book['abbreviation']])) | 153 | self.book_name_label[book['abbreviation']].setText( |
310 | 154 | '{text}:'.format(text=self.book_names[book['abbreviation']])) | ||
311 | 152 | 155 | ||
312 | === modified file 'openlp/plugins/bibles/forms/editbibleform.py' | |||
313 | --- openlp/plugins/bibles/forms/editbibleform.py 2016-01-09 16:26:14 +0000 | |||
314 | +++ openlp/plugins/bibles/forms/editbibleform.py 2016-05-21 08:42:57 +0000 | |||
315 | @@ -39,7 +39,7 @@ | |||
316 | 39 | """ | 39 | """ |
317 | 40 | Class to manage the editing of a bible | 40 | Class to manage the editing of a bible |
318 | 41 | """ | 41 | """ |
320 | 42 | log.info('%s EditBibleForm loaded', __name__) | 42 | log.info('{name} EditBibleForm loaded'.format(name=__name__)) |
321 | 43 | 43 | ||
322 | 44 | def __init__(self, media_item, parent, manager): | 44 | def __init__(self, media_item, parent, manager): |
323 | 45 | """ | 45 | """ |
324 | @@ -168,16 +168,17 @@ | |||
325 | 168 | self.book_name_edit[abbreviation].setFocus() | 168 | self.book_name_edit[abbreviation].setFocus() |
326 | 169 | critical_error_message_box( | 169 | critical_error_message_box( |
327 | 170 | UiStrings().EmptyField, | 170 | UiStrings().EmptyField, |
330 | 171 | translate('BiblesPlugin.BibleEditForm', 'You need to specify a book name for "%s".') % | 171 | translate('BiblesPlugin.BibleEditForm', |
331 | 172 | self.book_names[abbreviation]) | 172 | 'You need to specify a book name for "{text}".').format(text=self.book_names[abbreviation])) |
332 | 173 | return False | 173 | return False |
333 | 174 | elif not book_regex.match(new_book_name): | 174 | elif not book_regex.match(new_book_name): |
334 | 175 | self.book_name_edit[abbreviation].setFocus() | 175 | self.book_name_edit[abbreviation].setFocus() |
335 | 176 | critical_error_message_box( | 176 | critical_error_message_box( |
336 | 177 | UiStrings().EmptyField, | 177 | UiStrings().EmptyField, |
337 | 178 | translate('BiblesPlugin.BibleEditForm', | 178 | translate('BiblesPlugin.BibleEditForm', |
340 | 179 | 'The book name "%s" is not correct.\nNumbers can only be used at the beginning and must\nbe ' | 179 | 'The book name "{name}" is not correct.\n' |
341 | 180 | 'followed by one or more non-numeric characters.') % new_book_name) | 180 | 'Numbers can only be used at the beginning and must\nbe ' |
342 | 181 | 'followed by one or more non-numeric characters.').format(name=new_book_name)) | ||
343 | 181 | return False | 182 | return False |
344 | 182 | for abbr, book in self.books.items(): | 183 | for abbr, book in self.books.items(): |
345 | 183 | if book: | 184 | if book: |
346 | @@ -187,7 +188,7 @@ | |||
347 | 187 | self.book_name_edit[abbreviation].setFocus() | 188 | self.book_name_edit[abbreviation].setFocus() |
348 | 188 | critical_error_message_box( | 189 | critical_error_message_box( |
349 | 189 | translate('BiblesPlugin.BibleEditForm', 'Duplicate Book Name'), | 190 | translate('BiblesPlugin.BibleEditForm', 'Duplicate Book Name'), |
352 | 190 | translate('BiblesPlugin.BibleEditForm', 'The Book Name "%s" has been entered more than once.') | 191 | translate('BiblesPlugin.BibleEditForm', |
353 | 191 | % new_book_name) | 192 | 'The Book Name "{name}" has been entered more than once.').format(name=new_book_name)) |
354 | 192 | return False | 193 | return False |
355 | 193 | return True | 194 | return True |
356 | 194 | 195 | ||
357 | === modified file 'openlp/plugins/bibles/lib/csvbible.py' | |||
358 | --- openlp/plugins/bibles/lib/csvbible.py 2015-12-31 22:46:06 +0000 | |||
359 | +++ openlp/plugins/bibles/lib/csvbible.py 2016-05-21 08:42:57 +0000 | |||
360 | @@ -86,7 +86,7 @@ | |||
361 | 86 | success = True | 86 | success = True |
362 | 87 | language_id = self.get_language(bible_name) | 87 | language_id = self.get_language(bible_name) |
363 | 88 | if not language_id: | 88 | if not language_id: |
365 | 89 | log.error('Importing books from "%s" failed' % self.filename) | 89 | log.error('Importing books from "{name}" failed'.format(name=self.filename)) |
366 | 90 | return False | 90 | return False |
367 | 91 | books_file = None | 91 | books_file = None |
368 | 92 | book_list = {} | 92 | book_list = {} |
369 | @@ -98,11 +98,11 @@ | |||
370 | 98 | for line in books_reader: | 98 | for line in books_reader: |
371 | 99 | if self.stop_import_flag: | 99 | if self.stop_import_flag: |
372 | 100 | break | 100 | break |
375 | 101 | self.wizard.increment_progress_bar(translate('BiblesPlugin.CSVBible', 'Importing books... %s') | 101 | self.wizard.increment_progress_bar(translate('BiblesPlugin.CSVBible', |
376 | 102 | % line[2]) | 102 | 'Importing books... {text}').format(text=line[2])) |
377 | 103 | book_ref_id = self.get_book_ref_id_by_name(line[2], 67, language_id) | 103 | book_ref_id = self.get_book_ref_id_by_name(line[2], 67, language_id) |
378 | 104 | if not book_ref_id: | 104 | if not book_ref_id: |
380 | 105 | log.error('Importing books from "%s" failed' % self.books_file) | 105 | log.error('Importing books from "{name}" failed'.format(name=self.books_file)) |
381 | 106 | return False | 106 | return False |
382 | 107 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) | 107 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) |
383 | 108 | self.create_book(line[2], book_ref_id, book_details['testament_id']) | 108 | self.create_book(line[2], book_ref_id, book_details['testament_id']) |
384 | @@ -134,9 +134,11 @@ | |||
385 | 134 | if book_ptr != line_book: | 134 | if book_ptr != line_book: |
386 | 135 | book = self.get_book(line_book) | 135 | book = self.get_book(line_book) |
387 | 136 | book_ptr = book.name | 136 | book_ptr = book.name |
388 | 137 | # TODO: Check out this conversion in translations | ||
389 | 137 | self.wizard.increment_progress_bar( | 138 | self.wizard.increment_progress_bar( |
390 | 138 | translate('BiblesPlugin.CSVBible', | 139 | translate('BiblesPlugin.CSVBible', |
392 | 139 | 'Importing verses from %s...' % book.name, 'Importing verses from <book name>...')) | 140 | 'Importing verses from {name}...'.format(name=book.name), |
393 | 141 | 'Importing verses from <book name>...')) | ||
394 | 140 | self.session.commit() | 142 | self.session.commit() |
395 | 141 | verse_text = line[3] | 143 | verse_text = line[3] |
396 | 142 | self.create_verse(book.id, line[1], line[2], verse_text) | 144 | self.create_verse(book.id, line[1], line[2], verse_text) |
397 | 143 | 145 | ||
398 | === modified file 'openlp/plugins/bibles/lib/db.py' | |||
399 | --- openlp/plugins/bibles/lib/db.py 2016-04-05 17:30:20 +0000 | |||
400 | +++ openlp/plugins/bibles/lib/db.py 2016-05-21 08:42:57 +0000 | |||
401 | @@ -185,7 +185,7 @@ | |||
402 | 185 | :param testament: *Defaults to 1.* The testament_reference_id from | 185 | :param testament: *Defaults to 1.* The testament_reference_id from |
403 | 186 | bibles_resources.sqlite of the testament this book belongs to. | 186 | bibles_resources.sqlite of the testament this book belongs to. |
404 | 187 | """ | 187 | """ |
406 | 188 | log.debug('BibleDB.create_book("%s", "%s")' % (name, bk_ref_id)) | 188 | log.debug('BibleDB.create_book("{name}", "{number}")'.format(name=name, number=bk_ref_id)) |
407 | 189 | book = Book.populate(name=name, book_reference_id=bk_ref_id, testament_reference_id=testament) | 189 | book = Book.populate(name=name, book_reference_id=bk_ref_id, testament_reference_id=testament) |
408 | 190 | self.save_object(book) | 190 | self.save_object(book) |
409 | 191 | return book | 191 | return book |
410 | @@ -196,7 +196,7 @@ | |||
411 | 196 | 196 | ||
412 | 197 | :param book: The book object | 197 | :param book: The book object |
413 | 198 | """ | 198 | """ |
415 | 199 | log.debug('BibleDB.update_book("%s")' % book.name) | 199 | log.debug('BibleDB.update_book("{name}")'.format(name=book.name)) |
416 | 200 | return self.save_object(book) | 200 | return self.save_object(book) |
417 | 201 | 201 | ||
418 | 202 | def delete_book(self, db_book): | 202 | def delete_book(self, db_book): |
419 | @@ -205,7 +205,7 @@ | |||
420 | 205 | 205 | ||
421 | 206 | :param db_book: The book object. | 206 | :param db_book: The book object. |
422 | 207 | """ | 207 | """ |
424 | 208 | log.debug('BibleDB.delete_book("%s")' % db_book.name) | 208 | log.debug('BibleDB.delete_book("{name}")'.format(name=db_book.name)) |
425 | 209 | if self.delete_object(Book, db_book.id): | 209 | if self.delete_object(Book, db_book.id): |
426 | 210 | return True | 210 | return True |
427 | 211 | return False | 211 | return False |
428 | @@ -219,7 +219,7 @@ | |||
429 | 219 | :param text_list: A dict of the verses to be inserted. The key is the verse number, and the value is the | 219 | :param text_list: A dict of the verses to be inserted. The key is the verse number, and the value is the |
430 | 220 | verse text. | 220 | verse text. |
431 | 221 | """ | 221 | """ |
433 | 222 | log.debug('BibleDBcreate_chapter("%s", "%s")' % (book_id, chapter)) | 222 | log.debug('BibleDBcreate_chapter("{number}", "{chapter}")'.format(number=book_id, chapter=chapter)) |
434 | 223 | # Text list has book and chapter as first two elements of the array. | 223 | # Text list has book and chapter as first two elements of the array. |
435 | 224 | for verse_number, verse_text in text_list.items(): | 224 | for verse_number, verse_text in text_list.items(): |
436 | 225 | verse = Verse.populate( | 225 | verse = Verse.populate( |
437 | @@ -266,7 +266,7 @@ | |||
438 | 266 | """ | 266 | """ |
439 | 267 | if not isinstance(value, str): | 267 | if not isinstance(value, str): |
440 | 268 | value = str(value) | 268 | value = str(value) |
442 | 269 | log.debug('BibleDB.save_meta("%s/%s")' % (key, value)) | 269 | log.debug('BibleDB.save_meta("{key}/{val}")'.format(key=key, val=value)) |
443 | 270 | meta = self.get_object(BibleMeta, key) | 270 | meta = self.get_object(BibleMeta, key) |
444 | 271 | if meta: | 271 | if meta: |
445 | 272 | meta.value = value | 272 | meta.value = value |
446 | @@ -280,7 +280,7 @@ | |||
447 | 280 | 280 | ||
448 | 281 | :param book: The name of the book to return. | 281 | :param book: The name of the book to return. |
449 | 282 | """ | 282 | """ |
451 | 283 | log.debug('BibleDB.get_book("%s")' % book) | 283 | log.debug('BibleDB.get_book("{book}")'.format(book=book)) |
452 | 284 | return self.get_object_filtered(Book, Book.name.like(book + '%')) | 284 | return self.get_object_filtered(Book, Book.name.like(book + '%')) |
453 | 285 | 285 | ||
454 | 286 | def get_books(self): | 286 | def get_books(self): |
455 | @@ -297,11 +297,11 @@ | |||
456 | 297 | 297 | ||
457 | 298 | :param ref_id: The reference id of the book to return. | 298 | :param ref_id: The reference id of the book to return. |
458 | 299 | """ | 299 | """ |
460 | 300 | log.debug('BibleDB.get_book_by_book_ref_id("%s")' % ref_id) | 300 | log.debug('BibleDB.get_book_by_book_ref_id("{ref}")'.format(ref=ref_id)) |
461 | 301 | return self.get_object_filtered(Book, Book.book_reference_id.like(ref_id)) | 301 | return self.get_object_filtered(Book, Book.book_reference_id.like(ref_id)) |
462 | 302 | 302 | ||
463 | 303 | def get_book_ref_id_by_name(self, book, maxbooks, language_id=None): | 303 | def get_book_ref_id_by_name(self, book, maxbooks, language_id=None): |
465 | 304 | log.debug('BibleDB.get_book_ref_id_by_name:("%s", "%s")' % (book, language_id)) | 304 | log.debug('BibleDB.get_book_ref_id_by_name:("{book}", "{lang}")'.format(book=book, lang=language_id)) |
466 | 305 | book_id = None | 305 | book_id = None |
467 | 306 | if BiblesResourcesDB.get_book(book, True): | 306 | if BiblesResourcesDB.get_book(book, True): |
468 | 307 | book_temp = BiblesResourcesDB.get_book(book, True) | 307 | book_temp = BiblesResourcesDB.get_book(book, True) |
469 | @@ -327,13 +327,14 @@ | |||
470 | 327 | :param book: The name of the book, according to the selected language. | 327 | :param book: The name of the book, according to the selected language. |
471 | 328 | :param language_selection: The language selection the user has chosen in the settings section of the Bible. | 328 | :param language_selection: The language selection the user has chosen in the settings section of the Bible. |
472 | 329 | """ | 329 | """ |
474 | 330 | log.debug('get_book_ref_id_by_localised_name("%s", "%s")' % (book, language_selection)) | 330 | log.debug('get_book_ref_id_by_localised_name("{book}", "{lang}")'.format(book=book, lang=language_selection)) |
475 | 331 | from openlp.plugins.bibles.lib import LanguageSelection, BibleStrings | 331 | from openlp.plugins.bibles.lib import LanguageSelection, BibleStrings |
476 | 332 | book_names = BibleStrings().BookNames | 332 | book_names = BibleStrings().BookNames |
477 | 333 | # escape reserved characters | 333 | # escape reserved characters |
478 | 334 | book_escaped = book | 334 | book_escaped = book |
479 | 335 | for character in RESERVED_CHARACTERS: | 335 | for character in RESERVED_CHARACTERS: |
480 | 336 | book_escaped = book_escaped.replace(character, '\\' + character) | 336 | book_escaped = book_escaped.replace(character, '\\' + character) |
481 | 337 | # TODO: Verify regex patters before using format() | ||
482 | 337 | regex_book = re.compile('\s*%s\s*' % '\s*'.join( | 338 | regex_book = re.compile('\s*%s\s*' % '\s*'.join( |
483 | 338 | book_escaped.split()), re.UNICODE | re.IGNORECASE) | 339 | book_escaped.split()), re.UNICODE | re.IGNORECASE) |
484 | 339 | if language_selection == LanguageSelection.Bible: | 340 | if language_selection == LanguageSelection.Bible: |
485 | @@ -374,14 +375,14 @@ | |||
486 | 374 | [('35', 1, 1, 1), ('35', 2, 2, 3)] | 375 | [('35', 1, 1, 1), ('35', 2, 2, 3)] |
487 | 375 | :param show_error: | 376 | :param show_error: |
488 | 376 | """ | 377 | """ |
490 | 377 | log.debug('BibleDB.get_verses("%s")' % reference_list) | 378 | log.debug('BibleDB.get_verses("{ref}")'.format(ref=reference_list)) |
491 | 378 | verse_list = [] | 379 | verse_list = [] |
492 | 379 | book_error = False | 380 | book_error = False |
493 | 380 | for book_id, chapter, start_verse, end_verse in reference_list: | 381 | for book_id, chapter, start_verse, end_verse in reference_list: |
494 | 381 | db_book = self.get_book_by_book_ref_id(book_id) | 382 | db_book = self.get_book_by_book_ref_id(book_id) |
495 | 382 | if db_book: | 383 | if db_book: |
496 | 383 | book_id = db_book.book_reference_id | 384 | book_id = db_book.book_reference_id |
498 | 384 | log.debug('Book name corrected to "%s"' % db_book.name) | 385 | log.debug('Book name corrected to "{book}"'.format(book=db_book.name)) |
499 | 385 | if end_verse == -1: | 386 | if end_verse == -1: |
500 | 386 | end_verse = self.get_verse_count(book_id, chapter) | 387 | end_verse = self.get_verse_count(book_id, chapter) |
501 | 387 | verses = self.session.query(Verse) \ | 388 | verses = self.session.query(Verse) \ |
502 | @@ -393,7 +394,7 @@ | |||
503 | 393 | .all() | 394 | .all() |
504 | 394 | verse_list.extend(verses) | 395 | verse_list.extend(verses) |
505 | 395 | else: | 396 | else: |
507 | 396 | log.debug('OpenLP failed to find book with id "%s"' % book_id) | 397 | log.debug('OpenLP failed to find book with id "{book}"'.format(book=book_id)) |
508 | 397 | book_error = True | 398 | book_error = True |
509 | 398 | if book_error and show_error: | 399 | if book_error and show_error: |
510 | 399 | critical_error_message_box( | 400 | critical_error_message_box( |
511 | @@ -412,8 +413,9 @@ | |||
512 | 412 | contains spaces, it will split apart and AND'd on the list of | 413 | contains spaces, it will split apart and AND'd on the list of |
513 | 413 | values. | 414 | values. |
514 | 414 | """ | 415 | """ |
516 | 415 | log.debug('BibleDB.verse_search("%s")' % text) | 416 | log.debug('BibleDB.verse_search("{text}")'.format(text=text)) |
517 | 416 | verses = self.session.query(Verse) | 417 | verses = self.session.query(Verse) |
518 | 418 | # TODO: Find out what this is doing before converting to format() | ||
519 | 417 | if text.find(',') > -1: | 419 | if text.find(',') > -1: |
520 | 418 | keywords = ['%%%s%%' % keyword.strip() for keyword in text.split(',')] | 420 | keywords = ['%%%s%%' % keyword.strip() for keyword in text.split(',')] |
521 | 419 | or_clause = [Verse.text.like(keyword) for keyword in keywords] | 421 | or_clause = [Verse.text.like(keyword) for keyword in keywords] |
522 | @@ -431,7 +433,7 @@ | |||
523 | 431 | 433 | ||
524 | 432 | :param book: The book object to get the chapter count for. | 434 | :param book: The book object to get the chapter count for. |
525 | 433 | """ | 435 | """ |
527 | 434 | log.debug('BibleDB.get_chapter_count("%s")' % book.name) | 436 | log.debug('BibleDB.get_chapter_count("{book}")'.format(book=book.name)) |
528 | 435 | count = self.session.query(func.max(Verse.chapter)).join(Book).filter( | 437 | count = self.session.query(func.max(Verse.chapter)).join(Book).filter( |
529 | 436 | Book.book_reference_id == book.book_reference_id).scalar() | 438 | Book.book_reference_id == book.book_reference_id).scalar() |
530 | 437 | if not count: | 439 | if not count: |
531 | @@ -445,7 +447,7 @@ | |||
532 | 445 | :param book_ref_id: The book reference id. | 447 | :param book_ref_id: The book reference id. |
533 | 446 | :param chapter: The chapter to get the verse count for. | 448 | :param chapter: The chapter to get the verse count for. |
534 | 447 | """ | 449 | """ |
536 | 448 | log.debug('BibleDB.get_verse_count("%s", "%s")' % (book_ref_id, chapter)) | 450 | log.debug('BibleDB.get_verse_count("{ref}", "{chapter}")'.format(ref=book_ref_id, chapter=chapter)) |
537 | 449 | count = self.session.query(func.max(Verse.verse)).join(Book) \ | 451 | count = self.session.query(func.max(Verse.verse)).join(Book) \ |
538 | 450 | .filter(Book.book_reference_id == book_ref_id) \ | 452 | .filter(Book.book_reference_id == book_ref_id) \ |
539 | 451 | .filter(Verse.chapter == chapter) \ | 453 | .filter(Verse.chapter == chapter) \ |
540 | @@ -551,7 +553,7 @@ | |||
541 | 551 | :param name: The name or abbreviation of the book. | 553 | :param name: The name or abbreviation of the book. |
542 | 552 | :param lower: True if the comparison should be only lowercase | 554 | :param lower: True if the comparison should be only lowercase |
543 | 553 | """ | 555 | """ |
545 | 554 | log.debug('BiblesResourcesDB.get_book("%s")' % name) | 556 | log.debug('BiblesResourcesDB.get_book("{name}")'.format(name=name)) |
546 | 555 | if not isinstance(name, str): | 557 | if not isinstance(name, str): |
547 | 556 | name = str(name) | 558 | name = str(name) |
548 | 557 | if lower: | 559 | if lower: |
549 | @@ -580,7 +582,7 @@ | |||
550 | 580 | 582 | ||
551 | 581 | :param string: The string to search for in the book names or abbreviations. | 583 | :param string: The string to search for in the book names or abbreviations. |
552 | 582 | """ | 584 | """ |
554 | 583 | log.debug('BiblesResourcesDB.get_book_like("%s")' % string) | 585 | log.debug('BiblesResourcesDB.get_book_like("{text}")'.format(text=string)) |
555 | 584 | if not isinstance(string, str): | 586 | if not isinstance(string, str): |
556 | 585 | name = str(string) | 587 | name = str(string) |
557 | 586 | books = BiblesResourcesDB.run_sql( | 588 | books = BiblesResourcesDB.run_sql( |
558 | @@ -605,7 +607,7 @@ | |||
559 | 605 | 607 | ||
560 | 606 | :param book_id: The id of the book. | 608 | :param book_id: The id of the book. |
561 | 607 | """ | 609 | """ |
563 | 608 | log.debug('BiblesResourcesDB.get_book_by_id("%s")' % book_id) | 610 | log.debug('BiblesResourcesDB.get_book_by_id("{book}")'.format(book=book_id)) |
564 | 609 | if not isinstance(book_id, int): | 611 | if not isinstance(book_id, int): |
565 | 610 | book_id = int(book_id) | 612 | book_id = int(book_id) |
566 | 611 | books = BiblesResourcesDB.run_sql( | 613 | books = BiblesResourcesDB.run_sql( |
567 | @@ -629,7 +631,7 @@ | |||
568 | 629 | :param book_ref_id: The id of a book. | 631 | :param book_ref_id: The id of a book. |
569 | 630 | :param chapter: The chapter number. | 632 | :param chapter: The chapter number. |
570 | 631 | """ | 633 | """ |
572 | 632 | log.debug('BiblesResourcesDB.get_chapter("%s", "%s")' % (book_ref_id, chapter)) | 634 | log.debug('BiblesResourcesDB.get_chapter("{book}", "{ref}")'.format(book=book_ref_id, ref=chapter)) |
573 | 633 | if not isinstance(chapter, int): | 635 | if not isinstance(chapter, int): |
574 | 634 | chapter = int(chapter) | 636 | chapter = int(chapter) |
575 | 635 | chapters = BiblesResourcesDB.run_sql( | 637 | chapters = BiblesResourcesDB.run_sql( |
576 | @@ -652,7 +654,7 @@ | |||
577 | 652 | 654 | ||
578 | 653 | :param book_ref_id: The id of the book. | 655 | :param book_ref_id: The id of the book. |
579 | 654 | """ | 656 | """ |
581 | 655 | log.debug('BiblesResourcesDB.get_chapter_count("%s")' % book_ref_id) | 657 | log.debug('BiblesResourcesDB.get_chapter_count("{ref}")'.format(ref=book_ref_id)) |
582 | 656 | details = BiblesResourcesDB.get_book_by_id(book_ref_id) | 658 | details = BiblesResourcesDB.get_book_by_id(book_ref_id) |
583 | 657 | if details: | 659 | if details: |
584 | 658 | return details['chapters'] | 660 | return details['chapters'] |
585 | @@ -666,7 +668,7 @@ | |||
586 | 666 | :param book_ref_id: The id of the book. | 668 | :param book_ref_id: The id of the book. |
587 | 667 | :param chapter: The number of the chapter. | 669 | :param chapter: The number of the chapter. |
588 | 668 | """ | 670 | """ |
590 | 669 | log.debug('BiblesResourcesDB.get_verse_count("%s", "%s")' % (book_ref_id, chapter)) | 671 | log.debug('BiblesResourcesDB.get_verse_count("{ref}", "{chapter}")'.format(ref=book_ref_id, chapter=chapter)) |
591 | 670 | details = BiblesResourcesDB.get_chapter(book_ref_id, chapter) | 672 | details = BiblesResourcesDB.get_chapter(book_ref_id, chapter) |
592 | 671 | if details: | 673 | if details: |
593 | 672 | return details['verse_count'] | 674 | return details['verse_count'] |
594 | @@ -679,7 +681,7 @@ | |||
595 | 679 | 681 | ||
596 | 680 | :param source: The name or abbreviation of the book. | 682 | :param source: The name or abbreviation of the book. |
597 | 681 | """ | 683 | """ |
599 | 682 | log.debug('BiblesResourcesDB.get_download_source("%s")' % source) | 684 | log.debug('BiblesResourcesDB.get_download_source("{source}")'.format(source=source)) |
600 | 683 | if not isinstance(source, str): | 685 | if not isinstance(source, str): |
601 | 684 | source = str(source) | 686 | source = str(source) |
602 | 685 | source = source.title() | 687 | source = source.title() |
603 | @@ -700,7 +702,7 @@ | |||
604 | 700 | 702 | ||
605 | 701 | :param source: The source of the web_bible. | 703 | :param source: The source of the web_bible. |
606 | 702 | """ | 704 | """ |
608 | 703 | log.debug('BiblesResourcesDB.get_webbibles("%s")' % source) | 705 | log.debug('BiblesResourcesDB.get_webbibles("{source}")'.format(source=source)) |
609 | 704 | if not isinstance(source, str): | 706 | if not isinstance(source, str): |
610 | 705 | source = str(source) | 707 | source = str(source) |
611 | 706 | source = BiblesResourcesDB.get_download_source(source) | 708 | source = BiblesResourcesDB.get_download_source(source) |
612 | @@ -725,7 +727,7 @@ | |||
613 | 725 | :param abbreviation: The abbreviation of the web_bible. | 727 | :param abbreviation: The abbreviation of the web_bible. |
614 | 726 | :param source: The source of the web_bible. | 728 | :param source: The source of the web_bible. |
615 | 727 | """ | 729 | """ |
617 | 728 | log.debug('BiblesResourcesDB.get_webbibles("%s", "%s")' % (abbreviation, source)) | 730 | log.debug('BiblesResourcesDB.get_webbibles("{text}", "{source}")'.format(text=abbreviation, source=source)) |
618 | 729 | if not isinstance(abbreviation, str): | 731 | if not isinstance(abbreviation, str): |
619 | 730 | abbreviation = str(abbreviation) | 732 | abbreviation = str(abbreviation) |
620 | 731 | if not isinstance(source, str): | 733 | if not isinstance(source, str): |
621 | @@ -753,7 +755,7 @@ | |||
622 | 753 | :param name: The name to search the id. | 755 | :param name: The name to search the id. |
623 | 754 | :param language_id: The language_id for which language should be searched | 756 | :param language_id: The language_id for which language should be searched |
624 | 755 | """ | 757 | """ |
626 | 756 | log.debug('BiblesResourcesDB.get_alternative_book_name("%s", "%s")' % (name, language_id)) | 758 | log.debug('BiblesResourcesDB.get_alternative_book_name("{name}", "{lang}")'.format(name=name, lang=language_id)) |
627 | 757 | if language_id: | 759 | if language_id: |
628 | 758 | books = BiblesResourcesDB.run_sql( | 760 | books = BiblesResourcesDB.run_sql( |
629 | 759 | 'SELECT book_reference_id, name FROM alternative_book_names WHERE language_id = ? ORDER BY id', | 761 | 'SELECT book_reference_id, name FROM alternative_book_names WHERE language_id = ? ORDER BY id', |
630 | @@ -772,7 +774,7 @@ | |||
631 | 772 | 774 | ||
632 | 773 | :param name: The name or abbreviation of the language. | 775 | :param name: The name or abbreviation of the language. |
633 | 774 | """ | 776 | """ |
635 | 775 | log.debug('BiblesResourcesDB.get_language("%s")' % name) | 777 | log.debug('BiblesResourcesDB.get_language("{name}")'.format(name=name)) |
636 | 776 | if not isinstance(name, str): | 778 | if not isinstance(name, str): |
637 | 777 | name = str(name) | 779 | name = str(name) |
638 | 778 | language = BiblesResourcesDB.run_sql( | 780 | language = BiblesResourcesDB.run_sql( |
639 | @@ -868,7 +870,7 @@ | |||
640 | 868 | :param name: The name to search the id. | 870 | :param name: The name to search the id. |
641 | 869 | :param language_id: The language_id for which language should be searched | 871 | :param language_id: The language_id for which language should be searched |
642 | 870 | """ | 872 | """ |
644 | 871 | log.debug('AlternativeBookNamesDB.get_book_reference_id("%s", "%s")' % (name, language_id)) | 873 | log.debug('AlternativeBookNamesDB.get_book_reference_id("{name}", "{ref}")'.format(name=name, ref=language_id)) |
645 | 872 | if language_id: | 874 | if language_id: |
646 | 873 | books = AlternativeBookNamesDB.run_sql( | 875 | books = AlternativeBookNamesDB.run_sql( |
647 | 874 | 'SELECT book_reference_id, name FROM alternative_book_names WHERE language_id = ?', (language_id, )) | 876 | 'SELECT book_reference_id, name FROM alternative_book_names WHERE language_id = ?', (language_id, )) |
648 | @@ -889,8 +891,8 @@ | |||
649 | 889 | :param book_reference_id: The book_reference_id of the book. | 891 | :param book_reference_id: The book_reference_id of the book. |
650 | 890 | :param language_id: The language to which the alternative book name belong. | 892 | :param language_id: The language to which the alternative book name belong. |
651 | 891 | """ | 893 | """ |
654 | 892 | log.debug('AlternativeBookNamesDB.create_alternative_book_name("%s", "%s", "%s")' % | 894 | log.debug('AlternativeBookNamesDB.create_alternative_book_name("{name}", ' |
655 | 893 | (name, book_reference_id, language_id)) | 895 | '"{ref}", "{lang}")'.format(name=name, ref=book_reference_id, lang=language_id)) |
656 | 894 | return AlternativeBookNamesDB.run_sql( | 896 | return AlternativeBookNamesDB.run_sql( |
657 | 895 | 'INSERT INTO alternative_book_names(book_reference_id, language_id, name) ' | 897 | 'INSERT INTO alternative_book_names(book_reference_id, language_id, name) ' |
658 | 896 | 'VALUES (?, ?, ?)', (book_reference_id, language_id, name), True) | 898 | 'VALUES (?, ?, ?)', (book_reference_id, language_id, name), True) |
659 | 897 | 899 | ||
660 | === modified file 'openlp/plugins/bibles/lib/http.py' | |||
661 | --- openlp/plugins/bibles/lib/http.py 2016-05-06 05:33:43 +0000 | |||
662 | +++ openlp/plugins/bibles/lib/http.py 2016-05-21 08:42:57 +0000 | |||
663 | @@ -90,7 +90,7 @@ | |||
664 | 90 | Extract verses from BibleGateway | 90 | Extract verses from BibleGateway |
665 | 91 | """ | 91 | """ |
666 | 92 | def __init__(self, proxy_url=None): | 92 | def __init__(self, proxy_url=None): |
668 | 93 | log.debug('BGExtract.init("%s")', proxy_url) | 93 | log.debug('BGExtract.init("{url}")'.format(url=proxy_url)) |
669 | 94 | self.proxy_url = proxy_url | 94 | self.proxy_url = proxy_url |
670 | 95 | socket.setdefaulttimeout(30) | 95 | socket.setdefaulttimeout(30) |
671 | 96 | 96 | ||
672 | @@ -188,7 +188,7 @@ | |||
673 | 188 | if len(verse_parts) > 1: | 188 | if len(verse_parts) > 1: |
674 | 189 | verse = int(verse_parts[0]) | 189 | verse = int(verse_parts[0]) |
675 | 190 | except TypeError: | 190 | except TypeError: |
677 | 191 | log.warning('Illegal verse number: %s', str(verse)) | 191 | log.warning('Illegal verse number: {verse:d}'.format(verse=verse)) |
678 | 192 | verses.append((verse, text)) | 192 | verses.append((verse, text)) |
679 | 193 | verse_list = {} | 193 | verse_list = {} |
680 | 194 | for verse, text in verses[::-1]: | 194 | for verse, text in verses[::-1]: |
681 | @@ -221,7 +221,7 @@ | |||
682 | 221 | if len(verse_parts) > 1: | 221 | if len(verse_parts) > 1: |
683 | 222 | clean_verse_num = int(verse_parts[0]) | 222 | clean_verse_num = int(verse_parts[0]) |
684 | 223 | except TypeError: | 223 | except TypeError: |
686 | 224 | log.warning('Illegal verse number: %s', str(raw_verse_num)) | 224 | log.warning('Illegal verse number: {verse:d}'.format(verse=raw_verse_num)) |
687 | 225 | if clean_verse_num: | 225 | if clean_verse_num: |
688 | 226 | verse_text = raw_verse_num.next_element | 226 | verse_text = raw_verse_num.next_element |
689 | 227 | part = raw_verse_num.next_element.next_element | 227 | part = raw_verse_num.next_element.next_element |
690 | @@ -244,11 +244,15 @@ | |||
691 | 244 | :param book_name: Name of the Book. | 244 | :param book_name: Name of the Book. |
692 | 245 | :param chapter: Chapter number. | 245 | :param chapter: Chapter number. |
693 | 246 | """ | 246 | """ |
695 | 247 | log.debug('BGExtract.get_bible_chapter("%s", "%s", "%s")', version, book_name, chapter) | 247 | log.debug('BGExtract.get_bible_chapter("{version}", "{name}", "{chapter}")'.format(version=version, |
696 | 248 | name=book_name, | ||
697 | 249 | chapter=chapter)) | ||
698 | 248 | url_book_name = urllib.parse.quote(book_name.encode("utf-8")) | 250 | url_book_name = urllib.parse.quote(book_name.encode("utf-8")) |
700 | 249 | url_params = 'search=%s+%s&version=%s' % (url_book_name, chapter, version) | 251 | url_params = 'search={name}+{chapter}&version={version}'.format(name=url_book_name, |
701 | 252 | chapter=chapter, | ||
702 | 253 | version=version) | ||
703 | 250 | soup = get_soup_for_bible_ref( | 254 | soup = get_soup_for_bible_ref( |
705 | 251 | 'http://legacy.biblegateway.com/passage/?%s' % url_params, | 255 | 'http://legacy.biblegateway.com/passage/?{url}'.format(url=url_params), |
706 | 252 | pre_parse_regex=r'<meta name.*?/>', pre_parse_substitute='') | 256 | pre_parse_regex=r'<meta name.*?/>', pre_parse_substitute='') |
707 | 253 | if not soup: | 257 | if not soup: |
708 | 254 | return None | 258 | return None |
709 | @@ -257,7 +261,7 @@ | |||
710 | 257 | return None | 261 | return None |
711 | 258 | self._clean_soup(div) | 262 | self._clean_soup(div) |
712 | 259 | span_list = div.find_all('span', 'text') | 263 | span_list = div.find_all('span', 'text') |
714 | 260 | log.debug('Span list: %s', span_list) | 264 | log.debug('Span list: {span}'.format(span=span_list)) |
715 | 261 | if not span_list: | 265 | if not span_list: |
716 | 262 | # If we don't get any spans then we must have the old HTML format | 266 | # If we don't get any spans then we must have the old HTML format |
717 | 263 | verse_list = self._extract_verses_old(div) | 267 | verse_list = self._extract_verses_old(div) |
718 | @@ -275,9 +279,9 @@ | |||
719 | 275 | 279 | ||
720 | 276 | :param version: The version of the Bible like NIV for New International Version | 280 | :param version: The version of the Bible like NIV for New International Version |
721 | 277 | """ | 281 | """ |
725 | 278 | log.debug('BGExtract.get_books_from_http("%s")', version) | 282 | log.debug('BGExtract.get_books_from_http("{version}")'.format(version=version)) |
726 | 279 | url_params = urllib.parse.urlencode({'action': 'getVersionInfo', 'vid': '%s' % version}) | 283 | url_params = urllib.parse.urlencode({'action': 'getVersionInfo', 'vid': '{version}'.format(version=version)}) |
727 | 280 | reference_url = 'http://legacy.biblegateway.com/versions/?%s#books' % url_params | 284 | reference_url = 'http://legacy.biblegateway.com/versions/?{url}#books'.format(url=url_params) |
728 | 281 | page = get_web_page(reference_url) | 285 | page = get_web_page(reference_url) |
729 | 282 | if not page: | 286 | if not page: |
730 | 283 | send_error_message('download') | 287 | send_error_message('download') |
731 | @@ -353,7 +357,7 @@ | |||
732 | 353 | Extract verses from Bibleserver.com | 357 | Extract verses from Bibleserver.com |
733 | 354 | """ | 358 | """ |
734 | 355 | def __init__(self, proxy_url=None): | 359 | def __init__(self, proxy_url=None): |
736 | 356 | log.debug('BSExtract.init("%s")', proxy_url) | 360 | log.debug('BSExtract.init("{url}")'.format(url=proxy_url)) |
737 | 357 | self.proxy_url = proxy_url | 361 | self.proxy_url = proxy_url |
738 | 358 | socket.setdefaulttimeout(30) | 362 | socket.setdefaulttimeout(30) |
739 | 359 | 363 | ||
740 | @@ -365,10 +369,14 @@ | |||
741 | 365 | :param book_name: Text name of bible book e.g. Genesis, 1. John, 1John or Offenbarung | 369 | :param book_name: Text name of bible book e.g. Genesis, 1. John, 1John or Offenbarung |
742 | 366 | :param chapter: Chapter number | 370 | :param chapter: Chapter number |
743 | 367 | """ | 371 | """ |
745 | 368 | log.debug('BSExtract.get_bible_chapter("%s", "%s", "%s")', version, book_name, chapter) | 372 | log.debug('BSExtract.get_bible_chapter("{version}", "{book}", "{chapter}")'.format(version=version, |
746 | 373 | book=book_name, | ||
747 | 374 | chapter=chapter)) | ||
748 | 369 | url_version = urllib.parse.quote(version.encode("utf-8")) | 375 | url_version = urllib.parse.quote(version.encode("utf-8")) |
749 | 370 | url_book_name = urllib.parse.quote(book_name.encode("utf-8")) | 376 | url_book_name = urllib.parse.quote(book_name.encode("utf-8")) |
751 | 371 | chapter_url = 'http://m.bibleserver.com/text/%s/%s%d' % (url_version, url_book_name, chapter) | 377 | chapter_url = 'http://m.bibleserver.com/text/{version}/{name}{chapter:d}'.format(version=url_version, |
752 | 378 | name=url_book_name, | ||
753 | 379 | chapter=chapter) | ||
754 | 372 | header = ('Accept-Language', 'en') | 380 | header = ('Accept-Language', 'en') |
755 | 373 | soup = get_soup_for_bible_ref(chapter_url, header) | 381 | soup = get_soup_for_bible_ref(chapter_url, header) |
756 | 374 | if not soup: | 382 | if not soup: |
757 | @@ -393,9 +401,9 @@ | |||
758 | 393 | 401 | ||
759 | 394 | :param version: The version of the Bible like NIV for New International Version | 402 | :param version: The version of the Bible like NIV for New International Version |
760 | 395 | """ | 403 | """ |
762 | 396 | log.debug('BSExtract.get_books_from_http("%s")', version) | 404 | log.debug('BSExtract.get_books_from_http("{version}")'.format(version=version)) |
763 | 397 | url_version = urllib.parse.quote(version.encode("utf-8")) | 405 | url_version = urllib.parse.quote(version.encode("utf-8")) |
765 | 398 | chapter_url = 'http://m.bibleserver.com/overlay/selectBook?translation=%s' % url_version | 406 | chapter_url = 'http://m.bibleserver.com/overlay/selectBook?translation={version}'.format(version=url_version) |
766 | 399 | soup = get_soup_for_bible_ref(chapter_url) | 407 | soup = get_soup_for_bible_ref(chapter_url) |
767 | 400 | if not soup: | 408 | if not soup: |
768 | 401 | return None | 409 | return None |
769 | @@ -450,7 +458,7 @@ | |||
770 | 450 | Extract verses from CrossWalk/BibleStudyTools | 458 | Extract verses from CrossWalk/BibleStudyTools |
771 | 451 | """ | 459 | """ |
772 | 452 | def __init__(self, proxy_url=None): | 460 | def __init__(self, proxy_url=None): |
774 | 453 | log.debug('CWExtract.init("%s")', proxy_url) | 461 | log.debug('CWExtract.init("{url}")'.format(url=proxy_url)) |
775 | 454 | self.proxy_url = proxy_url | 462 | self.proxy_url = proxy_url |
776 | 455 | socket.setdefaulttimeout(30) | 463 | socket.setdefaulttimeout(30) |
777 | 456 | 464 | ||
778 | @@ -462,11 +470,15 @@ | |||
779 | 462 | :param book_name: Text name of in english e.g. 'gen' for Genesis | 470 | :param book_name: Text name of in english e.g. 'gen' for Genesis |
780 | 463 | :param chapter: Chapter number | 471 | :param chapter: Chapter number |
781 | 464 | """ | 472 | """ |
783 | 465 | log.debug('CWExtract.get_bible_chapter("%s", "%s", "%s")', version, book_name, chapter) | 473 | log.debug('CWExtract.get_bible_chapter("{version}", "{book}", "{chapter}")'.format(version=version, |
784 | 474 | book=book_name, | ||
785 | 475 | chapter=chapter)) | ||
786 | 466 | url_book_name = book_name.replace(' ', '-') | 476 | url_book_name = book_name.replace(' ', '-') |
787 | 467 | url_book_name = url_book_name.lower() | 477 | url_book_name = url_book_name.lower() |
788 | 468 | url_book_name = urllib.parse.quote(url_book_name.encode("utf-8")) | 478 | url_book_name = urllib.parse.quote(url_book_name.encode("utf-8")) |
790 | 469 | chapter_url = 'http://www.biblestudytools.com/%s/%s/%s.html' % (version, url_book_name, chapter) | 479 | chapter_url = 'http://www.biblestudytools.com/{version}/{book}/{chapter}.html'.format(version=version, |
791 | 480 | book=url_book_name, | ||
792 | 481 | chapter=chapter) | ||
793 | 470 | soup = get_soup_for_bible_ref(chapter_url) | 482 | soup = get_soup_for_bible_ref(chapter_url) |
794 | 471 | if not soup: | 483 | if not soup: |
795 | 472 | return None | 484 | return None |
796 | @@ -499,8 +511,8 @@ | |||
797 | 499 | 511 | ||
798 | 500 | :param version: The version of the bible like NIV for New International Version | 512 | :param version: The version of the bible like NIV for New International Version |
799 | 501 | """ | 513 | """ |
802 | 502 | log.debug('CWExtract.get_books_from_http("%s")', version) | 514 | log.debug('CWExtract.get_books_from_http("{version}")'.format(version=version)) |
803 | 503 | chapter_url = 'http://www.biblestudytools.com/%s/' % version | 515 | chapter_url = 'http://www.biblestudytools.com/{version}/'.format(version=version) |
804 | 504 | soup = get_soup_for_bible_ref(chapter_url) | 516 | soup = get_soup_for_bible_ref(chapter_url) |
805 | 505 | if not soup: | 517 | if not soup: |
806 | 506 | return None | 518 | return None |
807 | @@ -559,7 +571,7 @@ | |||
808 | 559 | 571 | ||
809 | 560 | 572 | ||
810 | 561 | class HTTPBible(BibleDB, RegistryProperties): | 573 | class HTTPBible(BibleDB, RegistryProperties): |
812 | 562 | log.info('%s HTTPBible loaded', __name__) | 574 | log.info('{name} HTTPBible loaded'.format(name=__name__)) |
813 | 563 | 575 | ||
814 | 564 | def __init__(self, parent, **kwargs): | 576 | def __init__(self, parent, **kwargs): |
815 | 565 | """ | 577 | """ |
816 | @@ -615,8 +627,8 @@ | |||
817 | 615 | handler = BSExtract(self.proxy_server) | 627 | handler = BSExtract(self.proxy_server) |
818 | 616 | books = handler.get_books_from_http(self.download_name) | 628 | books = handler.get_books_from_http(self.download_name) |
819 | 617 | if not books: | 629 | if not books: |
822 | 618 | log.error('Importing books from %s - download name: "%s" failed' % | 630 | log.error('Importing books from {source} - download name: "{name}" ' |
823 | 619 | (self.download_source, self.download_name)) | 631 | 'failed'.format(source=self.download_source, name=self.download_name)) |
824 | 620 | return False | 632 | return False |
825 | 621 | self.wizard.progress_bar.setMaximum(len(books) + 2) | 633 | self.wizard.progress_bar.setMaximum(len(books) + 2) |
826 | 622 | self.wizard.increment_progress_bar(translate('BiblesPlugin.HTTPBible', 'Registering Language...')) | 634 | self.wizard.increment_progress_bar(translate('BiblesPlugin.HTTPBible', 'Registering Language...')) |
827 | @@ -625,21 +637,24 @@ | |||
828 | 625 | else: | 637 | else: |
829 | 626 | self.language_id = self.get_language(bible_name) | 638 | self.language_id = self.get_language(bible_name) |
830 | 627 | if not self.language_id: | 639 | if not self.language_id: |
832 | 628 | log.error('Importing books from %s failed' % self.filename) | 640 | log.error('Importing books from {name} failed'.format(name=self.filename)) |
833 | 629 | return False | 641 | return False |
834 | 630 | for book in books: | 642 | for book in books: |
835 | 631 | if self.stop_import_flag: | 643 | if self.stop_import_flag: |
836 | 632 | break | 644 | break |
839 | 633 | self.wizard.increment_progress_bar(translate( | 645 | self.wizard.increment_progress_bar(translate('BiblesPlugin.HTTPBible', |
840 | 634 | 'BiblesPlugin.HTTPBible', 'Importing %s...', 'Importing <book name>...') % book) | 646 | 'Importing {book}...', |
841 | 647 | 'Importing <book name>...').format(book=book)) | ||
842 | 635 | book_ref_id = self.get_book_ref_id_by_name(book, len(books), self.language_id) | 648 | book_ref_id = self.get_book_ref_id_by_name(book, len(books), self.language_id) |
843 | 636 | if not book_ref_id: | 649 | if not book_ref_id: |
846 | 637 | log.error('Importing books from %s - download name: "%s" failed' % | 650 | log.error('Importing books from {source} - download name: "{name}" ' |
847 | 638 | (self.download_source, self.download_name)) | 651 | 'failed'.format(source=self.download_source, name=self.download_name)) |
848 | 639 | return False | 652 | return False |
849 | 640 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) | 653 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) |
852 | 641 | log.debug('Book details: Name:%s; id:%s; testament_id:%s', | 654 | log.debug('Book details: Name:{book}; id:{ref}; ' |
853 | 642 | book, book_ref_id, book_details['testament_id']) | 655 | 'testament_id:{detail}'.format(book=book, |
854 | 656 | ref=book_ref_id, | ||
855 | 657 | detail=book_details['testament_id'])) | ||
856 | 643 | self.create_book(book, book_ref_id, book_details['testament_id']) | 658 | self.create_book(book, book_ref_id, book_details['testament_id']) |
857 | 644 | if self.stop_import_flag: | 659 | if self.stop_import_flag: |
858 | 645 | return False | 660 | return False |
859 | @@ -664,7 +679,7 @@ | |||
860 | 664 | 679 | ||
861 | 665 | [('35', 1, 1, 1), ('35', 2, 2, 3)] | 680 | [('35', 1, 1, 1), ('35', 2, 2, 3)] |
862 | 666 | """ | 681 | """ |
864 | 667 | log.debug('HTTPBible.get_verses("%s")', reference_list) | 682 | log.debug('HTTPBible.get_verses("{ref}")'.format(ref=reference_list)) |
865 | 668 | for reference in reference_list: | 683 | for reference in reference_list: |
866 | 669 | book_id = reference[0] | 684 | book_id = reference[0] |
867 | 670 | db_book = self.get_book_by_book_ref_id(book_id) | 685 | db_book = self.get_book_by_book_ref_id(book_id) |
868 | @@ -698,8 +713,8 @@ | |||
869 | 698 | """ | 713 | """ |
870 | 699 | Receive the request and call the relevant handler methods. | 714 | Receive the request and call the relevant handler methods. |
871 | 700 | """ | 715 | """ |
874 | 701 | log.debug('HTTPBible.get_chapter("%s", "%s")', book, chapter) | 716 | log.debug('HTTPBible.get_chapter("{book}", "{chapter}")'.format(book=book, chapter=chapter)) |
875 | 702 | log.debug('source = %s', self.download_source) | 717 | log.debug('source = {source}'.format(source=self.download_source)) |
876 | 703 | if self.download_source.lower() == 'crosswalk': | 718 | if self.download_source.lower() == 'crosswalk': |
877 | 704 | handler = CWExtract(self.proxy_server) | 719 | handler = CWExtract(self.proxy_server) |
878 | 705 | elif self.download_source.lower() == 'biblegateway': | 720 | elif self.download_source.lower() == 'biblegateway': |
879 | @@ -712,7 +727,7 @@ | |||
880 | 712 | """ | 727 | """ |
881 | 713 | Return the list of books. | 728 | Return the list of books. |
882 | 714 | """ | 729 | """ |
884 | 715 | log.debug('HTTPBible.get_books("%s")', Book.name) | 730 | log.debug('HTTPBible.get_books("{name}")'.format(name=Book.name)) |
885 | 716 | return self.get_all_objects(Book, order_by_ref=Book.id) | 731 | return self.get_all_objects(Book, order_by_ref=Book.id) |
886 | 717 | 732 | ||
887 | 718 | def get_chapter_count(self, book): | 733 | def get_chapter_count(self, book): |
888 | @@ -721,7 +736,7 @@ | |||
889 | 721 | 736 | ||
890 | 722 | :param book: The book object to get the chapter count for. | 737 | :param book: The book object to get the chapter count for. |
891 | 723 | """ | 738 | """ |
893 | 724 | log.debug('HTTPBible.get_chapter_count("%s")', book.name) | 739 | log.debug('HTTPBible.get_chapter_count("{name}")'.format(name=book.name)) |
894 | 725 | return BiblesResourcesDB.get_chapter_count(book.book_reference_id) | 740 | return BiblesResourcesDB.get_chapter_count(book.book_reference_id) |
895 | 726 | 741 | ||
896 | 727 | def get_verse_count(self, book_id, chapter): | 742 | def get_verse_count(self, book_id, chapter): |
897 | @@ -731,7 +746,7 @@ | |||
898 | 731 | :param book_id: The name of the book. | 746 | :param book_id: The name of the book. |
899 | 732 | :param chapter: The chapter whose verses are being counted. | 747 | :param chapter: The chapter whose verses are being counted. |
900 | 733 | """ | 748 | """ |
902 | 734 | log.debug('HTTPBible.get_verse_count("%s", %s)', book_id, chapter) | 749 | log.debug('HTTPBible.get_verse_count("{ref}", {chapter})'.format(ref=book_id, chapter=chapter)) |
903 | 735 | return BiblesResourcesDB.get_verse_count(book_id, chapter) | 750 | return BiblesResourcesDB.get_verse_count(book_id, chapter) |
904 | 736 | 751 | ||
905 | 737 | 752 | ||
906 | 738 | 753 | ||
907 | === modified file 'openlp/plugins/bibles/lib/manager.py' | |||
908 | --- openlp/plugins/bibles/lib/manager.py 2016-04-12 20:05:58 +0000 | |||
909 | +++ openlp/plugins/bibles/lib/manager.py 2016-05-21 08:42:57 +0000 | |||
910 | @@ -122,7 +122,7 @@ | |||
911 | 122 | files = AppLocation.get_files(self.settings_section, self.suffix) | 122 | files = AppLocation.get_files(self.settings_section, self.suffix) |
912 | 123 | if 'alternative_book_names.sqlite' in files: | 123 | if 'alternative_book_names.sqlite' in files: |
913 | 124 | files.remove('alternative_book_names.sqlite') | 124 | files.remove('alternative_book_names.sqlite') |
915 | 125 | log.debug('Bible Files %s', files) | 125 | log.debug('Bible Files {text}'.format(text=files)) |
916 | 126 | self.db_cache = {} | 126 | self.db_cache = {} |
917 | 127 | self.old_bible_databases = [] | 127 | self.old_bible_databases = [] |
918 | 128 | for filename in files: | 128 | for filename in files: |
919 | @@ -135,7 +135,7 @@ | |||
920 | 135 | bible.session.close() | 135 | bible.session.close() |
921 | 136 | delete_file(os.path.join(self.path, filename)) | 136 | delete_file(os.path.join(self.path, filename)) |
922 | 137 | continue | 137 | continue |
924 | 138 | log.debug('Bible Name: "%s"', name) | 138 | log.debug('Bible Name: "{name}"'.format(name=name)) |
925 | 139 | self.db_cache[name] = bible | 139 | self.db_cache[name] = bible |
926 | 140 | # Look to see if lazy load bible exists and get create getter. | 140 | # Look to see if lazy load bible exists and get create getter. |
927 | 141 | source = self.db_cache[name].get_object(BibleMeta, 'download_source') | 141 | source = self.db_cache[name].get_object(BibleMeta, 'download_source') |
928 | @@ -177,7 +177,7 @@ | |||
929 | 177 | 177 | ||
930 | 178 | :param name: The name of the bible. | 178 | :param name: The name of the bible. |
931 | 179 | """ | 179 | """ |
933 | 180 | log.debug('BibleManager.delete_bible("%s")', name) | 180 | log.debug('BibleManager.delete_bible("{name}")'.format(name=name)) |
934 | 181 | bible = self.db_cache[name] | 181 | bible = self.db_cache[name] |
935 | 182 | bible.session.close() | 182 | bible.session.close() |
936 | 183 | bible.session = None | 183 | bible.session = None |
937 | @@ -196,7 +196,7 @@ | |||
938 | 196 | 196 | ||
939 | 197 | :param bible: Unicode. The Bible to get the list of books from. | 197 | :param bible: Unicode. The Bible to get the list of books from. |
940 | 198 | """ | 198 | """ |
942 | 199 | log.debug('BibleManager.get_books("%s")', bible) | 199 | log.debug('BibleManager.get_books("{bible}")'.format(bible=bible)) |
943 | 200 | return [ | 200 | return [ |
944 | 201 | { | 201 | { |
945 | 202 | 'name': book.name, | 202 | 'name': book.name, |
946 | @@ -213,7 +213,7 @@ | |||
947 | 213 | :param bible: Unicode. The Bible to get the list of books from. | 213 | :param bible: Unicode. The Bible to get the list of books from. |
948 | 214 | :param id: Unicode. The book_reference_id to get the book for. | 214 | :param id: Unicode. The book_reference_id to get the book for. |
949 | 215 | """ | 215 | """ |
951 | 216 | log.debug('BibleManager.get_book_by_id("%s", "%s")', bible, id) | 216 | log.debug('BibleManager.get_book_by_id("{bible}", "{ref}")'.format(bible=bible, ref=id)) |
952 | 217 | return self.db_cache[bible].get_book_by_book_ref_id(id) | 217 | return self.db_cache[bible].get_book_by_book_ref_id(id) |
953 | 218 | 218 | ||
954 | 219 | def get_chapter_count(self, bible, book): | 219 | def get_chapter_count(self, bible, book): |
955 | @@ -223,14 +223,16 @@ | |||
956 | 223 | :param bible: Unicode. The Bible to get the list of books from. | 223 | :param bible: Unicode. The Bible to get the list of books from. |
957 | 224 | :param book: The book object to get the chapter count for. | 224 | :param book: The book object to get the chapter count for. |
958 | 225 | """ | 225 | """ |
960 | 226 | log.debug('BibleManager.get_book_chapter_count ("%s", "%s")', bible, book.name) | 226 | log.debug('BibleManager.get_book_chapter_count ("{bible}", "{name}")'.format(bible=bible, name=book.name)) |
961 | 227 | return self.db_cache[bible].get_chapter_count(book) | 227 | return self.db_cache[bible].get_chapter_count(book) |
962 | 228 | 228 | ||
963 | 229 | def get_verse_count(self, bible, book, chapter): | 229 | def get_verse_count(self, bible, book, chapter): |
964 | 230 | """ | 230 | """ |
965 | 231 | Returns all the number of verses for a given book and chapterMaxBibleBookVerses. | 231 | Returns all the number of verses for a given book and chapterMaxBibleBookVerses. |
966 | 232 | """ | 232 | """ |
968 | 233 | log.debug('BibleManager.get_verse_count("%s", "%s", %s)', bible, book, chapter) | 233 | log.debug('BibleManager.get_verse_count("{bible}", "{book}", {chapter})'.format(bible=bible, |
969 | 234 | book=book, | ||
970 | 235 | chapter=chapter)) | ||
971 | 234 | language_selection = self.get_language_selection(bible) | 236 | language_selection = self.get_language_selection(bible) |
972 | 235 | book_ref_id = self.db_cache[bible].get_book_ref_id_by_localised_name(book, language_selection) | 237 | book_ref_id = self.db_cache[bible].get_book_ref_id_by_localised_name(book, language_selection) |
973 | 236 | return self.db_cache[bible].get_verse_count(book_ref_id, chapter) | 238 | return self.db_cache[bible].get_verse_count(book_ref_id, chapter) |
974 | @@ -240,7 +242,8 @@ | |||
975 | 240 | Returns all the number of verses for a given | 242 | Returns all the number of verses for a given |
976 | 241 | book_ref_id and chapterMaxBibleBookVerses. | 243 | book_ref_id and chapterMaxBibleBookVerses. |
977 | 242 | """ | 244 | """ |
979 | 243 | log.debug('BibleManager.get_verse_count_by_book_ref_id("%s", "%s", "%s")', bible, book_ref_id, chapter) | 245 | log.debug('BibleManager.get_verse_count_by_book_ref_id("{bible}", ' |
980 | 246 | '"{book}", "{chapter}")'.format(bible=bible, book=book_ref_id, chapter=chapter)) | ||
981 | 244 | return self.db_cache[bible].get_verse_count(book_ref_id, chapter) | 247 | return self.db_cache[bible].get_verse_count(book_ref_id, chapter) |
982 | 245 | 248 | ||
983 | 246 | def get_verses(self, bible, verse_text, book_ref_id=False, show_error=True): | 249 | def get_verses(self, bible, verse_text, book_ref_id=False, show_error=True): |
984 | @@ -264,7 +267,7 @@ | |||
985 | 264 | For second bible this is necessary. | 267 | For second bible this is necessary. |
986 | 265 | :param show_error: | 268 | :param show_error: |
987 | 266 | """ | 269 | """ |
989 | 267 | log.debug('BibleManager.get_verses("%s", "%s")', bible, verse_text) | 270 | log.debug('BibleManager.get_verses("{bible}", "{verse}")'.format(bible=bible, verse=verse_text)) |
990 | 268 | if not bible: | 271 | if not bible: |
991 | 269 | if show_error: | 272 | if show_error: |
992 | 270 | self.main_window.information_message( | 273 | self.main_window.information_message( |
993 | @@ -308,7 +311,7 @@ | |||
994 | 308 | 311 | ||
995 | 309 | :param bible: Unicode. The Bible to get the language selection from. | 312 | :param bible: Unicode. The Bible to get the language selection from. |
996 | 310 | """ | 313 | """ |
998 | 311 | log.debug('BibleManager.get_language_selection("%s")', bible) | 314 | log.debug('BibleManager.get_language_selection("{bible}")'.format(bible=bible)) |
999 | 312 | language_selection = self.get_meta_data(bible, 'book_name_language') | 315 | language_selection = self.get_meta_data(bible, 'book_name_language') |
1000 | 313 | if not language_selection or language_selection.value == "None" or language_selection.value == "-1": | 316 | if not language_selection or language_selection.value == "None" or language_selection.value == "-1": |
1001 | 314 | # If None is returned, it's not the singleton object but a | 317 | # If None is returned, it's not the singleton object but a |
1002 | @@ -330,7 +333,7 @@ | |||
1003 | 330 | :param second_bible: The second bible (unicode). We do not search in this bible. | 333 | :param second_bible: The second bible (unicode). We do not search in this bible. |
1004 | 331 | :param text: The text to search for (unicode). | 334 | :param text: The text to search for (unicode). |
1005 | 332 | """ | 335 | """ |
1007 | 333 | log.debug('BibleManager.verse_search("%s", "%s")', bible, text) | 336 | log.debug('BibleManager.verse_search("{bible}", "{text}")'.format(bible=bible, text=text)) |
1008 | 334 | if not bible: | 337 | if not bible: |
1009 | 335 | self.main_window.information_message( | 338 | self.main_window.information_message( |
1010 | 336 | translate('BiblesPlugin.BibleManager', 'No Bibles Available'), | 339 | translate('BiblesPlugin.BibleManager', 'No Bibles Available'), |
1011 | @@ -365,7 +368,10 @@ | |||
1012 | 365 | """ | 368 | """ |
1013 | 366 | Saves the bibles meta data. | 369 | Saves the bibles meta data. |
1014 | 367 | """ | 370 | """ |
1016 | 368 | log.debug('save_meta data %s, %s, %s, %s', bible, version, copyright, permissions) | 371 | log.debug('save_meta data {bible}, {version}, {copyright}, {perms}'.format(bible=bible, |
1017 | 372 | version=version, | ||
1018 | 373 | cr=copyright, | ||
1019 | 374 | perms=permissions)) | ||
1020 | 369 | self.db_cache[bible].save_meta('name', version) | 375 | self.db_cache[bible].save_meta('name', version) |
1021 | 370 | self.db_cache[bible].save_meta('copyright', copyright) | 376 | self.db_cache[bible].save_meta('copyright', copyright) |
1022 | 371 | self.db_cache[bible].save_meta('permissions', permissions) | 377 | self.db_cache[bible].save_meta('permissions', permissions) |
1023 | @@ -375,14 +381,14 @@ | |||
1024 | 375 | """ | 381 | """ |
1025 | 376 | Returns the meta data for a given key. | 382 | Returns the meta data for a given key. |
1026 | 377 | """ | 383 | """ |
1028 | 378 | log.debug('get_meta %s,%s', bible, key) | 384 | log.debug('get_meta {bible},{key}'.format(bible=bible, key=key)) |
1029 | 379 | return self.db_cache[bible].get_object(BibleMeta, key) | 385 | return self.db_cache[bible].get_object(BibleMeta, key) |
1030 | 380 | 386 | ||
1031 | 381 | def update_book(self, bible, book): | 387 | def update_book(self, bible, book): |
1032 | 382 | """ | 388 | """ |
1033 | 383 | Update a book of the bible. | 389 | Update a book of the bible. |
1034 | 384 | """ | 390 | """ |
1036 | 385 | log.debug('BibleManager.update_book("%s", "%s")', bible, book.name) | 391 | log.debug('BibleManager.update_book("{bible}", "{name}")'.format(bible=bible, name=book.name)) |
1037 | 386 | self.db_cache[bible].update_book(book) | 392 | self.db_cache[bible].update_book(book) |
1038 | 387 | 393 | ||
1039 | 388 | def exists(self, name): | 394 | def exists(self, name): |
1040 | @@ -392,7 +398,7 @@ | |||
1041 | 392 | if not isinstance(name, str): | 398 | if not isinstance(name, str): |
1042 | 393 | name = str(name) | 399 | name = str(name) |
1043 | 394 | for bible in list(self.db_cache.keys()): | 400 | for bible in list(self.db_cache.keys()): |
1045 | 395 | log.debug('Bible from cache in is_new_bible %s', bible) | 401 | log.debug('Bible from cache in is_new_bible {bible}'.format(bible=bible)) |
1046 | 396 | if not isinstance(bible, str): | 402 | if not isinstance(bible, str): |
1047 | 397 | bible = str(bible) | 403 | bible = str(bible) |
1048 | 398 | if bible == name: | 404 | if bible == name: |
1049 | 399 | 405 | ||
1050 | === modified file 'openlp/plugins/bibles/lib/mediaitem.py' | |||
1051 | --- openlp/plugins/bibles/lib/mediaitem.py 2016-04-10 20:24:07 +0000 | |||
1052 | +++ openlp/plugins/bibles/lib/mediaitem.py 2016-05-21 08:42:57 +0000 | |||
1053 | @@ -280,7 +280,7 @@ | |||
1054 | 280 | def retranslateUi(self): | 280 | def retranslateUi(self): |
1055 | 281 | log.debug('retranslateUi') | 281 | log.debug('retranslateUi') |
1056 | 282 | self.quick_search_label.setText(translate('BiblesPlugin.MediaItem', 'Find:')) | 282 | self.quick_search_label.setText(translate('BiblesPlugin.MediaItem', 'Find:')) |
1058 | 283 | self.quickVersionLabel.setText('%s:' % UiStrings().Version) | 283 | self.quickVersionLabel.setText('{version}:'.format(version=UiStrings().Version)) |
1059 | 284 | self.quickSecondLabel.setText(translate('BiblesPlugin.MediaItem', 'Second:')) | 284 | self.quickSecondLabel.setText(translate('BiblesPlugin.MediaItem', 'Second:')) |
1060 | 285 | self.quickStyleLabel.setText(UiStrings().LayoutStyle) | 285 | self.quickStyleLabel.setText(UiStrings().LayoutStyle) |
1061 | 286 | self.quickStyleComboBox.setItemText(LayoutStyle.VersePerSlide, UiStrings().VersePerSlide) | 286 | self.quickStyleComboBox.setItemText(LayoutStyle.VersePerSlide, UiStrings().VersePerSlide) |
1062 | @@ -294,7 +294,7 @@ | |||
1063 | 294 | self.advanced_verse_label.setText(translate('BiblesPlugin.MediaItem', 'Verse:')) | 294 | self.advanced_verse_label.setText(translate('BiblesPlugin.MediaItem', 'Verse:')) |
1064 | 295 | self.advanced_from_label.setText(translate('BiblesPlugin.MediaItem', 'From:')) | 295 | self.advanced_from_label.setText(translate('BiblesPlugin.MediaItem', 'From:')) |
1065 | 296 | self.advanced_to_label.setText(translate('BiblesPlugin.MediaItem', 'To:')) | 296 | self.advanced_to_label.setText(translate('BiblesPlugin.MediaItem', 'To:')) |
1067 | 297 | self.advancedVersionLabel.setText('%s:' % UiStrings().Version) | 297 | self.advancedVersionLabel.setText('{version}:'.format(version=UiStrings().Version)) |
1068 | 298 | self.advancedSecondLabel.setText(translate('BiblesPlugin.MediaItem', 'Second:')) | 298 | self.advancedSecondLabel.setText(translate('BiblesPlugin.MediaItem', 'Second:')) |
1069 | 299 | self.advancedStyleLabel.setText(UiStrings().LayoutStyle) | 299 | self.advancedStyleLabel.setText(UiStrings().LayoutStyle) |
1070 | 300 | self.advancedStyleComboBox.setItemText(LayoutStyle.VersePerSlide, UiStrings().VersePerSlide) | 300 | self.advancedStyleComboBox.setItemText(LayoutStyle.VersePerSlide, UiStrings().VersePerSlide) |
1071 | @@ -316,7 +316,8 @@ | |||
1072 | 316 | translate('BiblesPlugin.MediaItem', 'Text Search'), | 316 | translate('BiblesPlugin.MediaItem', 'Text Search'), |
1073 | 317 | translate('BiblesPlugin.MediaItem', 'Search Text...')) | 317 | translate('BiblesPlugin.MediaItem', 'Search Text...')) |
1074 | 318 | ]) | 318 | ]) |
1076 | 319 | self.quick_search_edit.set_current_search_type(Settings().value('%s/last search type' % self.settings_section)) | 319 | text = self.settings_section |
1077 | 320 | self.quick_search_edit.set_current_search_type(Settings().value('{text}/last search type'.format(text=text))) | ||
1078 | 320 | self.config_update() | 321 | self.config_update() |
1079 | 321 | log.debug('bible manager initialise complete') | 322 | log.debug('bible manager initialise complete') |
1080 | 322 | 323 | ||
1081 | @@ -364,7 +365,7 @@ | |||
1082 | 364 | :param bible: The bible to initialise (unicode). | 365 | :param bible: The bible to initialise (unicode). |
1083 | 365 | :param last_book_id: The "book reference id" of the book which is chosen at the moment. (int) | 366 | :param last_book_id: The "book reference id" of the book which is chosen at the moment. (int) |
1084 | 366 | """ | 367 | """ |
1086 | 367 | log.debug('initialise_advanced_bible %s, %s', bible, last_book_id) | 368 | log.debug('initialise_advanced_bible {bible}, {ref}'.format(bible=bible, ref=last_book_id)) |
1087 | 368 | book_data = self.plugin.manager.get_books(bible) | 369 | book_data = self.plugin.manager.get_books(bible) |
1088 | 369 | second_bible = self.advancedSecondComboBox.currentText() | 370 | second_bible = self.advancedSecondComboBox.currentText() |
1089 | 370 | if second_bible != '': | 371 | if second_bible != '': |
1090 | @@ -406,7 +407,7 @@ | |||
1091 | 406 | self.initialise_chapter_verse(bible, first_book['name'], first_book['book_reference_id']) | 407 | self.initialise_chapter_verse(bible, first_book['name'], first_book['book_reference_id']) |
1092 | 407 | 408 | ||
1093 | 408 | def initialise_chapter_verse(self, bible, book, book_ref_id): | 409 | def initialise_chapter_verse(self, bible, book, book_ref_id): |
1095 | 409 | log.debug('initialise_chapter_verse %s, %s, %s', bible, book, book_ref_id) | 410 | log.debug('initialise_chapter_verse {bible}, {book), {ref}'.format(bible=bible, book=book, ref=book_ref_id)) |
1096 | 410 | book = self.plugin.manager.get_book_by_id(bible, book_ref_id) | 411 | book = self.plugin.manager.get_book_by_id(bible, book_ref_id) |
1097 | 411 | self.chapter_count = self.plugin.manager.get_chapter_count(bible, book) | 412 | self.chapter_count = self.plugin.manager.get_chapter_count(bible, book) |
1098 | 412 | verse_count = self.plugin.manager.get_verse_count_by_book_ref_id(bible, book_ref_id, 1) | 413 | verse_count = self.plugin.manager.get_verse_count_by_book_ref_id(bible, book_ref_id, 1) |
1099 | @@ -427,9 +428,11 @@ | |||
1100 | 427 | """ | 428 | """ |
1101 | 428 | log.debug('update_auto_completer') | 429 | log.debug('update_auto_completer') |
1102 | 429 | # Save the current search type to the configuration. | 430 | # Save the current search type to the configuration. |
1104 | 430 | Settings().setValue('%s/last search type' % self.settings_section, self.quick_search_edit.current_search_type()) | 431 | Settings().setValue('{section}/last search type'.format(section=self.settings_section), |
1105 | 432 | self.quick_search_edit.current_search_type()) | ||
1106 | 431 | # Save the current bible to the configuration. | 433 | # Save the current bible to the configuration. |
1108 | 432 | Settings().setValue(self.settings_section + '/quick bible', self.quickVersionComboBox.currentText()) | 434 | Settings().setValue('{section}/quick bible'.format(section=self.settings_section), |
1109 | 435 | self.quickVersionComboBox.currentText()) | ||
1110 | 433 | books = [] | 436 | books = [] |
1111 | 434 | # We have to do a 'Reference Search'. | 437 | # We have to do a 'Reference Search'. |
1112 | 435 | if self.quick_search_edit.current_search_type() == BibleSearch.Reference: | 438 | if self.quick_search_edit.current_search_type() == BibleSearch.Reference: |
1113 | @@ -502,9 +505,10 @@ | |||
1114 | 502 | if bible: | 505 | if bible: |
1115 | 503 | if QtWidgets.QMessageBox.question( | 506 | if QtWidgets.QMessageBox.question( |
1116 | 504 | self, UiStrings().ConfirmDelete, | 507 | self, UiStrings().ConfirmDelete, |
1120 | 505 | translate('BiblesPlugin.MediaItem', 'Are you sure you want to completely delete "%s" Bible from ' | 508 | translate('BiblesPlugin.MediaItem', |
1121 | 506 | 'OpenLP?\n\nYou will need to re-import this Bible to use it ' | 509 | 'Are you sure you want to completely delete "{bible}" Bible ' |
1122 | 507 | 'again.') % bible, | 510 | 'from OpenLP?\n\nYou will need to re-import this Bible to use it ' |
1123 | 511 | 'again.').format(bible=bible), | ||
1124 | 508 | QtWidgets.QMessageBox.StandardButtons(QtWidgets.QMessageBox.Yes | QtWidgets.QMessageBox.No), | 512 | QtWidgets.QMessageBox.StandardButtons(QtWidgets.QMessageBox.Yes | QtWidgets.QMessageBox.No), |
1125 | 509 | QtWidgets.QMessageBox.Yes) == QtWidgets.QMessageBox.No: | 513 | QtWidgets.QMessageBox.Yes) == QtWidgets.QMessageBox.No: |
1126 | 510 | return | 514 | return |
1127 | @@ -606,7 +610,7 @@ | |||
1128 | 606 | :param combo: The combo box itself (QComboBox). | 610 | :param combo: The combo box itself (QComboBox). |
1129 | 607 | :param restore: If True, then the combo's currentText will be restored after adjusting (if possible). | 611 | :param restore: If True, then the combo's currentText will be restored after adjusting (if possible). |
1130 | 608 | """ | 612 | """ |
1132 | 609 | log.debug('adjust_combo_box %s, %s, %s', combo, range_from, range_to) | 613 | log.debug('adjust_combo_box {box}, {start}, {end}'.format(box=combo, start=range_from, end=range_to)) |
1133 | 610 | if restore: | 614 | if restore: |
1134 | 611 | old_text = combo.currentText() | 615 | old_text = combo.currentText() |
1135 | 612 | combo.clear() | 616 | combo.clear() |
1136 | @@ -633,7 +637,7 @@ | |||
1137 | 633 | range_separator = get_reference_separator('sep_r_display') | 637 | range_separator = get_reference_separator('sep_r_display') |
1138 | 634 | verse_range = chapter_from + verse_separator + verse_from + range_separator + chapter_to + \ | 638 | verse_range = chapter_from + verse_separator + verse_from + range_separator + chapter_to + \ |
1139 | 635 | verse_separator + verse_to | 639 | verse_separator + verse_to |
1141 | 636 | verse_text = '%s %s' % (book, verse_range) | 640 | verse_text = '{book} {verse}'.format(book=book, verse=verse_range) |
1142 | 637 | self.application.set_busy_cursor() | 641 | self.application.set_busy_cursor() |
1143 | 638 | self.search_results = self.plugin.manager.get_verses(bible, verse_text, book_ref_id) | 642 | self.search_results = self.plugin.manager.get_verses(bible, verse_text, book_ref_id) |
1144 | 639 | if second_bible: | 643 | if second_bible: |
1145 | @@ -678,8 +682,8 @@ | |||
1146 | 678 | for verse in self.search_results: | 682 | for verse in self.search_results: |
1147 | 679 | db_book = bibles[second_bible].get_book_by_book_ref_id(verse.book.book_reference_id) | 683 | db_book = bibles[second_bible].get_book_by_book_ref_id(verse.book.book_reference_id) |
1148 | 680 | if not db_book: | 684 | if not db_book: |
1151 | 681 | log.debug('Passage "%s %d:%d" not found in Second Bible' % | 685 | log.debug('Passage "{name} {chapter:d}:{verse:d}" not found in ' |
1152 | 682 | (verse.book.name, verse.chapter, verse.verse)) | 686 | 'Second Bible'.format(name=verse.book.name, chapter=verse.chapter, verse=verse.verse)) |
1153 | 683 | passage_not_found = True | 687 | passage_not_found = True |
1154 | 684 | count += 1 | 688 | count += 1 |
1155 | 685 | continue | 689 | continue |
1156 | @@ -688,9 +692,10 @@ | |||
1157 | 688 | if passage_not_found: | 692 | if passage_not_found: |
1158 | 689 | QtWidgets.QMessageBox.information( | 693 | QtWidgets.QMessageBox.information( |
1159 | 690 | self, translate('BiblesPlugin.MediaItem', 'Information'), | 694 | self, translate('BiblesPlugin.MediaItem', 'Information'), |
1163 | 691 | translate('BiblesPlugin.MediaItem', 'The second Bible does not contain all the verses ' | 695 | translate('BiblesPlugin.MediaItem', |
1164 | 692 | 'that are in the main Bible. Only verses found in both Bibles will be shown. %d ' | 696 | 'The second Bible does not contain all the verses that are in the main Bible. ' |
1165 | 693 | 'verses have not been included in the results.') % count, | 697 | 'Only verses found in both Bibles will be shown. {count:d} verses have not been ' |
1166 | 698 | 'included in the results.').format(count=count), | ||
1167 | 694 | QtWidgets.QMessageBox.StandardButtons(QtWidgets.QMessageBox.Ok)) | 699 | QtWidgets.QMessageBox.StandardButtons(QtWidgets.QMessageBox.Ok)) |
1168 | 695 | self.search_results = new_search_results | 700 | self.search_results = new_search_results |
1169 | 696 | self.second_search_results = bibles[second_bible].get_verses(text) | 701 | self.second_search_results = bibles[second_bible].get_verses(text) |
1170 | @@ -767,10 +772,19 @@ | |||
1171 | 767 | except TypeError: | 772 | except TypeError: |
1172 | 768 | log.exception('The second_search_results does not have this book.') | 773 | log.exception('The second_search_results does not have this book.') |
1173 | 769 | break | 774 | break |
1176 | 770 | bible_text = '%s %d%s%d (%s, %s)' % (book, verse.chapter, verse_separator, verse.verse, version, | 775 | bible_text = ('{book} {chapter:d}{sep}{verse:d} ' |
1177 | 771 | second_version) | 776 | '({version1}, {version2})').format(book=book, |
1178 | 777 | chapter=verse.chapter, | ||
1179 | 778 | sep=verse_separator, | ||
1180 | 779 | verse=verse.verse, | ||
1181 | 780 | version1=version, | ||
1182 | 781 | version2=second_version) | ||
1183 | 772 | else: | 782 | else: |
1185 | 773 | bible_text = '%s %d%s%d (%s)' % (book, verse.chapter, verse_separator, verse.verse, version) | 783 | bible_text = '{book} {chapter:d}{sep}{verse:d} ({version})'.format(book=book, |
1186 | 784 | chapter=verse.chapter, | ||
1187 | 785 | sep=verse_separator, | ||
1188 | 786 | verse=verse.verse, | ||
1189 | 787 | version=version) | ||
1190 | 774 | bible_verse = QtWidgets.QListWidgetItem(bible_text) | 788 | bible_verse = QtWidgets.QListWidgetItem(bible_text) |
1191 | 775 | bible_verse.setData(QtCore.Qt.UserRole, data) | 789 | bible_verse.setData(QtCore.Qt.UserRole, data) |
1192 | 776 | items.append(bible_verse) | 790 | items.append(bible_verse) |
1193 | @@ -817,20 +831,22 @@ | |||
1194 | 817 | verses.add(book, chapter, verse, version, copyright, permissions) | 831 | verses.add(book, chapter, verse, version, copyright, permissions) |
1195 | 818 | verse_text = self.format_verse(old_chapter, chapter, verse) | 832 | verse_text = self.format_verse(old_chapter, chapter, verse) |
1196 | 819 | if second_bible: | 833 | if second_bible: |
1198 | 820 | bible_text = '%s%s\n\n%s %s' % (verse_text, text, verse_text, second_text) | 834 | bible_text = '{verse}{text1}\n\n{verse} {text2}'.format(verse=verse_text, |
1199 | 835 | text1=text, | ||
1200 | 836 | text2=second_text) | ||
1201 | 821 | raw_slides.append(bible_text.rstrip()) | 837 | raw_slides.append(bible_text.rstrip()) |
1202 | 822 | bible_text = '' | 838 | bible_text = '' |
1203 | 823 | # If we are 'Verse Per Slide' then create a new slide. | 839 | # If we are 'Verse Per Slide' then create a new slide. |
1204 | 824 | elif self.settings.layout_style == LayoutStyle.VersePerSlide: | 840 | elif self.settings.layout_style == LayoutStyle.VersePerSlide: |
1206 | 825 | bible_text = '%s%s' % (verse_text, text) | 841 | bible_text = '{verse}{text}'.format(verse=verse_text, text=text) |
1207 | 826 | raw_slides.append(bible_text.rstrip()) | 842 | raw_slides.append(bible_text.rstrip()) |
1208 | 827 | bible_text = '' | 843 | bible_text = '' |
1209 | 828 | # If we are 'Verse Per Line' then force a new line. | 844 | # If we are 'Verse Per Line' then force a new line. |
1210 | 829 | elif self.settings.layout_style == LayoutStyle.VersePerLine: | 845 | elif self.settings.layout_style == LayoutStyle.VersePerLine: |
1212 | 830 | bible_text = '%s%s%s\n' % (bible_text, verse_text, text) | 846 | bible_text = '{bible}{verse}{text}\n'.format(bible=bible_text, verse=verse_text, text=text) |
1213 | 831 | # We have to be 'Continuous'. | 847 | # We have to be 'Continuous'. |
1214 | 832 | else: | 848 | else: |
1216 | 833 | bible_text = '%s %s%s\n' % (bible_text, verse_text, text) | 849 | bible_text = '{bible} {verse}{text}\n'.format(bible=bible_text, verse=verse_text, text=text) |
1217 | 834 | bible_text = bible_text.strip(' ') | 850 | bible_text = bible_text.strip(' ') |
1218 | 835 | if not old_item: | 851 | if not old_item: |
1219 | 836 | start_item = bitem | 852 | start_item = bitem |
1220 | @@ -857,7 +873,7 @@ | |||
1221 | 857 | service_item.add_capability(ItemCapabilities.CanWordSplit) | 873 | service_item.add_capability(ItemCapabilities.CanWordSplit) |
1222 | 858 | service_item.add_capability(ItemCapabilities.CanEditTitle) | 874 | service_item.add_capability(ItemCapabilities.CanEditTitle) |
1223 | 859 | # Service Item: Title | 875 | # Service Item: Title |
1225 | 860 | service_item.title = '%s %s' % (verses.format_verses(), verses.format_versions()) | 876 | service_item.title = '{verse} {version}'.format(verse=verses.format_verses(), version=verses.format_versions()) |
1226 | 861 | # Service Item: Theme | 877 | # Service Item: Theme |
1227 | 862 | if not self.settings.bible_theme: | 878 | if not self.settings.bible_theme: |
1228 | 863 | service_item.theme = None | 879 | service_item.theme = None |
1229 | @@ -885,7 +901,7 @@ | |||
1230 | 885 | start_bible = self._decode_qt_object(start_bitem, 'bible') | 901 | start_bible = self._decode_qt_object(start_bitem, 'bible') |
1231 | 886 | start_second_bible = self._decode_qt_object(start_bitem, 'second_bible') | 902 | start_second_bible = self._decode_qt_object(start_bitem, 'second_bible') |
1232 | 887 | if start_second_bible: | 903 | if start_second_bible: |
1234 | 888 | bibles = '%s, %s' % (start_bible, start_second_bible) | 904 | bibles = '{bible1}, {bible2}'.format(bible1=start_bible, bible2=start_second_bible) |
1235 | 889 | else: | 905 | else: |
1236 | 890 | bibles = start_bible | 906 | bibles = start_bible |
1237 | 891 | if start_chapter == old_chapter: | 907 | if start_chapter == old_chapter: |
1238 | @@ -896,7 +912,7 @@ | |||
1239 | 896 | else: | 912 | else: |
1240 | 897 | verse_range = start_chapter + verse_separator + start_verse + \ | 913 | verse_range = start_chapter + verse_separator + start_verse + \ |
1241 | 898 | range_separator + old_chapter + verse_separator + old_verse | 914 | range_separator + old_chapter + verse_separator + old_verse |
1243 | 899 | return '%s %s (%s)' % (start_book, verse_range, bibles) | 915 | return '{book} {verse} ({bible})'.format(book=start_book, verse=verse_range, bible=bibles) |
1244 | 900 | 916 | ||
1245 | 901 | def check_title(self, bitem, old_bitem): | 917 | def check_title(self, bitem, old_bitem): |
1246 | 902 | """ | 918 | """ |
1247 | @@ -949,12 +965,12 @@ | |||
1248 | 949 | else: | 965 | else: |
1249 | 950 | verse_text = str(verse) | 966 | verse_text = str(verse) |
1250 | 951 | if self.settings.display_style == DisplayStyle.Round: | 967 | if self.settings.display_style == DisplayStyle.Round: |
1252 | 952 | return '{su}(%s){/su} ' % verse_text | 968 | return '{{su}}({verse}){{/su}} '.format(verse=verse_text) |
1253 | 953 | if self.settings.display_style == DisplayStyle.Curly: | 969 | if self.settings.display_style == DisplayStyle.Curly: |
1255 | 954 | return '{su}{%s}{/su} ' % verse_text | 970 | return '{{su}}{{{verse}}}{{/su}} '.format(verse=verse_text) |
1256 | 955 | if self.settings.display_style == DisplayStyle.Square: | 971 | if self.settings.display_style == DisplayStyle.Square: |
1259 | 956 | return '{su}[%s]{/su} ' % verse_text | 972 | return '{{su}}[{verse}]{{/su}} '.format(verse=verse_text) |
1260 | 957 | return '{su}%s{/su} ' % verse_text | 973 | return '{{su}}{verse}{{/su}} '.format(verse=verse_text) |
1261 | 958 | 974 | ||
1262 | 959 | def search(self, string, showError): | 975 | def search(self, string, showError): |
1263 | 960 | """ | 976 | """ |
1264 | 961 | 977 | ||
1265 | === modified file 'openlp/plugins/bibles/lib/opensong.py' | |||
1266 | --- openlp/plugins/bibles/lib/opensong.py 2015-12-31 22:46:06 +0000 | |||
1267 | +++ openlp/plugins/bibles/lib/opensong.py 2016-05-21 08:42:57 +0000 | |||
1268 | @@ -63,7 +63,7 @@ | |||
1269 | 63 | """ | 63 | """ |
1270 | 64 | Loads a Bible from file. | 64 | Loads a Bible from file. |
1271 | 65 | """ | 65 | """ |
1273 | 66 | log.debug('Starting OpenSong import from "%s"' % self.filename) | 66 | log.debug('Starting OpenSong import from "{name}"'.format(name=self.filename)) |
1274 | 67 | if not isinstance(self.filename, str): | 67 | if not isinstance(self.filename, str): |
1275 | 68 | self.filename = str(self.filename, 'utf8') | 68 | self.filename = str(self.filename, 'utf8') |
1276 | 69 | import_file = None | 69 | import_file = None |
1277 | @@ -84,14 +84,14 @@ | |||
1278 | 84 | # No language info in the opensong format, so ask the user | 84 | # No language info in the opensong format, so ask the user |
1279 | 85 | language_id = self.get_language(bible_name) | 85 | language_id = self.get_language(bible_name) |
1280 | 86 | if not language_id: | 86 | if not language_id: |
1282 | 87 | log.error('Importing books from "%s" failed' % self.filename) | 87 | log.error('Importing books from "{name}" failed'.format(name=self.filename)) |
1283 | 88 | return False | 88 | return False |
1284 | 89 | for book in bible.b: | 89 | for book in bible.b: |
1285 | 90 | if self.stop_import_flag: | 90 | if self.stop_import_flag: |
1286 | 91 | break | 91 | break |
1287 | 92 | book_ref_id = self.get_book_ref_id_by_name(str(book.attrib['n']), len(bible.b), language_id) | 92 | book_ref_id = self.get_book_ref_id_by_name(str(book.attrib['n']), len(bible.b), language_id) |
1288 | 93 | if not book_ref_id: | 93 | if not book_ref_id: |
1290 | 94 | log.error('Importing books from "%s" failed' % self.filename) | 94 | log.error('Importing books from "{name}" failed'.format(name=self.filename)) |
1291 | 95 | return False | 95 | return False |
1292 | 96 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) | 96 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) |
1293 | 97 | db_book = self.create_book(book.attrib['n'], book_ref_id, book_details['testament_id']) | 97 | db_book = self.create_book(book.attrib['n'], book_ref_id, book_details['testament_id']) |
1294 | @@ -117,14 +117,14 @@ | |||
1295 | 117 | if len(verse_parts) > 1: | 117 | if len(verse_parts) > 1: |
1296 | 118 | number = int(verse_parts[0]) | 118 | number = int(verse_parts[0]) |
1297 | 119 | except TypeError: | 119 | except TypeError: |
1299 | 120 | log.warning('Illegal verse number: %s', str(verse.attrib['n'])) | 120 | log.warning('Illegal verse number: {verse:d}'.format(verse.attrib['n'])) |
1300 | 121 | verse_number = number | 121 | verse_number = number |
1301 | 122 | else: | 122 | else: |
1302 | 123 | verse_number += 1 | 123 | verse_number += 1 |
1303 | 124 | self.create_verse(db_book.id, chapter_number, verse_number, self.get_text(verse)) | 124 | self.create_verse(db_book.id, chapter_number, verse_number, self.get_text(verse)) |
1307 | 125 | self.wizard.increment_progress_bar( | 125 | self.wizard.increment_progress_bar(translate('BiblesPlugin.Opensong', |
1308 | 126 | translate('BiblesPlugin.Opensong', 'Importing %(bookname)s %(chapter)s...') % | 126 | 'Importing {name} {chapter}...' |
1309 | 127 | {'bookname': db_book.name, 'chapter': chapter_number}) | 127 | ).format(name=db_book.name, chapter=chapter_number)) |
1310 | 128 | self.session.commit() | 128 | self.session.commit() |
1311 | 129 | self.application.process_events() | 129 | self.application.process_events() |
1312 | 130 | except etree.XMLSyntaxError as inst: | 130 | except etree.XMLSyntaxError as inst: |
1313 | 131 | 131 | ||
1314 | === modified file 'openlp/plugins/bibles/lib/osis.py' | |||
1315 | --- openlp/plugins/bibles/lib/osis.py 2015-12-31 22:46:06 +0000 | |||
1316 | +++ openlp/plugins/bibles/lib/osis.py 2016-05-21 08:42:57 +0000 | |||
1317 | @@ -49,7 +49,7 @@ | |||
1318 | 49 | """ | 49 | """ |
1319 | 50 | Loads a Bible from file. | 50 | Loads a Bible from file. |
1320 | 51 | """ | 51 | """ |
1322 | 52 | log.debug('Starting OSIS import from "%s"' % self.filename) | 52 | log.debug('Starting OSIS import from "{name}"'.format(name=self.filename)) |
1323 | 53 | if not isinstance(self.filename, str): | 53 | if not isinstance(self.filename, str): |
1324 | 54 | self.filename = str(self.filename, 'utf8') | 54 | self.filename = str(self.filename, 'utf8') |
1325 | 55 | import_file = None | 55 | import_file = None |
1326 | @@ -69,7 +69,7 @@ | |||
1327 | 69 | if not language_id: | 69 | if not language_id: |
1328 | 70 | language_id = self.get_language(bible_name) | 70 | language_id = self.get_language(bible_name) |
1329 | 71 | if not language_id: | 71 | if not language_id: |
1331 | 72 | log.error('Importing books from "%s" failed' % self.filename) | 72 | log.error('Importing books from "{name}" failed'.format(name=self.filename)) |
1332 | 73 | return False | 73 | return False |
1333 | 74 | self.save_meta('language_id', language_id) | 74 | self.save_meta('language_id', language_id) |
1334 | 75 | num_books = int(osis_bible_tree.xpath("count(//ns:div[@type='book'])", namespaces=namespace)) | 75 | num_books = int(osis_bible_tree.xpath("count(//ns:div[@type='book'])", namespaces=namespace)) |
1335 | @@ -129,7 +129,7 @@ | |||
1336 | 129 | if not book_ref_id: | 129 | if not book_ref_id: |
1337 | 130 | book_ref_id = self.get_book_ref_id_by_localised_name(book.get('osisID')) | 130 | book_ref_id = self.get_book_ref_id_by_localised_name(book.get('osisID')) |
1338 | 131 | if not book_ref_id: | 131 | if not book_ref_id: |
1340 | 132 | log.error('Importing books from "%s" failed' % self.filename) | 132 | log.error('Importing books from "{name}" failed'.format(name=self.filename)) |
1341 | 133 | return False | 133 | return False |
1342 | 134 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) | 134 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) |
1343 | 135 | db_book = self.create_book(book_details['name'], book_ref_id, book_details['testament_id']) | 135 | db_book = self.create_book(book_details['name'], book_ref_id, book_details['testament_id']) |
1344 | @@ -187,7 +187,8 @@ | |||
1345 | 187 | trace_error_handler(log) | 187 | trace_error_handler(log) |
1346 | 188 | success = False | 188 | success = False |
1347 | 189 | critical_error_message_box(message=translate('BiblesPlugin.OsisImport', | 189 | critical_error_message_box(message=translate('BiblesPlugin.OsisImport', |
1349 | 190 | 'The file is not a valid OSIS-XML file: \n%s' % e.msg)) | 190 | 'The file is not a valid OSIS-XML file:' |
1350 | 191 | '\n{text}').format(text=e.msg)) | ||
1351 | 191 | finally: | 192 | finally: |
1352 | 192 | if import_file: | 193 | if import_file: |
1353 | 193 | import_file.close() | 194 | import_file.close() |
1354 | 194 | 195 | ||
1355 | === modified file 'openlp/plugins/bibles/lib/sword.py' | |||
1356 | --- openlp/plugins/bibles/lib/sword.py 2016-04-23 18:33:53 +0000 | |||
1357 | +++ openlp/plugins/bibles/lib/sword.py 2016-05-21 08:42:57 +0000 | |||
1358 | @@ -51,7 +51,7 @@ | |||
1359 | 51 | """ | 51 | """ |
1360 | 52 | Loads a Bible from SWORD module. | 52 | Loads a Bible from SWORD module. |
1361 | 53 | """ | 53 | """ |
1363 | 54 | log.debug('Starting SWORD import from "%s"' % self.sword_key) | 54 | log.debug('Starting SWORD import from "{key}"'.format(key=self.sword_key)) |
1364 | 55 | success = True | 55 | success = True |
1365 | 56 | try: | 56 | try: |
1366 | 57 | pysword_modules = modules.SwordModules(self.sword_path) | 57 | pysword_modules = modules.SwordModules(self.sword_path) |
1367 | @@ -84,14 +84,14 @@ | |||
1368 | 84 | verse_number += 1 | 84 | verse_number += 1 |
1369 | 85 | self.create_verse(db_book.id, chapter_number, verse_number, verse) | 85 | self.create_verse(db_book.id, chapter_number, verse_number, verse) |
1370 | 86 | self.wizard.increment_progress_bar( | 86 | self.wizard.increment_progress_bar( |
1372 | 87 | translate('BiblesPlugin.Sword', 'Importing %s...') % db_book.name) | 87 | translate('BiblesPlugin.Sword', 'Importing {name}...').format(name=db_book.name)) |
1373 | 88 | self.session.commit() | 88 | self.session.commit() |
1374 | 89 | self.application.process_events() | 89 | self.application.process_events() |
1375 | 90 | except Exception as e: | 90 | except Exception as e: |
1376 | 91 | critical_error_message_box( | 91 | critical_error_message_box( |
1377 | 92 | message=translate('BiblesPlugin.SwordImport', 'An unexpected error happened while importing the SWORD ' | 92 | message=translate('BiblesPlugin.SwordImport', 'An unexpected error happened while importing the SWORD ' |
1378 | 93 | 'bible, please report this to the OpenLP developers.\n' | 93 | 'bible, please report this to the OpenLP developers.\n' |
1380 | 94 | '%s' % e)) | 94 | '{error}').format(error=e)) |
1381 | 95 | log.exception(str(e)) | 95 | log.exception(str(e)) |
1382 | 96 | success = False | 96 | success = False |
1383 | 97 | if self.stop_import_flag: | 97 | if self.stop_import_flag: |
1384 | 98 | 98 | ||
1385 | === modified file 'openlp/plugins/bibles/lib/upgrade.py' | |||
1386 | --- openlp/plugins/bibles/lib/upgrade.py 2015-12-31 22:46:06 +0000 | |||
1387 | +++ openlp/plugins/bibles/lib/upgrade.py 2016-05-21 08:42:57 +0000 | |||
1388 | @@ -101,7 +101,7 @@ | |||
1389 | 101 | metadata_table.c.key == 'download source' | 101 | metadata_table.c.key == 'download source' |
1390 | 102 | ) | 102 | ) |
1391 | 103 | ).scalar() | 103 | ).scalar() |
1393 | 104 | log.debug('download source: %s', value_count) | 104 | log.debug('download source: {count}'.format(count=value_count)) |
1394 | 105 | if value_count > 0: | 105 | if value_count > 0: |
1395 | 106 | session.execute(insert(metadata_table).values( | 106 | session.execute(insert(metadata_table).values( |
1396 | 107 | key='download_source', | 107 | key='download_source', |
1397 | @@ -121,7 +121,7 @@ | |||
1398 | 121 | metadata_table.c.key == 'download name' | 121 | metadata_table.c.key == 'download name' |
1399 | 122 | ) | 122 | ) |
1400 | 123 | ).scalar() | 123 | ).scalar() |
1402 | 124 | log.debug('download name: %s', value_count) | 124 | log.debug('download name: {count}'.format(count=value_count)) |
1403 | 125 | if value_count > 0: | 125 | if value_count > 0: |
1404 | 126 | session.execute(insert(metadata_table).values( | 126 | session.execute(insert(metadata_table).values( |
1405 | 127 | key='download_name', | 127 | key='download_name', |
1406 | @@ -141,7 +141,7 @@ | |||
1407 | 141 | metadata_table.c.key == 'proxy server' | 141 | metadata_table.c.key == 'proxy server' |
1408 | 142 | ) | 142 | ) |
1409 | 143 | ).scalar() | 143 | ).scalar() |
1411 | 144 | log.debug('proxy server: %s', value_count) | 144 | log.debug('proxy server: {count}'.format(count=value_count)) |
1412 | 145 | if value_count > 0: | 145 | if value_count > 0: |
1413 | 146 | session.execute(insert(metadata_table).values( | 146 | session.execute(insert(metadata_table).values( |
1414 | 147 | key='proxy_server', | 147 | key='proxy_server', |
1415 | @@ -161,7 +161,7 @@ | |||
1416 | 161 | metadata_table.c.key == 'proxy username' | 161 | metadata_table.c.key == 'proxy username' |
1417 | 162 | ) | 162 | ) |
1418 | 163 | ).scalar() | 163 | ).scalar() |
1420 | 164 | log.debug('proxy username: %s', value_count) | 164 | log.debug('proxy username: {count}'.format(count=value_count)) |
1421 | 165 | if value_count > 0: | 165 | if value_count > 0: |
1422 | 166 | session.execute(insert(metadata_table).values( | 166 | session.execute(insert(metadata_table).values( |
1423 | 167 | key='proxy_username', | 167 | key='proxy_username', |
1424 | @@ -181,7 +181,7 @@ | |||
1425 | 181 | metadata_table.c.key == 'proxy password' | 181 | metadata_table.c.key == 'proxy password' |
1426 | 182 | ) | 182 | ) |
1427 | 183 | ).scalar() | 183 | ).scalar() |
1429 | 184 | log.debug('proxy password: %s', value_count) | 184 | log.debug('proxy password: {count}'.format(count=value_count)) |
1430 | 185 | if value_count > 0: | 185 | if value_count > 0: |
1431 | 186 | session.execute(insert(metadata_table).values( | 186 | session.execute(insert(metadata_table).values( |
1432 | 187 | key='proxy_password', | 187 | key='proxy_password', |
1433 | 188 | 188 | ||
1434 | === modified file 'openlp/plugins/bibles/lib/versereferencelist.py' | |||
1435 | --- openlp/plugins/bibles/lib/versereferencelist.py 2015-12-31 22:46:06 +0000 | |||
1436 | +++ openlp/plugins/bibles/lib/versereferencelist.py 2016-05-21 08:42:57 +0000 | |||
1437 | @@ -61,23 +61,29 @@ | |||
1438 | 61 | result = '' | 61 | result = '' |
1439 | 62 | for index, verse in enumerate(self.verse_list): | 62 | for index, verse in enumerate(self.verse_list): |
1440 | 63 | if index == 0: | 63 | if index == 0: |
1442 | 64 | result = '%s %s%s%s' % (verse['book'], verse['chapter'], verse_sep, verse['start']) | 64 | result = '{book} {chapter}{sep}{verse}'.format(book=verse['book'], |
1443 | 65 | chapter=verse['chapter'], | ||
1444 | 66 | sep=verse_sep, | ||
1445 | 67 | verse=verse['start']) | ||
1446 | 65 | if verse['start'] != verse['end']: | 68 | if verse['start'] != verse['end']: |
1448 | 66 | result = '%s%s%s' % (result, range_sep, verse['end']) | 69 | result = '{result}{sep}{end}'.format(result=result, sep=range_sep, end=verse['end']) |
1449 | 67 | continue | 70 | continue |
1450 | 68 | prev = index - 1 | 71 | prev = index - 1 |
1451 | 69 | if self.verse_list[prev]['version'] != verse['version']: | 72 | if self.verse_list[prev]['version'] != verse['version']: |
1454 | 70 | result = '%s (%s)' % (result, self.verse_list[prev]['version']) | 73 | result = '{result} ({version})'.format(result=result, version=self.verse_list[prev]['version']) |
1455 | 71 | result += '%s ' % list_sep | 74 | result += '{sep} '.format(sep=list_sep) |
1456 | 72 | if self.verse_list[prev]['book'] != verse['book']: | 75 | if self.verse_list[prev]['book'] != verse['book']: |
1458 | 73 | result = '%s%s %s%s' % (result, verse['book'], verse['chapter'], verse_sep) | 76 | result = '{result}{book} {chapter}{sep}'.format(result=result, |
1459 | 77 | book=verse['book'], | ||
1460 | 78 | chapter=verse['chapter'], | ||
1461 | 79 | sep=verse_sep) | ||
1462 | 74 | elif self.verse_list[prev]['chapter'] != verse['chapter']: | 80 | elif self.verse_list[prev]['chapter'] != verse['chapter']: |
1464 | 75 | result = '%s%s%s' % (result, verse['chapter'], verse_sep) | 81 | result = '{result}{chapter}{sep}'.format(result=result, chapter=verse['chapter'], sep=verse_sep) |
1465 | 76 | result += str(verse['start']) | 82 | result += str(verse['start']) |
1466 | 77 | if verse['start'] != verse['end']: | 83 | if verse['start'] != verse['end']: |
1468 | 78 | result = '%s%s%s' % (result, range_sep, verse['end']) | 84 | result = '{result}{sep}{end}'.format(result=result, sep=range_sep, end=verse['end']) |
1469 | 79 | if len(self.version_list) > 1: | 85 | if len(self.version_list) > 1: |
1471 | 80 | result = '%s (%s)' % (result, verse['version']) | 86 | result = '{result} ({version})'.format(result=result, version=verse['version']) |
1472 | 81 | return result | 87 | return result |
1473 | 82 | 88 | ||
1474 | 83 | def format_versions(self, copyright=True, permission=True): | 89 | def format_versions(self, copyright=True, permission=True): |
1475 | 84 | 90 | ||
1476 | === modified file 'openlp/plugins/bibles/lib/zefania.py' | |||
1477 | --- openlp/plugins/bibles/lib/zefania.py 2016-03-25 19:33:26 +0000 | |||
1478 | +++ openlp/plugins/bibles/lib/zefania.py 2016-05-21 08:42:57 +0000 | |||
1479 | @@ -48,7 +48,7 @@ | |||
1480 | 48 | """ | 48 | """ |
1481 | 49 | Loads a Bible from file. | 49 | Loads a Bible from file. |
1482 | 50 | """ | 50 | """ |
1484 | 51 | log.debug('Starting Zefania import from "%s"' % self.filename) | 51 | log.debug('Starting Zefania import from "{name}"'.format(name=self.filename)) |
1485 | 52 | if not isinstance(self.filename, str): | 52 | if not isinstance(self.filename, str): |
1486 | 53 | self.filename = str(self.filename, 'utf8') | 53 | self.filename = str(self.filename, 'utf8') |
1487 | 54 | import_file = None | 54 | import_file = None |
1488 | @@ -67,7 +67,7 @@ | |||
1489 | 67 | if not language_id: | 67 | if not language_id: |
1490 | 68 | language_id = self.get_language(bible_name) | 68 | language_id = self.get_language(bible_name) |
1491 | 69 | if not language_id: | 69 | if not language_id: |
1493 | 70 | log.error('Importing books from "%s" failed' % self.filename) | 70 | log.error('Importing books from "{name}" failed'.format(name=self.filename)) |
1494 | 71 | return False | 71 | return False |
1495 | 72 | self.save_meta('language_id', language_id) | 72 | self.save_meta('language_id', language_id) |
1496 | 73 | num_books = int(zefania_bible_tree.xpath('count(//BIBLEBOOK)')) | 73 | num_books = int(zefania_bible_tree.xpath('count(//BIBLEBOOK)')) |
1497 | @@ -92,7 +92,7 @@ | |||
1498 | 92 | log.debug('Could not find a name, will use number, basically a guess.') | 92 | log.debug('Could not find a name, will use number, basically a guess.') |
1499 | 93 | book_ref_id = int(bnumber) | 93 | book_ref_id = int(bnumber) |
1500 | 94 | if not book_ref_id: | 94 | if not book_ref_id: |
1502 | 95 | log.error('Importing books from "%s" failed' % self.filename) | 95 | log.error('Importing books from "{name}" failed'.format(name=self.filename)) |
1503 | 96 | return False | 96 | return False |
1504 | 97 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) | 97 | book_details = BiblesResourcesDB.get_book_by_id(book_ref_id) |
1505 | 98 | db_book = self.create_book(book_details['name'], book_ref_id, book_details['testament_id']) | 98 | db_book = self.create_book(book_details['name'], book_ref_id, book_details['testament_id']) |
1506 | @@ -104,8 +104,9 @@ | |||
1507 | 104 | verse_number = VERS.get("vnumber") | 104 | verse_number = VERS.get("vnumber") |
1508 | 105 | self.create_verse(db_book.id, chapter_number, verse_number, VERS.text.replace('<BR/>', '\n')) | 105 | self.create_verse(db_book.id, chapter_number, verse_number, VERS.text.replace('<BR/>', '\n')) |
1509 | 106 | self.wizard.increment_progress_bar( | 106 | self.wizard.increment_progress_bar( |
1512 | 107 | translate('BiblesPlugin.Zefnia', 'Importing %(bookname)s %(chapter)s...') % | 107 | translate('BiblesPlugin.Zefnia', |
1513 | 108 | {'bookname': db_book.name, 'chapter': chapter_number}) | 108 | 'Importing {book} {chapter}...').format(book=db_book.name, |
1514 | 109 | chapter=chapter_number)) | ||
1515 | 109 | self.session.commit() | 110 | self.session.commit() |
1516 | 110 | self.application.process_events() | 111 | self.application.process_events() |
1517 | 111 | except Exception as e: | 112 | except Exception as e: |
1518 | 112 | 113 | ||
1519 | === modified file 'tests/functional/openlp_core_lib/test_projectordb.py' | |||
1520 | --- tests/functional/openlp_core_lib/test_projectordb.py 2016-05-20 16:22:06 +0000 | |||
1521 | +++ tests/functional/openlp_core_lib/test_projectordb.py 2016-05-21 08:42:57 +0000 | |||
1522 | @@ -29,6 +29,7 @@ | |||
1523 | 29 | from unittest import TestCase | 29 | from unittest import TestCase |
1524 | 30 | 30 | ||
1525 | 31 | from openlp.core.lib.projector.db import Manufacturer, Model, Projector, ProjectorDB, ProjectorSource, Source | 31 | from openlp.core.lib.projector.db import Manufacturer, Model, Projector, ProjectorDB, ProjectorSource, Source |
1526 | 32 | from openlp.core.lib.projector.constants import PJLINK_PORT | ||
1527 | 32 | 33 | ||
1528 | 33 | from tests.functional import MagicMock, patch | 34 | from tests.functional import MagicMock, patch |
1529 | 34 | from tests.resources.projector.data import TEST_DB, TEST1_DATA, TEST2_DATA, TEST3_DATA | 35 | from tests.resources.projector.data import TEST_DB, TEST1_DATA, TEST2_DATA, TEST3_DATA |
1530 | @@ -195,7 +196,7 @@ | |||
1531 | 195 | 196 | ||
1532 | 196 | def manufacturer_repr_test(self): | 197 | def manufacturer_repr_test(self): |
1533 | 197 | """ | 198 | """ |
1535 | 198 | Test manufacturer class __repr__ text | 199 | Test Manufacturer.__repr__ text |
1536 | 199 | """ | 200 | """ |
1537 | 200 | # GIVEN: Test object | 201 | # GIVEN: Test object |
1538 | 201 | manufacturer = Manufacturer() | 202 | manufacturer = Manufacturer() |
1539 | @@ -209,7 +210,7 @@ | |||
1540 | 209 | 210 | ||
1541 | 210 | def model_repr_test(self): | 211 | def model_repr_test(self): |
1542 | 211 | """ | 212 | """ |
1544 | 212 | Test model class __repr__ text | 213 | Test Model.__repr__ text |
1545 | 213 | """ | 214 | """ |
1546 | 214 | # GIVEN: Test object | 215 | # GIVEN: Test object |
1547 | 215 | model = Model() | 216 | model = Model() |
1548 | @@ -223,7 +224,7 @@ | |||
1549 | 223 | 224 | ||
1550 | 224 | def source_repr_test(self): | 225 | def source_repr_test(self): |
1551 | 225 | """ | 226 | """ |
1553 | 226 | Test source.__repr__ text | 227 | Test Source.__repr__ text |
1554 | 227 | """ | 228 | """ |
1555 | 228 | # GIVEN: Test object | 229 | # GIVEN: Test object |
1556 | 229 | source = Source() | 230 | source = Source() |
1557 | @@ -236,3 +237,31 @@ | |||
1558 | 236 | # THEN: __repr__ should return a proper string | 237 | # THEN: __repr__ should return a proper string |
1559 | 237 | self.assertEqual(str(source), '<Source(pjlink_name="Test object", pjlink_code="11", text="Input text")>', | 238 | self.assertEqual(str(source), '<Source(pjlink_name="Test object", pjlink_code="11", text="Input text")>', |
1560 | 238 | 'Source.__repr__() should have returned a proper representation string') | 239 | 'Source.__repr__() should have returned a proper representation string') |
1561 | 240 | |||
1562 | 241 | def projector_repr_test(self): | ||
1563 | 242 | """ | ||
1564 | 243 | Test Projector.__repr__() text | ||
1565 | 244 | """ | ||
1566 | 245 | # GIVEN: Test object | ||
1567 | 246 | projector = Projector() | ||
1568 | 247 | |||
1569 | 248 | # WHEN: projector() is populated | ||
1570 | 249 | # NOTE: projector.pin, projector.other, projector.sources should all return None | ||
1571 | 250 | # projector.source_list should return an empty list | ||
1572 | 251 | projector.id = 0 | ||
1573 | 252 | projector.ip = '127.0.0.1' | ||
1574 | 253 | projector.port = PJLINK_PORT | ||
1575 | 254 | projector.name = 'Test One' | ||
1576 | 255 | projector.location = 'Somewhere over the rainbow' | ||
1577 | 256 | projector.notes = 'Not again' | ||
1578 | 257 | projector.pjlink_name = 'TEST' | ||
1579 | 258 | projector.manufacturer = 'IN YOUR DREAMS' | ||
1580 | 259 | projector.model = 'OpenLP' | ||
1581 | 260 | |||
1582 | 261 | # THEN: __repr__ should return a proper string | ||
1583 | 262 | self.assertEqual(str(projector), | ||
1584 | 263 | '< Projector(id="0", ip="127.0.0.1", port="4352", pin="None", name="Test One", ' | ||
1585 | 264 | 'location="Somewhere over the rainbow", notes="Not again", pjlink_name="TEST", ' | ||
1586 | 265 | 'manufacturer="IN YOUR DREAMS", model="OpenLP", other="None", sources="None", ' | ||
1587 | 266 | 'source_list="[]") >', | ||
1588 | 267 | 'Projector.__repr__() should have returned a proper representation string') | ||
1589 | 239 | 268 | ||
1590 | === modified file 'tests/functional/openlp_plugins/bibles/test_http.py' | |||
1591 | --- tests/functional/openlp_plugins/bibles/test_http.py 2016-02-04 20:17:40 +0000 | |||
1592 | +++ tests/functional/openlp_plugins/bibles/test_http.py 2016-05-21 08:42:57 +0000 | |||
1593 | @@ -104,7 +104,7 @@ | |||
1594 | 104 | result = instance.get_books_from_http('NIV') | 104 | result = instance.get_books_from_http('NIV') |
1595 | 105 | 105 | ||
1596 | 106 | # THEN: The rest mocks should be called with known values and get_books_from_http should return None | 106 | # THEN: The rest mocks should be called with known values and get_books_from_http should return None |
1598 | 107 | self.mock_log.debug.assert_called_once_with('BSExtract.get_books_from_http("%s")', 'NIV') | 107 | self.mock_log.debug.assert_called_once_with('BSExtract.get_books_from_http("{book}")'.format(book='NIV')) |
1599 | 108 | self.mock_urllib.parse.quote.assert_called_once_with(b'NIV') | 108 | self.mock_urllib.parse.quote.assert_called_once_with(b'NIV') |
1600 | 109 | self.mock_get_soup_for_bible_ref.assert_called_once_with( | 109 | self.mock_get_soup_for_bible_ref.assert_called_once_with( |
1601 | 110 | 'http://m.bibleserver.com/overlay/selectBook?translation=NIV') | 110 | 'http://m.bibleserver.com/overlay/selectBook?translation=NIV') |
1602 | @@ -132,7 +132,7 @@ | |||
1603 | 132 | result = instance.get_books_from_http('NIV') | 132 | result = instance.get_books_from_http('NIV') |
1604 | 133 | 133 | ||
1605 | 134 | # THEN: The rest mocks should be called with known values and get_books_from_http should return None | 134 | # THEN: The rest mocks should be called with known values and get_books_from_http should return None |
1607 | 135 | self.mock_log.debug.assert_called_once_with('BSExtract.get_books_from_http("%s")', 'NIV') | 135 | self.mock_log.debug.assert_called_once_with('BSExtract.get_books_from_http("{book}")'.format(book='NIV')) |
1608 | 136 | self.mock_urllib.parse.quote.assert_called_once_with(b'NIV') | 136 | self.mock_urllib.parse.quote.assert_called_once_with(b'NIV') |
1609 | 137 | self.mock_get_soup_for_bible_ref.assert_called_once_with( | 137 | self.mock_get_soup_for_bible_ref.assert_called_once_with( |
1610 | 138 | 'http://m.bibleserver.com/overlay/selectBook?translation=NIV') | 138 | 'http://m.bibleserver.com/overlay/selectBook?translation=NIV') |
1611 | @@ -167,7 +167,7 @@ | |||
1612 | 167 | 167 | ||
1613 | 168 | # THEN: The rest mocks should be called with known values and get_books_from_http should return the two books | 168 | # THEN: The rest mocks should be called with known values and get_books_from_http should return the two books |
1614 | 169 | # in the test data | 169 | # in the test data |
1616 | 170 | self.mock_log.debug.assert_called_once_with('BSExtract.get_books_from_http("%s")', 'NIV') | 170 | self.mock_log.debug.assert_called_once_with('BSExtract.get_books_from_http("{book}")'.format(book='NIV')) |
1617 | 171 | self.mock_urllib.parse.quote.assert_called_once_with(b'NIV') | 171 | self.mock_urllib.parse.quote.assert_called_once_with(b'NIV') |
1618 | 172 | self.mock_get_soup_for_bible_ref.assert_called_once_with( | 172 | self.mock_get_soup_for_bible_ref.assert_called_once_with( |
1619 | 173 | 'http://m.bibleserver.com/overlay/selectBook?translation=NIV') | 173 | 'http://m.bibleserver.com/overlay/selectBook?translation=NIV') |
looks Ok