MAAS

~alexsander-souza/maas:lp1996204_to_3_3

Git
lp:~alexsander-souza/maas
lp1996204_to_3_3

Last commit made on 2023-11-09

Get this branch:: git clone -b lp1996204_to_3_3 https://git.launchpad.net/~alexsander-souza/maas

Only Alexsander de Souza can upload to this branch. If you are Alexsander de Souza please log in for upload directions.

Branch merges

Merged into maas:3.3

Alexsander de Souza: Approve on 2023-11-09

MAAS Lander: Approve on 2023-11-09

Branch information

Name:: lp1996204_to_3_3

Repository:: lp:~alexsander-souza/maas

Recent commits

6c07f5b... by Alexsander de Souza on 2023-06-01

normalize request path used as prometheus label

using the original requested path effectively tracks metrics per database object, not per endpoint as intended. Additionally it leads to huge number of histograms in the prometheus database, exceeding the 2GB limit after some time.

fixes LP#1996204

(cherry picked from commit 60a5e0ca08c25a238af04ee1dd4de9876acfbdc6)

f564d0f... by Mauricio Faria de Oliveira on 2023-11-06

LP:2040188 - bmc-config: add missing script metadata for parameter maas_auto_ipmi_cipher_suite_id

The bmc-config script is passed several parameters from MAAS config options
(e.g. maas_auto_ipmi_{user,user_password,user_privilege_level,k_g_bmc_key}).

But maas_auto_ipmi_cipher_suite_id is not, since it's not in the metadata.

Add it to actually allow users to change the default IPMI cipher suite ID.

Tested on MAAS 3.4.0~rc2 with this debug change to print script arguments:

         def main():
         ...
             args = parser.parse_args()
        + print(args)
         ...

Change MAAS config for IPMI cipher suite ID from 3 to 17:

        $ maas admin maas get-config \
          name=maas_auto_ipmi_cipher_suite_id
        Success.
        Machine-readable output follows:
        "3"

        $ maas admin maas set-config \
          name=maas_auto_ipmi_cipher_suite_id \
          value=17
        Success.
        Machine-readable output follows:
        OK

        $ maas admin maas get-config \
          name=maas_auto_ipmi_cipher_suite_id
        Success.
        Machine-readable output follows:
        "17"

Before:
(17 is not used; source code default of 3 is used, instead)

Namespace(ipmi_cipher_suite_id='3', ipmi_k_g='', ipmi_privilege_level='ADMIN', password=None, username='maas')

After:
(17 is now used!)

Namespace(ipmi_cipher_suite_id='17', ipmi_k_g='', ipmi_privilege_level='ADMIN', password=None, username='maas')

Found by comparison with (working) parameter maas_auto_ipmi_user:

        $ grep -r 'maas_auto_ipmi_user[^_]' | grep -vw -e maasui -e maas-offline-docs -e tests
        src/metadataserver/builtin_scripts/commissioning_scripts/bmc_config.py:# maas_auto_ipmi_user:
        src/maasserver/forms/settings.py: "maas_auto_ipmi_user": {
        src/maasserver/forms/parameters.py: "maas_auto_ipmi_user",
        src/maasserver/models/config.py: "maas_auto_ipmi_user": "maas",

        $ grep -r 'maas_auto_ipmi_cipher_suite_id[^_]' | grep -vw -e maasui -e maas-offline-docs -e tests
        src/maasserver/forms/settings.py: "maas_auto_ipmi_cipher_suite_id": {
        src/maasserver/forms/parameters.py: "maas_auto_ipmi_cipher_suite_id",
        src/maasserver/models/config.py: "maas_auto_ipmi_cipher_suite_id": "3",

Signed-off-by: Mauricio Faria de Oliveira <email address hidden>
(cherry picked from commit f06ea636a9466176d29d71e1539c65d7538f41da)

c339c21... by Eline Maaike De Weerd on 2023-11-06

fix: added an e to the suit

(cherry picked from commit a2d011b8710894a40b5f02fbb12e641388f6be5a)

cedc0fe... by Christian Grabowski on 2023-11-02

always use the DomainInfo network for reverse zones and check IP belongs to it
(cherry picked from commit b3dae13ec9a6b14f8c5cf23fb01de897c72256ca)

2e8fe85... by Christian Grabowski on 2023-10-30

use network ip and prefixlen of subnet when reverse zone is not given
(cherry picked from commit 6febd214b36cd3db4ff70540f7a25e01705fa5b2)

beee034... by Anton Troyanov on 2023-10-16

fix: force save model object changes

Resolves LP:2015411 StaticIPAddress matching query does not exist

(cherry picked from commit cfb432e6e41ab097950c9550b5c61d3ca6d6bbb2)

7eb22dc... by Jacopo Rota on 2023-10-10

Cherry pick b246274615da3d56fde185bd97eb1287e2cce4ec - Bug #2029417: Add a global interceptor for the closed handler exception to close the dead connections

86200a1... by Jacopo Rota on 2023-09-12