Merge ~alexsander-souza/maas:lp1996204_to_3_3 into maas:3.3
Proposed by
Alexsander de Souza
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alexsander de Souza | ||||
Approved revision: | 6c07f5b9dc9e4b78efc1adffbfb2f46aa5b82605 | ||||
Merge reported by: | MAAS Lander | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~alexsander-souza/maas:lp1996204_to_3_3 | ||||
Merge into: | maas:3.3 | ||||
Diff against target: |
37 lines (+12/-3) 1 file modified
src/maasserver/prometheus/middleware.py (+12/-3) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexsander de Souza | Approve | ||
MAAS Lander | Approve | ||
Review via email:
|
Commit message
normalize request path used as prometheus label
using the original requested path effectively tracks metrics per database object, not per endpoint as intended. Additionally it leads to huge number of histograms in the prometheus database, exceeding the 2GB limit after some time.
fixes LP#1996204
(cherry picked from commit 60a5e0ca08c25a2
To post a comment you must log in.
UNIT TESTS
-b lp1996204_to_3_3 lp:~alexsander-souza/maas/+git/maas into -b 3.3 lp:~maas-committers/maas
STATUS: FAILED maas-ci. internal: 8080/job/ maas-tester/ 3980/console 8efc1adffbfb2f4 6aa5b82605
LOG: http://
COMMIT: 6c07f5b9dc9e4b7