MAAS

~alexsander-souza/maas:2_9-fix-snap_build

Git
lp:~alexsander-souza/maas
2_9-fix-snap_build

Last commit made on 2022-10-26

Get this branch:: git clone -b 2_9-fix-snap_build https://git.launchpad.net/~alexsander-souza/maas

Only Alexsander de Souza can upload to this branch. If you are Alexsander de Souza please log in for upload directions.

Branch merges

Merged into maas:2.9

Alexsander de Souza: Approve on 2022-10-27

MAAS Lander: Approve on 2022-10-27

Branch information

Name:: 2_9-fix-snap_build

Repository:: lp:~alexsander-souza/maas

Recent commits

8e59dbf... by Björn Tillenius on 2022-02-28

Don't specify PYTHONPATH when building the snap.

Having a PYTHONPATH there breaks the build if a systemwide pip is
installed.

I tried building it without having build-environment defined. The snap
built ok, and the installed snap started up without any problems.

(cherry picked from commit f25a4b5fe52a2ccb9c5276b4dd040cab1143d4fd)

1ff8816... by Seyeong Kim on 2022-09-02

Fix utf-8 character error when bmc-config

Related LP and article

https://bugs.launchpad.net/bugs/1892983
https://bugs.launchpad.net/bugs/1929478
https://discourse.maas.io/t/maas-failed-commissioning/4904

(cherry picked from commit 3eec5b5161515a23f58c72638a5ff8aac7486622)

a5fd9b3... by Adam Collard on 2022-09-02

Two flaky tests fixes.

When put in a RAID, the minimum partition size becomes too small due
to RAID overhead: ensure we're not picking the minimum size.

Ensure that no generated NodeDevices clash with test fixtures - testing that filters work wasn't taking in to account potential clash with factory-generated NodeDevices.

(cherry picked from commit b359717e2775279651776fa90d07fb08cea5e4fd)

cc248e2... by Alberto Donato on 2022-08-30

test-related fixes to allow running tests with launchpad-ci

- don't run aa-exec in docker
- require gpg-agent since it's not preinstalled in all images

(cherry-pick from 5ea820c563694e1d188ce63d6263da7a5be0e63e)

d8eddd4... by Mauricio Faria de Oliveira on 2022-05-24

[cherry-pick from commit 9eef25a55a36 ("LP:1958433 curtin workaround for xfs in centos70")]

LP:1958433 curtin workaround for xfs in centos70

The XFS implementation in CentOS 7 does not support the reflink feature,
and refuses to mount with it, leaving the system boot in emergency mode.

So, if 'mkfs.xfs' in the commissioning image (used for deployment) knows
about 'reflink=0|1', create a wrapper to use '-m reflink=0' for CentOS 7.

The commands to generate the wrapper are general, long, and unoptimized,
for better compatibility between Bionic/Focal/Jammy comissioning images.

Example with Focal:

    ...
    Welcome to Ubuntu 20.04.4 LTS!
    ...
    [ 53.426717] cloud-init[1423]: start: cmd-install/stage-early: preparing for installation
    [ 53.432717] cloud-init[1423]: start: cmd-install/stage-early/centos70_xfs_lp1958433: running '/bin/sh -c if [ "centos70" = "centos70" ] && mkfs.xfs 2>&1 | grep -q "reflink=0|1"; then WRAPPER=/usr/local/sbin/mkfs.xfs; echo "#!/bin/sh" >$WRAPPER && echo "exec $(which mkfs.xfs) -m reflink=0 \"\$@\"" >>$WRAPPER && chmod +x $WRAPPER && echo "Wrapper: $WRAPPER" && cat $WRAPPER; fi'
    [ 53.476110] cloud-init[1423]: Wrapper: /usr/local/sbin/mkfs.xfs
    [ 53.478272] cloud-init[1423]: #!/bin/sh
    [ 53.478767] cloud-init[1423]: exec /usr/sbin/mkfs.xfs -m reflink=0 "$@"
    [ 53.479615] cloud-init[1423]: finish: cmd-install/stage-early/centos70_xfs_lp1958433: SUCCESS: running '/bin/sh -c if [ "centos70" = "centos70" ] && mkfs.xfs 2>&1 | grep -q "reflink=0|1"; then WRAPPER=/usr/local/sbin/mkfs.xfs; echo "#!/bin/sh" >$WRAPPER && echo "exec $(which mkfs.xfs) -m reflink=0 \"\$@\"" >>$WRAPPER && chmod +x $WRAPPER && echo "Wrapper: $WRAPPER" && cat $WRAPPER; fi'
    [ 53.485237] cloud-init[1423]: centos70_xfs_lp1958433 took 0.053 seconds
    [ 53.485435] cloud-init[1423]: stage_early took 0.053 seconds
    [ 53.485889] cloud-init[1423]: finish: cmd-install/stage-early: SUCCESS: preparing for installation
    ...
    [ 63.756098] cloud-init[1423]: Running command ['mkfs.xfs', '-f', '-L', '', '-m', 'uuid=42e5ad8a-f078-48d2-8d42-60ee2ef10641', '/dev/vda3'] with allowed return codes [0] (capture=True)
    [ 63.758788] cloud-init[1423]: Formated device type: partition
    [ 63.763745] cloud-init[1423]: finish: cmd-install/stage-partitioning/builtin/cmd-block-meta: SUCCESS: configuring format: vda-part3_format
    ...