Merge ~alexsander-souza/maas:2_9-fix-snap_build into maas:2.9

Proposed by Alexsander de Souza
Status: Merged
Approved by: Alexsander de Souza
Approved revision: 8e59dbfe804d0f854a79cc1524446541de52c926
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~alexsander-souza/maas:2_9-fix-snap_build
Merge into: maas:2.9
Diff against target: 13 lines (+0/-2)
1 file modified
snap/snapcraft.yaml (+0/-2)
Reviewer Review Type Date Requested Status
Alexsander de Souza Approve
MAAS Lander Approve
Review via email: mp+432215@code.launchpad.net

Commit message

Don't specify PYTHONPATH when building the snap.

Having a PYTHONPATH there breaks the build if a systemwide pip is
installed.

I tried building it without having build-environment defined. The snap
built ok, and the installed snap started up without any problems.

(cherry picked from commit f25a4b5fe52a2ccb9c5276b4dd040cab1143d4fd)

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b 2_9-fix-snap_build lp:~alexsander-souza/maas/+git/maas into -b 2.9 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/1185/consoleText
COMMIT: 8e59dbfe804d0f854a79cc1524446541de52c926

review: Needs Fixing
Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

jenkins: !test

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b 2_9-fix-snap_build lp:~alexsander-souza/maas/+git/maas into -b 2.9 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 8e59dbfe804d0f854a79cc1524446541de52c926

review: Approve
Revision history for this message
Alexsander de Souza (alexsander-souza) wrote :

self-approve

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 29c868f..42e0803 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -68,8 +68,6 @@ parts:
6 maas:
7 plugin: python
8 source: .
9- build-environment:
10- - PYTHONPATH: $SNAP/usr/lib/python3/dist-packages:$SNAP/usr/lib/python3.8/dist-packages
11 requirements:
12 - snap/local/requirements.txt
13 build-packages:

Subscribers

People subscribed via source and target branches