Code review comment for ~alexmurray/ubuntu-cve-tracker:source-map-performance-improvements

Revision history for this message
Alex Murray (alexmurray) wrote :

Closing this since the current approach of using a global variable to store the cache directly in source_map doesn't make sense given that source_map in general doesn't store global state like this. Instead will either need to encapsulate the cache in the returned map, or return it in a separate variable.

review: Disapprove

« Back to merge proposal