Merge ~alexmurray/ubuntu-cve-tracker:source-map-performance-improvements into ubuntu-cve-tracker:master
Proposed by
Alex Murray
Status: | Rejected |
---|---|
Rejected by: | Alex Murray |
Proposed branch: | ~alexmurray/ubuntu-cve-tracker:source-map-performance-improvements |
Merge into: | ubuntu-cve-tracker:master |
Diff against target: |
141 lines (+33/-14) 4 files modified
scripts/cve_lib.py (+3/-2) scripts/source_map.py (+16/-9) scripts/test_source_map.py (+11/-2) test/esm-fake-supported.txt (+3/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Murray | Disapprove | ||
Review via email: mp+447863@code.launchpad.net |
Description of the change
This is currently a work-in-progress
To post a comment you must log in.
Unmerged commits
- 1d08db8... by Alex Murray
-
unit-tests:0 (build) check-cves:0 (build) 1 → 2 of 2 results First • Previous • Next • Last - e76ede6... by Alex Murray
-
unit-tests:0 (build) check-cves:0 (build) 1 → 2 of 2 results First • Previous • Next • Last - 24c7dec... by Alex Murray
-
unit-tests:0 (build) check-cves:0 (build) 1 → 2 of 2 results First • Previous • Next • Last - 73c31b7... by Alex Murray
- 54f07e4... by Alex Murray
Closing this since the current approach of using a global variable to store the cache directly in source_map doesn't make sense given that source_map in general doesn't store global state like this. Instead will either need to encapsulate the cache in the returned map, or return it in a separate variable.