Code review comment for ~alephnull-b/charm-thruk-master:bionic-support

Revision history for this message
Chris Sanders (chris.sanders) wrote :

> > looks good, but I think it'd be cleaner to have two separate commits, as the
> > issues fixed are conceptually separate
>
> While I agree in concept, two lines of change splitting into two one line
> changes seems a bit much IMO.

Oh and if a bug is closed it should be linked to the review so it updates when accepted and merged.

« Back to merge proposal