Merge ~alephnull-b/charm-thruk-master:bionic-support into ~nagios-charmers/charm-thruk-master:master

Proposed by Alok G Singh
Status: Merged
Approved by: Alok G Singh
Approved revision: 4c80b7d3c1d8e2729958ebac9c64356854dcfcff
Merged at revision: 4c80b7d3c1d8e2729958ebac9c64356854dcfcff
Proposed branch: ~alephnull-b/charm-thruk-master:bionic-support
Merge into: ~nagios-charmers/charm-thruk-master:master
Diff against target: 27 lines (+2/-1)
2 files modified
hooks/services.py (+1/-1)
metadata.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Chris Sanders (community) Approve
Andrea Ieri Needs Fixing
Review via email: mp+362027@code.launchpad.net

Description of the change

Tested bionic support.
Fixes lp#1805101

To post a comment you must log in.
Revision history for this message
Andrea Ieri (aieri) wrote :

looks good, but I think it'd be cleaner to have two separate commits, as the issues fixed are conceptually separate

review: Needs Fixing
Revision history for this message
Chris Sanders (chris.sanders) wrote :

> looks good, but I think it'd be cleaner to have two separate commits, as the
> issues fixed are conceptually separate

While I agree in concept, two lines of change splitting into two one line changes seems a bit much IMO.

review: Approve
Revision history for this message
Chris Sanders (chris.sanders) wrote :

> > looks good, but I think it'd be cleaner to have two separate commits, as the
> > issues fixed are conceptually separate
>
> While I agree in concept, two lines of change splitting into two one line
> changes seems a bit much IMO.

Oh and if a bug is closed it should be linked to the review so it updates when accepted and merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/hooks/services.py b/hooks/services.py
2old mode 100644
3new mode 100755
4index 959f668..e661f7e
5--- a/hooks/services.py
6+++ b/hooks/services.py
7@@ -12,7 +12,7 @@ def manage():
8 config = hookenv.config()
9 manager = ServiceManager([
10 {
11- 'service': 'thruk-master',
12+ 'service': 'thruk',
13 'ports': [80, 443], # ports to after start
14 # 'provided_data': [
15 # # context managers for provided relations
16diff --git a/metadata.yaml b/metadata.yaml
17index 376b35a..df97618 100644
18--- a/metadata.yaml
19+++ b/metadata.yaml
20@@ -8,6 +8,7 @@ tags:
21 series:
22 - trusty
23 - xenial
24+ - bionic
25 subordinate: false
26 provides:
27 website:

Subscribers

People subscribed via source and target branches