Account - Financial Tools

Code review comment for lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search

  1. 7.0-account-financial_tools--add--account_account_extended_search
  2. Merge into 7.0
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Code looks good to me, and it's working fine. It looks to me like a very specific use case, which also does not apply to Dutch accounting habits but it may be broader than just Spanish (you never know, right?) so I think having the module here is fine.

What bothers me a little is the module name. Yes, it extends the search but it does so in a very specific way. Would you consider to change the name to something like "account_account_wildcard_zero_search"?

review: Needs Information
Reply

« Back to merge proposal