Merge lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:~account-core-editors/account-financial-tools/7.0

[Pedro Manuel Baeza]

New module account_account_extended_search that allows to search any account with the character '.' inside as a wildcard.

[Pedro Manuel Baeza (pedro.baeza)]

Alejandro, please fix these things:

- Remove all the chart template stuff, that doesn't belong to this module.
- Change module name and description in manifest file accordingly.
- Restart the version numbering to 1.0.
- Remove comment about templates at the beginning in account.py.
- Change the icon to one that is not duplicated from standard ones. You can make a slightly variation, for example.
- Remove 'l10n_es' as dependency and add 'account'.
- Remove template views modifications.
- Rebuild translations.

Thank you very much.

Regards.

review: Needs Fixing (code review)

[Alejandro Santana (alejandrosantana)]

So, in a nutshell, keep only the search via dot wildcard functionality, isn't it?

review: Needs Information

[Pedro Manuel Baeza (pedro.baeza)]

Yeah, that is!

[lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search]

137. By Alejandro Santana on 2013-12-29

[FIX] account_account_extetnded_search: clean unnecesary features, change icon.

[Alejandro Santana (alejandrosantana)]

Changes made.
Yet I am not able to load module description translation after installing it.

review: Needs Resubmitting

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Alejandro, there is still some stuff from the previous functionality: you can safely remove account_account_view.xml file, because it contains only reference to chart_template_id stuff and it's not referenced in manifest file.

As I told you in another message, translations are always handle on base module, so you are not going to be able to load any translation from the module itself. You can remove also i18n directory then.

Regards.

review: Needs Fixing

[lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search]

138. By Alejandro Santana on 2013-12-30

[FIX] Remove unnecesary files.

[Alejandro Santana (alejandrosantana)]

Done.

review: Needs Resubmitting

[Pedro Manuel Baeza (pedro.baeza)]

Perfect! Thank you very much.

Regards

review: Approve

[Alejandro Santana (alejandrosantana)]

Always welcome.

Alejandro Santana
<email address hidden>
~
ANUBÍA, soluciones en la nube, S.L.
www.anubia.es
 El 30/12/2013 15:37, "Pedro Manuel Baeza" <email address hidden> escribió:

> Review: Approve
>
> Perfect! Thank you very much.
>
> Regards
> --
>
> https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
> You are the owner of
> lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search.
>

[Graeme Gellatly (gdgellatly)]

LGTM!

review: Approve ((code review, no test))

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Is it something only used in spain? Do you have an idea?
(If yes wouldn't it be better to put it in the Spanish localization?)

review: Needs Information

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Guewen, it is used in Spain, but it's a generic tool useful for anyone that has complex account charts (some countries on South America, and so on).

Regards.

[Frederic Clementi - Camptocamp (frederic-clementi)]

Hello, I find this features really great but why using a . instead of a * for example which is more commonly used.

It is also a shame for us in switzerland since the structure of ou chart can be something like:

10.0
  101.0
    1000
    1001
  102.0

...So if I am looking for a account of the account 101.0 the result will be 101.0, 1000, 1001.
Am I correct ?

Thanks

review: Needs Information

[Alejandro Santana (alejandrosantana)]

Hello. It comes from the usage in Spain, where accounts in chart have no dots (.) and probably 99% of accountants expect and demand the dot as a wildcard.
I am not sure about the current behaviour on accounts with dots, like Swiss one you comment. I will give it a try.

One thought: Maybe the wildcard used could be selected or specified somewhere ('.', '*', other?). That way would fit in both scenarios (and maybe others).

[Alejandro Santana (alejandrosantana)]

@Frederic
OK, tested and also took a look at the code again. Right now, when using a dot in the search it serves as a wildcard for zeroes.
So in your example if you search 101.0, you would find: 101.0, 1010, 10100000, 101(any number of zeroes or the dot itself)0, but not 1001.
Also, if you search for 102.1, it will not find 102.01

Its original goal is to be used for accounts like 47200001, 47200002... (fixed digists), so you could search 472.1 and find 47200001, typing no zeroes.

[Stefan Rijnhart (Opener) (stefan-opener)]

Code looks good to me, and it's working fine. It looks to me like a very specific use case, which also does not apply to Dutch accounting habits but it may be broader than just Spanish (you never know, right?) so I think having the module here is fine.

What bothers me a little is the module name. Yes, it extends the search but it does so in a very specific way. Would you consider to change the name to something like "account_account_wildcard_zero_search"?

review: Needs Information

[Stefan Rijnhart (Opener) (stefan-opener)]

Guewen and Frederic, do the responses satisfy your information requests? Also, anyone else has an opinion about the name of the module?

[Alejandro Santana (alejandrosantana)]

Maybe the wildcard could be made configurable.
This way, Spanish accountants could use a dot (.), as they are so used to. And in other countries it could be configured to be other character, like asterisk (*) or any other.
Also, the pattern to search could be configurable too, or maybe modified to accept finding dots. Right now it searches for zeroes only. Not sure what to allow, though. What would be the needs in other countries?

What do you think? That way its case of use broadens to almost? every country.

review: Needs Information

[Frederic Clementi - Camptocamp (frederic-clementi)]

Personally, I have been practicing accounting in UK, France and Switzerland and I have never used a search based on dots. So +1 for something more configurable (hence, more generic and potentially used by more people).

If not possible, like Stefan said, we should give a more specific name (like maybe : account_wildcard_dot_search)

Frederic

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

I set as need fixing after Frederic's comment

review: Needs Fixing

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

setting the MP as work in progress. Please set it back to "needs review" when requested changes are made.

Unmerged revisions

138. By Alejandro Santana on 2013-12-30

[FIX] Remove unnecesary files.

137. By Alejandro Santana on 2013-12-29

[FIX] account_account_extetnded_search: clean unnecesary features, change icon.

136. By Alejandro Santana on 2013-12-27

[ADD] Adds account_account_extended_search providing some tools for Spanish accountants and maybe others.

=== added directory 'account_account_extended_search'
=== added file 'account_account_extended_search/__init__.py'
--- account_account_extended_search/__init__.py	1970-01-01 00:00:00 +0000
+++ account_account_extended_search/__init__.py	2013-12-30 13:16:52 +0000
@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#
+#    Copyright (c) All rights reserved:
+#        (c) 2008-2010 Zikzakmedia S.L. (http://zikzakmedia.com)
+#                      Jordi Esteve <[e-mail]>
+#        (c) 2013      Joan M. Grande <[e-mail]>
+#        (c) 2013      Anubía, soluciones en la nube,SL (http://www.anubia.es)
+#                      Alejandro Santana <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import account

=== added file 'account_account_extended_search/__openerp__.py'
--- account_account_extended_search/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_account_extended_search/__openerp__.py	2013-12-30 13:16:52 +0000
@@ -0,0 +1,62 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#
+#    Copyright (c) All rights reserved:
+#        (c) 2008-2010 Zikzakmedia S.L. (http://zikzakmedia.com)
+#                      Jordi Esteve <[e-mail]>
+#        (c) 2013      Joan M. Grande <[e-mail]>
+#        (c) 2013      Anubía, soluciones en la nube,SL (http://www.anubia.es)
+#                      Alejandro Santana <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    "name": "Extended account search using wildcard",
+    "version": "1.0",
+    "category": "Accounting/Tools",
+    "description": """
+Account search improvement for Spanish accountants:
+===================================================
+
+  * Improves the search of accounts using a dot wildcard to fill in
+    the zeroes within the account number, as it is the de facto standard
+    search in Spain (e.g. type 43.27 to search account 43000027).
+
+""",
+    "complexity": "easy",
+    "license": "AGPL-3",
+    "author": "Spanish Localization Team",
+    "website": "https://launchpad.net/openerp-spain",
+    "contributors": [
+        "Jordi Esteve <[e-mail]>",
+        "Joan M. Grande <[e-mail]>",
+        "Alejandro Santana <[e-mail]>",
+    ],
+    "depends": [
+        "account",
+    ],
+    "data": [],
+    "demo": [],
+    "test": [],
+    "images": [],
+    "active": False,
+    "installable": True,
+    "application": False,
+    "auto_install": False,
+    "certificate": "",
+}

=== added file 'account_account_extended_search/account.py'
--- account_account_extended_search/account.py	1970-01-01 00:00:00 +0000
+++ account_account_extended_search/account.py	2013-12-30 13:16:52 +0000
@@ -0,0 +1,62 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#
+#    Copyright (c) All rights reserved:
+#        (c) 2008-2010 Zikzakmedia S.L. (http://zikzakmedia.com)
+#                      Jordi Esteve <[e-mail]>
+#        (c) 2010-2010 NaN-Tic (http://www.nan-tic.com)
+#                      Albert Cervera
+#        (c) 2013      Joan M. Grande <[e-mail]>
+#        (c) 2013      Anubía, soluciones en la nube,SL (http://www.anubia.es)
+#                      Alejandro Santana <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import fields, orm
+
+
+class account_account(orm.Model):
+    _inherit = "account.account"
+
+    def search(self, cr, uid, args, offset=0, limit=None, order=None,
+               context=None, count=False):
+        """Improves the search of accounts using a dot wildcard to fill in
+        the zeroes within the account number, as it is the de facto standard
+        search in Spain. (e.g. type 43.27 to search account 43000027)."""
+        args = args[:]
+        pos = 0
+        while pos < len(args):
+            if (args[pos][0] == 'code' and
+                    args[pos][1] in ('like', 'ilike', '=like') and
+                    args[pos][2]):
+                query = args[pos][2].replace('%', '')
+                if '.' in query:
+                    query = query.partition('.')
+                    cr.execute("""SELECT id FROM account_account
+                               WHERE type <> 'view'
+                               AND code ~ ('^' || %s || '0+' || %s || '$')""",
+                               (query[0], query[2]))
+                    ids = [x[0] for x in cr.fetchall()]
+                    if ids:
+                        args[pos] = ('id', 'in', ids)
+            pos += 1
+        return super(account_account, self).search(cr, uid, args,
+                                                   offset, limit, order,
+                                                   context, count)
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added directory 'account_account_extended_search/static'
=== added directory 'account_account_extended_search/static/src'
=== added directory 'account_account_extended_search/static/src/img'
=== added file 'account_account_extended_search/static/src/img/icon.png'
Binary files account_account_extended_search/static/src/img/icon.png	1970-01-01 00:00:00 +0000 and account_account_extended_search/static/src/img/icon.png	2013-12-30 13:16:52 +0000 differ