Mir

Code review comment for lp:~albaguirre/mir/fix-1656164

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2017-01-16:

(1) A gamma size of 1 is going to throw an exception (which we are close to fixing already so probably should):

50 + if (size < 2)
51 + BOOST_THROW_EXCEPTION(std::logic_error("gamma LUT size is too small"));

121 + if (crtc->gamma_size > 0)
122 + gamma = mg::LinearGammaLUTs(crtc->gamma_size);

(2) For more advanced desktop drivers which might have a nonlinear ramp already set, won't this clobber it?

review: Needs Fixing