Merge lp:~albaguirre/mir/fix-1656164 into lp:mir

[Alberto Aguirre]

Initialize gamma LUTs with a linear ramp.

drmModeCrtcGetGamma does not query the h/w; instead it simply returns
the previous set configured with drmModeCrtcSetGamma or zeros if
drmModeCrtcSetGamma has not been previously called. (LP: #1656164)

[Mir CI Bot (mir-ci-bot)]

PASSED: Continuous integration, rev:3935
https://mir-jenkins.ubuntu.com/job/mir-ci/2702/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/3512
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3580
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3570
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3570
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3570
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3539
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3539/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3539
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3539/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3539
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3539/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3539
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3539/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3539
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3539/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3539
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3539/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2702/rebuild

review: Approve (continuous-integration)

[Brandon Schaefer (brandontschaefer)]

nit

+26 LinearGammaLUTs(int size);

Should be explicit

review: Approve

[Daniel van Vugt (vanvugt)]

(1) A gamma size of 1 is going to throw an exception (which we are close to fixing already so probably should):

50 + if (size < 2)
51 + BOOST_THROW_EXCEPTION(std::logic_error("gamma LUT size is too small"));

121 + if (crtc->gamma_size > 0)
122 + gamma = mg::LinearGammaLUTs(crtc->gamma_size);

(2) For more advanced desktop drivers which might have a nonlinear ramp already set, won't this clobber it?

review: Needs Fixing

[Alberto Aguirre (albaguirre)]

> (1) A gamma size of 1 is going to throw an exception (which we are close to
> fixing already so probably should):
>
> 50 + if (size < 2)
> 51 + BOOST_THROW_EXCEPTION(std::logic_error("gamma LUT size is too
> small"));
>

Yes a size of 1 should throw otherwise you'd get a division by zero.

> 121 + if (crtc->gamma_size > 0)
> 122 + gamma = mg::LinearGammaLUTs(crtc->gamma_size);
>
> (2) For more advanced desktop drivers which might have a nonlinear ramp
> already set, won't this clobber it?

Yeah but that's pre-existing behavior given the current design of drmModeCrtcGetGamma. This MP does not change that;

[Mir CI Bot (mir-ci-bot)]

FAILED: Continuous integration, rev:3936
https://mir-jenkins.ubuntu.com/job/mir-ci/2720/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3538/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3606
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3596
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3596
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3596
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3565
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3565/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3565
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3565/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3565
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3565/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3565
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3565/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3565
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3565/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3565/console

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2720/rebuild

review: Needs Fixing (continuous-integration)

[Mir CI Bot (mir-ci-bot)]

FAILED: Continuous integration, rev:3936
https://mir-jenkins.ubuntu.com/job/mir-ci/2723/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3543/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3611
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3601
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3601
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3601
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3570
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3570/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3570/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3570
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3570/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3570
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3570/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3570
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3570/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3570
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3570/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/2723/rebuild

review: Needs Fixing (continuous-integration)

[Mir CI Bot (mir-ci-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
https://mir-jenkins.ubuntu.com/job/mir-autolanding/961/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/3549/console
    None: https://mir-jenkins.ubuntu.com/job/generic-land-mp/1013/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/3617
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/3607
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/3607
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/3607
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3576
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/3576/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3576
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial+overlay/3576/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/3576/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3576
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/3576/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3576
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/3576/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3576
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial+overlay/3576/artifact/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)

[Brandon Schaefer (brandontschaefer)]

[ FAILED ] ApplicationNotRespondingDetection.failure_to_pong_is_noticed

[Daniel van Vugt (vanvugt)]

I mean that we should only throw exceptions for things we don't know how to handle. We probably know how to handle the problem of a length 1 table... just log a warning/error and ignore it.

review: Needs Fixing

[Daniel van Vugt (vanvugt)]

Although... this probably falls into the bucket of things that might go wrong during display config changes. So yeah expect an exception in that case.

review: Approve

[Mir CI Bot (mir-ci-bot)]

review: Approve (continuous-integration)

=== modified file 'include/platform/mir/graphics/gamma_curves.h'
--- include/platform/mir/graphics/gamma_curves.h	2016-10-31 02:37:31 +0000
+++ include/platform/mir/graphics/gamma_curves.h	2017-01-16 15:30:49 +0000
@@ -33,16 +33,27 @@
 {
 public:
     GammaCurves() = default;
+    GammaCurves(GammaCurves const& other) = default;
+    GammaCurves(GammaCurves&& other) = default;
 
     GammaCurves(GammaCurve const& red,
                 GammaCurve const& green,
                 GammaCurve const& blue);
 
+    GammaCurves& operator=(GammaCurves const& other) = default;
+    GammaCurves& operator=(GammaCurves&& other) = default;
+
     GammaCurve red;
     GammaCurve green;
     GammaCurve blue;
 };
 
+class LinearGammaLUTs : public GammaCurves
+{
+public:
+    explicit LinearGammaLUTs(int size);
+};
+
 }
 }
 

=== modified file 'src/platform/graphics/gamma_curves.cpp'
--- src/platform/graphics/gamma_curves.cpp	2016-10-31 02:37:31 +0000
+++ src/platform/graphics/gamma_curves.cpp	2017-01-16 15:30:49 +0000
@@ -19,10 +19,27 @@
 #include "mir/graphics/gamma_curves.h"
 
 #include <boost/throw_exception.hpp>
+
+#include <algorithm>
 #include <stdexcept>
 
 namespace mg = mir::graphics;
 
+namespace
+{
+mg::GammaCurves make_linear_ramp(int size)
+{
+    if (size < 2)
+        BOOST_THROW_EXCEPTION(std::logic_error("gamma LUT size is too small"));
+
+    mg::GammaCurve ramp(size);
+    auto const step = std::numeric_limits<mg::GammaCurve::value_type>::max() / (size - 1);
+    mg::GammaCurve::value_type n = 0;
+    std::generate(ramp.begin(), ramp.end(), [&n, step]{ auto current = n; n += step; return current; });
+
+    return {ramp, ramp, ramp};
+}
+}
 mg::GammaCurves::GammaCurves(GammaCurve const& red,
                              GammaCurve const& green,
                              GammaCurve const& blue) :
@@ -36,3 +53,8 @@
         BOOST_THROW_EXCEPTION(std::logic_error("Different gamma LUT sizes"));
     }
 }
+
+mg::LinearGammaLUTs::LinearGammaLUTs(int size)
+  : GammaCurves(make_linear_ramp(size))
+{
+}

=== modified file 'src/platform/symbols.map'
--- src/platform/symbols.map	2016-11-16 13:24:41 +0000
+++ src/platform/symbols.map	2017-01-16 15:30:49 +0000
@@ -67,6 +67,7 @@
     mir::graphics::GraphicBufferAllocator::GraphicBufferAllocator*;
     mir::graphics::GraphicBufferAllocator::operator*;
     mir::graphics::GraphicBufferAllocator::supported_pixel_formats*;
+    mir::graphics::LinearGammaLUTs::LinearGammaLUTs*;
     mir::graphics::module_for_device*;
     mir::graphics::operator*;
     mir::graphics::Platform::create_buffer_allocator*;

=== modified file 'src/platforms/mesa/server/kms/real_kms_display_configuration.cpp'
--- src/platforms/mesa/server/kms/real_kms_display_configuration.cpp	2016-12-09 02:54:31 +0000
+++ src/platforms/mesa/server/kms/real_kms_display_configuration.cpp	2017-01-16 15:30:49 +0000
@@ -179,26 +179,6 @@
     return conf_mode_index;
 }
 
-mg::GammaCurves mgm::RealKMSDisplayConfiguration::get_drm_gamma(
-    drmModeCrtc const* crtc) const
-{
-    uint32_t gamma_size = crtc->gamma_size;
-    uint16_t red[gamma_size];
-    uint16_t green[gamma_size];
-    uint16_t blue[gamma_size];
-
-    int ret;
-    if ((ret = drmModeCrtcGetGamma(drm_fd, crtc->crtc_id, gamma_size, red, green, blue)) != 0)
-    {
-        BOOST_THROW_EXCEPTION(
-            std::system_error(errno, std::system_category(), "drmModeCrtcGetGamma Failed"));
-    }
-
-    return {GammaCurve(red, red + gamma_size),
-            GammaCurve(green, green + gamma_size),
-            GammaCurve(blue, blue + gamma_size)};
-}
-
 void mgm::RealKMSDisplayConfiguration::update()
 {
     kms::DRMModeResources resources{drm_fd};
@@ -327,7 +307,8 @@
             current_mode_info = resources.crtc(encoder->crtc_id)->mode;
 
             auto crtc = resources.crtc(encoder->crtc_id);
-            gamma = get_drm_gamma(crtc.get());
+            if (crtc->gamma_size > 0)
+                gamma = mg::LinearGammaLUTs(crtc->gamma_size);
         }
     }
 

=== modified file 'src/platforms/mesa/server/kms/real_kms_display_configuration.h'
--- src/platforms/mesa/server/kms/real_kms_display_configuration.h	2016-10-12 06:03:15 +0000
+++ src/platforms/mesa/server/kms/real_kms_display_configuration.h	2017-01-16 15:30:49 +0000
@@ -53,7 +53,6 @@
     void add_or_update_output(kms::DRMModeResources const& resources, drmModeConnector const& connector);
     std::vector<DisplayConfigurationOutput>::iterator find_output_with_id(DisplayConfigurationOutputId id);
     std::vector<DisplayConfigurationOutput>::const_iterator find_output_with_id(DisplayConfigurationOutputId id) const;
-    GammaCurves get_drm_gamma(drmModeCrtc const* crtc) const;
 
     int drm_fd;
     DisplayConfigurationCard card;

=== modified file 'tests/unit-tests/graphics/test_gamma_curves.cpp'
--- tests/unit-tests/graphics/test_gamma_curves.cpp	2016-09-27 08:16:43 +0000
+++ tests/unit-tests/graphics/test_gamma_curves.cpp	2017-01-16 15:30:49 +0000
@@ -21,47 +21,76 @@
 #include <gtest/gtest.h>
 #include <gmock/gmock.h>
 
+#include <algorithm>
+
 namespace mg = mir::graphics;
 
 namespace
 {
-mg::GammaCurve const r{1};
-mg::GammaCurve const g{2};
-mg::GammaCurve const b{3};
-}
-
-class MockGammaCurves : public testing::Test
+MATCHER(IsMonotonicallyIncreasing, "")
+{
+    return std::is_sorted(std::begin(arg), std::end(arg));
+}
+}
+class GammaCurves : public testing::Test
 {
 public:
-    MockGammaCurves() :
-        gamma(r, g, b)
-    {
-    }
-
-    mg::GammaCurves gamma;
+    mg::GammaCurve const r{1};
+    mg::GammaCurve const g{2};
+    mg::GammaCurve const b{3};
+    mg::GammaCurves gamma{r, g, b};
 };
 
-TEST_F(MockGammaCurves, test_uint16_gamma_curves_size)
+TEST_F(GammaCurves, have_correct_size)
 {
     EXPECT_THAT(gamma.red.size(), r.size());
+    EXPECT_THAT(gamma.green.size(), g.size());
+    EXPECT_THAT(gamma.blue.size(), b.size());
 }
 
-TEST_F(MockGammaCurves, test_uint16_gamma_curves_rgb_correct)
+TEST_F(GammaCurves, have_expected_content)
 {
-    ASSERT_THAT(gamma.red.size(), r.size());
-    EXPECT_THAT(gamma.red[0], r[0]);
-    EXPECT_THAT(gamma.green[0], g[0]);
-    EXPECT_THAT(gamma.blue[0], b[0]);
+    using namespace testing;
+    EXPECT_THAT(gamma.red, ContainerEq(r));
+    EXPECT_THAT(gamma.green, ContainerEq(g));
+    EXPECT_THAT(gamma.blue, ContainerEq(b));
 }
 
-TEST(GammaCurvesEmpty, test_gamma_curves_empty)
+TEST_F(GammaCurves, are_empty_by_default)
 {
     mg::GammaCurves gamma;
 
     EXPECT_THAT(gamma.red.size(), 0);
+    EXPECT_THAT(gamma.green.size(), 0);
+    EXPECT_THAT(gamma.blue.size(), 0);
 }
 
-TEST(GammaCurvesEmpty, test_invalid_lut_size_gamma_curves_throw)
+TEST_F(GammaCurves, throw_with_differing_lut_sizes)
 {
     EXPECT_THROW({ mg::GammaCurves({1}, {2, 3}, {4, 5, 6}); }, std::logic_error);
 }
+
+TEST(LinearGammaLUTs, throw_when_size_is_too_small)
+{
+    EXPECT_THROW({ mg::LinearGammaLUTs(1); }, std::logic_error);
+}
+
+TEST(LinearGammaLUTs, have_expected_size)
+{
+    int const expected_size = 10;
+    mg::LinearGammaLUTs luts(expected_size);
+
+    EXPECT_THAT(luts.red.size(), expected_size);
+    EXPECT_THAT(luts.green.size(), expected_size);
+    EXPECT_THAT(luts.blue.size(), expected_size);
+}
+
+TEST(LinearGammaLUTs, is_monotonically_increasing)
+{
+    mg::LinearGammaLUTs luts(256);
+
+    EXPECT_THAT(luts.red, IsMonotonicallyIncreasing());
+    EXPECT_THAT(luts.green, IsMonotonicallyIncreasing());
+    EXPECT_THAT(luts.blue, IsMonotonicallyIncreasing());
+}
+

=== modified file 'tests/unit-tests/platforms/mesa/kms/test_display.cpp'
--- tests/unit-tests/platforms/mesa/kms/test_display.cpp	2016-11-11 07:56:09 +0000
+++ tests/unit-tests/platforms/mesa/kms/test_display.cpp	2017-01-16 15:30:49 +0000
@@ -234,12 +234,6 @@
     EXPECT_CALL(mock_gbm, gbm_surface_create(mock_gbm.fake_gbm.device,_,_,_,_))
         .Times(Exactly(1));
 
-    /* Get the DRM gamma ramp */
-    EXPECT_CALL(mock_drm, drmModeCrtcGetGamma(mock_drm.fake_drm.fd(),
-                                              crtc_id, fake.crtc.gamma_size,
-                                              _, _, _))
-        .Times(Exactly(1));
-
     /* Create an EGL window surface backed by the gbm surface */
     EXPECT_CALL(mock_egl, eglCreateWindowSurface(mock_egl.fake_egl_display,
                                                  mock_egl.fake_configs[0],