Code review comment for ~alanec/plainbox-provider-resource:cpufreq_test-support-res

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

As Maciej said, hardcoding path this way won't work everywhere and implies a dependency on the checkbox provider (but it's the other way around actually), see https://git.launchpad.net/~checkbox-dev/plainbox-provider-checkbox/+git/packaging/tree/debian/control#n23

Would it be possible to add the necessary bits to https://git.launchpad.net/plainbox-provider-resource/tree/bin/cpuinfo_resource.py in order to report if scaling is supported.

and having a resource expression like this one in provider checkbox:

cpuinfo.scaling == 'supported'

review: Needs Fixing

« Back to merge proposal