Merge ~alanec/plainbox-provider-resource:cpufreq_test-support-res into plainbox-provider-resource:master

[Adrian Lane]

Added resource to allow plainbox-provider-checkbox/bin/cpufreq_test.py to be skipped if cpufreq scaling non-supported.

[Adrian Lane (alanec)]

Dependent resource update in checkbox-provider-checkbox:

https://code.launchpad.net/~alanec/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/398394

[Adrian Lane (alanec)]

> Dependent resource update in *checkbox-provider-checkbox:
*plainbox-provider-checkbox

[Maciej Kisielewski (kissiel)]

The resoruce provider should not depend on the checkbox provider. Hardcoding paths like that doesn't work on at half of the systems we test.

Scaling support should be a field in cpuinfo resource job. The jobs requiring scaling to be supported should check that field.

review: Needs Fixing

[Sylvain Pineau (sylvain-pineau)]

As Maciej said, hardcoding path this way won't work everywhere and implies a dependency on the checkbox provider (but it's the other way around actually), see https://git.launchpad.net/~checkbox-dev/plainbox-provider-checkbox/+git/packaging/tree/debian/control#n23

Would it be possible to add the necessary bits to https://git.launchpad.net/plainbox-provider-resource/tree/bin/cpuinfo_resource.py in order to report if scaling is supported.

and having a resource expression like this one in provider checkbox:

cpuinfo.scaling == 'supported'

review: Needs Fixing

[Adrian Lane (alanec)]

This sounds reasonable to me. I cam go ahead and move the logic to the mentioned file.
MR's en-route shortly.

[Sylvain Pineau (sylvain-pineau)]

thanks a lot!

[Adrian Lane (alanec)]

Getting back around to this change, worked out a solution as previously discussed. Submitted new MRs for this, and will close out this MR.

I much prefer this way of checking the dependency for the test, good call (and kept it simple).

MRs:
https://code.launchpad.net/~alanec/plainbox-provider-resource/+git/plainbox-provider-resource/+merge/400085
https://code.launchpad.net/~alanec/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/400086

[Jeff Lane  (bladernr)]

Rejected per comment from Adrian.

Unmerged commits

8eb2734... by Adrian Lane on 2021-02-19

Added resource to allow plainbox-provider-checkbox/bin/cpufreq_test.py to be skipped if cpufreq scaling non-supported. lp: 1913397

diff --git a/jobs/resource.pxu b/jobs/resource.pxu
index bfde8f3..4e16b0e 100644
--- a/jobs/resource.pxu
+++ b/jobs/resource.pxu
@@ -482,3 +482,16 @@ command:
  else
      echo "detected: true"
  fi
+
+id: cpufreqtest_resource
+estimated_duration: 0.25
+plugin: resource
+user: root
+_summary: Pre-test check for CPUFreq support
+command:
+ if ( /usr/lib/plainbox-provider-checkbox/bin/cpufreq_test.py -s );
+ then
+     echo "supported: true"
+ else
+     echo "supported: false"
+ fi