Code review comment for ~alanec/plainbox-provider-checkbox:cpufreq_test-failure-output

I'm not entirely sure what --verbose does, actually? looking at a diff of the output of -v and -d run back to back on the same machine, there doesn't appear to be any substantive difference.

In fact once I remove the unimportant differing lines (just the ones where on the first run a timestamp, pid, or other number was different) the only difference between the two is this:

  1 3a4,5
  2 > * disabling thread siblings (hyperthreading):
  3 > - disabling cores: {4, 5, 6, 7}

those two lines are present in the debug but not in verbose.

Also, for normal output (e.g. not -v or -d) I think all we need is this:

[CpuFreqTest Results]
 - legend:
   {core: {target_freq:[sampled_med_%, P/F, sampled_median],:.

{0: {800000: ['100%', 'Pass', 800000]},
 1: {800000: ['100%', 'Pass', 800000]},
 2: {800000: ['100%', 'Pass', 800000]},
 3: {800000: ['100%', 'Pass', 800000]}}

[Test Passed]

and THIS should be the output for -v

$ sudo ./cpufreq_test.py
---------------------
| CpuFreqTest Begin |
---------------------
* disabling thread siblings (hyperthreading):
  - disabling cores: {4, 5, 6, 7}
* configuring cpu governors:
  - setting governor: performance
---------------------
* testing: cpu1 || target freq: 800000 || work: fact(39340) || worker pid: 25775
* testing: cpu2 || target freq: 800000 || work: fact(39002) || worker pid: 25776
* testing: cpu3 || target freq: 800000 || work: fact(37725) || worker pid: 25777
* testing: cpu0 || target freq: 800000 || work: fact(38232) || worker pid: 25778
* testing: cpu3 || target freq: 800000 || work: fact(38298) || worker pid: 25777
* testing: cpu1 || target freq: 800000 || work: fact(39484) || worker pid: 25775
* testing: cpu0 || target freq: 800000 || work: fact(38701) || worker pid: 25778
* testing: cpu2 || target freq: 800000 || work: fact(39627) || worker pid: 25776
----------------------------
* joining and closing queues
* joining worker processes:
  - PID 25775 joined parent
  - PID 25776 joined parent
  - PID 25777 joined parent
  - PID 25778 joined parent

-----------------
| Test Complete |
-----------------

[Reset & Cleanup]
* restoring startup governor:
  - setting governor: performance
* enabling thread siblings/hyperthreading:
  - enabling cores: {4, 5, 6, 7}
* restoring max, min freq files
* terminating dangling pids
* active threads: 1

[CpuFreqTest Results]
 - legend:
   {core: {target_freq:[sampled_med_%, P/F, sampled_median],:.

{0: {800000: ['100%', 'Pass', 800000]},
 1: {800000: ['100%', 'Pass', 800000]},
 2: {800000: ['100%', 'Pass', 800000]},
 3: {800000: ['100%', 'Pass', 800000]}}

[Test Passed]

And then -d should stay as it is.