Merge ~alanec/plainbox-provider-checkbox:cpufreq_test-failure-output into plainbox-provider-checkbox:master
Proposed by
Adrian Lane
Status: | Merged |
---|---|
Approved by: | Jeff Lane |
Approved revision: | 9fa92cce7d6b6d00a6c188859589d4ccd6b73079 |
Merged at revision: | 25fbafa5254782a8cfb1db8dc01629d38312bc27 |
Proposed branch: | ~alanec/plainbox-provider-checkbox:cpufreq_test-failure-output |
Merge into: | plainbox-provider-checkbox:master |
Diff against target: |
48 lines (+14/-8) 1 file modified
bin/cpufreq_test.py (+14/-8) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeff Lane | Approve | ||
Review via email: mp+399106@code.launchpad.net |
Description of the change
Simple update to ensure that when this test fails, we output the results of the test, even in quiet mode.
This is to address some of the bare bone failures we're seeing, as currently we're having the test manually re-run without output turned on to get more information.
This has a higher priority than the other MR in progress (support mode / support check).
To post a comment you must log in.
I'm not entirely sure what --verbose does, actually? looking at a diff of the output of -v and -d run back to back on the same machine, there doesn't appear to be any substantive difference.
In fact once I remove the unimportant differing lines (just the ones where on the first run a timestamp, pid, or other number was different) the only difference between the two is this:
1 3a4,5
2 > * disabling thread siblings (hyperthreading):
3 > - disabling cores: {4, 5, 6, 7}
those two lines are present in the debug but not in verbose.
Also, for normal output (e.g. not -v or -d) I think all we need is this:
[CpuFreqTest Results] freq:[sampled_ med_%, P/F, sampled_median],:.
- legend:
{core: {target_
{0: {800000: ['100%', 'Pass', 800000]},
1: {800000: ['100%', 'Pass', 800000]},
2: {800000: ['100%', 'Pass', 800000]},
3: {800000: ['100%', 'Pass', 800000]}}
[Test Passed]
and THIS should be the output for -v
$ sudo ./cpufreq_test.py ------- ------- ------- ------- ------- ------- ------- ------- -------
-------
| CpuFreqTest Begin |
-------
* disabling thread siblings (hyperthreading):
- disabling cores: {4, 5, 6, 7}
* configuring cpu governors:
- setting governor: performance
-------
* testing: cpu1 || target freq: 800000 || work: fact(39340) || worker pid: 25775
* testing: cpu2 || target freq: 800000 || work: fact(39002) || worker pid: 25776
* testing: cpu3 || target freq: 800000 || work: fact(37725) || worker pid: 25777
* testing: cpu0 || target freq: 800000 || work: fact(38232) || worker pid: 25778
* testing: cpu3 || target freq: 800000 || work: fact(38298) || worker pid: 25777
* testing: cpu1 || target freq: 800000 || work: fact(39484) || worker pid: 25775
* testing: cpu0 || target freq: 800000 || work: fact(38701) || worker pid: 25778
* testing: cpu2 || target freq: 800000 || work: fact(39627) || worker pid: 25776
-------
* joining and closing queues
* joining worker processes:
- PID 25775 joined parent
- PID 25776 joined parent
- PID 25777 joined parent
- PID 25778 joined parent
-----------------
| Test Complete |
-----------------
[Reset & Cleanup] hyperthreading:
* restoring startup governor:
- setting governor: performance
* enabling thread siblings/
- enabling cores: {4, 5, 6, 7}
* restoring max, min freq files
* terminating dangling pids
* active threads: 1
[CpuFreqTest Results] freq:[sampled_ med_%, P/F, sampled_median],:.
- legend:
{core: {target_
{0: {800000: ['100%', 'Pass', 800000]},
1: {800000: ['100%', 'Pass', 800000]},
2: {800000: ['100%', 'Pass', 800000]},
3: {800000: ['100%', 'Pass', 800000]}}
[Test Passed]
And then -d should stay as it is.