Mir

Code review comment for lp:~alan-griffiths/mir/fix-1615587

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Hmm, it is a bit weird actually. I can't remember now why we bother avoiding C++ mangling on code that is strictly not C-compatible anyway. Although I would prefer our driver model was plain C, since it's not, why are we giving it that appearance?

Symbol mangling follows strict rules. So we could just make them proper C++ functions and go searching for the proper mangled C++ symbol names. You only have to figure out what each mangled name is once, and code it once.

It feels like this makes a hack into a worse hack. But not that much worse, so abstain.

review: Abstain

« Back to merge proposal