Merge lp:~alan-griffiths/mir/fix-1615587 into lp:mir
Proposed by
Alan Griffiths
Status: | Merged |
---|---|
Merged at revision: | 3668 |
Proposed branch: | lp:~alan-griffiths/mir/fix-1615587 |
Merge into: | lp:mir |
Diff against target: |
155 lines (+59/-1) 7 files modified
CMakeLists.txt (+1/-1) include/platform/mir/graphics/platform.h (+10/-0) include/platform/mir/input/platform.h (+11/-0) src/include/client/mir/client_platform_factory.h (+9/-0) tests/mir_test_framework/stub_input.cpp (+9/-0) tests/mir_test_framework/stubbed_graphics_platform.cpp (+9/-0) tests/unit-tests/library_example.h (+10/-0) |
To merge this branch: | bzr merge lp:~alan-griffiths/mir/fix-1615587 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kevin DuBois (community) | Approve | ||
Mir CI Bot | continuous-integration | Needs Fixing | |
Daniel van Vugt | Abstain | ||
Chris Halse Rogers | Approve | ||
Review via email: mp+303539@code.launchpad.net |
Commit message
We use "C" linkage to avoid name-mangling some functions that are not intended not for C compatibility. We don't want downstream projects seeing a warning from clang based tools for us doing this intentionally. (LP: 1615587)
To post a comment you must log in.
FAILED: Continuous integration, rev:3661 /mir-jenkins. ubuntu. com/job/ mir-ci/ 1502/ /mir-jenkins. ubuntu. com/job/ build-mir/ 1869/console /mir-jenkins. ubuntu. com/job/ build-0- fetch/1928 /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= vivid+overlay/ 1919 /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= xenial+ overlay/ 1919 /mir-jenkins. ubuntu. com/job/ build-1- sourcepkg/ release= yakkety/ 1919 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= clang,platform= mesa,release= yakkety/ 1893/console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= xenial+ overlay/ 1893 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= xenial+ overlay/ 1893/artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= yakkety/ 1893 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= amd64,compiler= gcc,platform= mesa,release= yakkety/ 1893/artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= cross-armhf, compiler= gcc,platform= android, release= vivid+overlay/ 1893/console /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= cross-armhf, compiler= gcc,platform= android, release= vivid+overlay/ 1893/artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= android, release= vivid+overlay/ 1893 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= android, release= vivid+overlay/ 1893/artifact/ output/ *zip*/output. zip /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= mesa,release= xenial+ overlay/ 1893 /mir-jenkins. ubuntu. com/job/ build-2- binpkg- mir/arch= i386,compiler= gcc,platform= mesa,release= xenial+ overlay/ 1893/artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /mir-jenkins. ubuntu. com/job/ mir-ci/ 1502/rebuild
https:/